Skip to content

Commit 8ebbe08

Browse files
committed
improve tests
1 parent b815844 commit 8ebbe08

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

internal/services/container/namespace_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ func TestAccNamespace_Basic(t *testing.T) {
8989
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "name", "test-cr-ns-01"),
9090
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "environment_variables.test", "test"),
9191
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "secret_environment_variables.test_secret", "test_secret"),
92+
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.#", "2"),
9293
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.0", "tag1"),
9394
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.1", "tag2"),
9495

@@ -105,6 +106,7 @@ func TestAccNamespace_Basic(t *testing.T) {
105106
resource.TestCheckResourceAttrSet("scaleway_container_namespace.main", "name"),
106107
resource.TestCheckResourceAttrSet("scaleway_container_namespace.main", "registry_endpoint"),
107108
resource.TestCheckResourceAttrSet("scaleway_container_namespace.main", "registry_namespace_id"),
109+
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.#", "0"),
108110
),
109111
},
110112
{
@@ -124,7 +126,7 @@ func TestAccNamespace_Basic(t *testing.T) {
124126
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "name", "tf-env-test"),
125127
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "environment_variables.test", "test"),
126128
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "secret_environment_variables.test_secret", "test_secret"),
127-
129+
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.#", "0"),
128130
acctest.CheckResourceAttrUUID("scaleway_container_namespace.main", "id"),
129131
),
130132
},
@@ -145,7 +147,7 @@ func TestAccNamespace_Basic(t *testing.T) {
145147
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "name", "tf-env-test"),
146148
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "environment_variables.foo", "bar"),
147149
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "secret_environment_variables.foo_secret", "bar_secret"),
148-
150+
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.#", "0"),
149151
acctest.CheckResourceAttrUUID("scaleway_container_namespace.main", "id"),
150152
),
151153
},
@@ -159,6 +161,7 @@ func TestAccNamespace_Basic(t *testing.T) {
159161
Check: resource.ComposeTestCheckFunc(
160162
isNamespacePresent(tt, "scaleway_container_namespace.main"),
161163
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "name", "tf-tags-test"),
164+
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.#", "2"),
162165
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.0", "tag1"),
163166
resource.TestCheckResourceAttr("scaleway_container_namespace.main", "tags.1", "tag2"),
164167

internal/services/function/namespace_test.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,15 @@ func TestAccFunctionNamespace_Basic(t *testing.T) {
2525
Config: `
2626
resource scaleway_function_namespace main {
2727
name = "test-cr-ns-01"
28+
tags = ["tag1", "tag2"]
2829
}
2930
`,
3031
Check: resource.ComposeTestCheckFunc(
3132
testAccCheckFunctionNamespaceExists(tt, "scaleway_function_namespace.main"),
3233
acctest.CheckResourceAttrUUID("scaleway_function_namespace.main", "id"),
34+
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "tags.#", "2"),
35+
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "tags.0", "tag1"),
36+
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "tags.1", "tag2"),
3337
),
3438
},
3539
{
@@ -44,6 +48,7 @@ func TestAccFunctionNamespace_Basic(t *testing.T) {
4448
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "description", "test function namespace 01"),
4549
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "name", "test-cr-ns-01"),
4650
acctest.CheckResourceAttrUUID("scaleway_function_namespace.main", "id"),
51+
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "tags.#", "0"),
4752
),
4853
},
4954
{
@@ -64,6 +69,7 @@ func TestAccFunctionNamespace_Basic(t *testing.T) {
6469
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "name", "test-cr-ns-01"),
6570
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "environment_variables.test", "test"),
6671
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "secret_environment_variables.test_secret", "test_secret"),
72+
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "tags.#", "0"),
6773

6874
acctest.CheckResourceAttrUUID("scaleway_function_namespace.main", "id"),
6975
),
@@ -87,6 +93,7 @@ func TestAccFunctionNamespace_Basic(t *testing.T) {
8793
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "name", "test-cr-ns-01"),
8894
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "environment_variables.test", "test"),
8995
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "secret_environment_variables.test_secret", "test_secret"),
96+
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "tags.#", "2"),
9097
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "tags.0", "tag1"),
9198
resource.TestCheckResourceAttr("scaleway_function_namespace.main", "tags.1", "tag2"),
9299

0 commit comments

Comments
 (0)