Skip to content

Commit 8f71c6c

Browse files
committed
remove comment
1 parent 25f0452 commit 8f71c6c

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

docs/resources/inference_custom_model.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ resource "scaleway_inference_deployment" "main" {
5151

5252
## Attributes Reference
5353

54+
In addition to all arguments above, the following attributes are exported:
55+
5456
- `id` - The unique identifier of the custom model.
5557
- `tags` - Tags associated with the model.
5658
- `status` - The current status of the model (e.g., ready, error, etc.).

internal/services/inference/custom_model.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,8 +193,8 @@ func ResourceCustomModelRead(ctx context.Context, d *schema.ResourceData, m inte
193193
return diag.FromErr(err)
194194
}
195195

196-
_ = d.Set("parameter_size_bits", model.ParameterSizeBits)
197-
_ = d.Set("size_bits", model.SizeBytes)
196+
_ = d.Set("parameter_size_bits", int32(model.ParameterSizeBits))
197+
_ = d.Set("size_bits", int64(model.SizeBytes))
198198
_ = d.Set("name", model.Name)
199199
_ = d.Set("status", model.Status)
200200
_ = d.Set("description", model.Description)

internal/services/inference/testdata/custom-model-not-compatible.cassette.yaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,17 @@ interactions:
3838
Content-Type:
3939
- application/json
4040
Date:
41-
- Fri, 25 Apr 2025 15:37:39 GMT
41+
- Mon, 28 Apr 2025 11:23:17 GMT
4242
Server:
43-
- Scaleway API Gateway (fr-par-2;edge02)
43+
- Scaleway API Gateway (fr-par-2;edge01)
4444
Strict-Transport-Security:
4545
- max-age=63072000
4646
X-Content-Type-Options:
4747
- nosniff
4848
X-Frame-Options:
4949
- DENY
5050
X-Request-Id:
51-
- 993d22da-5ce4-4ec3-aa89-9de4eb38e365
51+
- e9121dee-50c0-4ff8-9c8c-8dcebc0d6086
5252
status: 412 Precondition Failed
5353
code: 412
54-
duration: 333.152083ms
54+
duration: 263.222333ms

internal/services/inference/testfuncs/checks.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ func IsCustomModelDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
6666
return err
6767
}
6868
}
69-
69+
7070
return nil
7171
}
7272
}

internal/services/inference/waiter.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ func waitForModel(ctx context.Context, inferenceAPI *inference.API, region scw.R
3131
retryInterval = *transport.DefaultWaitRetryInterval
3232
}
3333

34-
model, err := inferenceAPI.WaitForCustomModel(inference.WaitForCustomModelRequest{ //TODO add pointer
34+
model, err := inferenceAPI.WaitForCustomModel(inference.WaitForCustomModelRequest{
3535
ModelID: id,
3636
Region: region,
3737
RetryInterval: &retryInterval,

0 commit comments

Comments
 (0)