feat(object): require index_document for website configurations (#1565)

Author: quantumsheep

docs/resources/object_bucket_website_configuration.md

@@ -68,14 +68,8 @@ resource "scaleway_object_bucket_website_configuration" "main" {
 The following arguments are supported:
 
 * `bucket` - (Required, Forces new resource) The name of the bucket.
+* `index_document` - (Required) The name of the index document for the website [detailed below](#index_document).
 * `error_document` - (Optional) The name of the error document for the website [detailed below](#error_document).
-* `index_document` - (Optional) The name of the index document for the website [detailed below](#index_document).
-
-## error_document
-
-The error_document configuration block supports the following arguments:
-
-* `key` - (Required) The object key name to use when a 4XX class error occurs.
 
 ## index_document
 
@@ -93,6 +87,12 @@ In addition to all above arguments, the following attribute is exported:
 
 ~> **Important:** Please check our concepts section to know more about the [endpoint](https://www.scaleway.com/en/docs/storage/object/concepts/#endpoint).
 
+## error_document
+
+The error_document configuration block supports the following arguments:
+
+* `key` - (Required) The object key name to use when a 4XX class error occurs.
+
 ## Import
 
 Website configuration Bucket can be imported using the `{region}/{bucketName}` identifier, e.g.

scaleway/resource_object_bucket_website_configuration.go

@@ -37,33 +37,34 @@ func ResourceBucketWebsiteConfiguration() *schema.Resource {
 				ValidateFunc: validation.StringLenBetween(1, 63),
 				Description:  "The bucket name.",
 			},
-			"error_document": {
+			"index_document": {
 				Type:     schema.TypeList,
-				Optional: true,
+				Required: true,
+				MinItems: 1,
 				MaxItems: 1,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
-						"key": {
+						"suffix": {
 							Type:     schema.TypeString,
 							Required: true,
 						},
 					},
 				},
-				Description: "The name of the error document for the website.",
+				Description: "The name of the index document for the website.",
 			},
-			"index_document": {
+			"error_document": {
 				Type:     schema.TypeList,
 				Optional: true,
 				MaxItems: 1,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
-						"suffix": {
+						"key": {
 							Type:     schema.TypeString,
 							Required: true,
 						},
 					},
 				},
-				Description: "The name of the index document for the website.",
+				Description: "The name of the error document for the website.",
 			},
 			"website_endpoint": {
 				Type:        schema.TypeString,
@@ -87,16 +88,14 @@ func resourceBucketWebsiteConfigurationCreate(ctx context.Context, d *schema.Res
 
 	bucket := expandID(d.Get("bucket").(string))
 
-	websiteConfig := &s3.WebsiteConfiguration{}
+	websiteConfig := &s3.WebsiteConfiguration{
+		IndexDocument: expandBucketWebsiteConfigurationIndexDocument(d.Get("index_document").([]interface{})),
+	}
 
 	if v, ok := d.GetOk("error_document"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
 		websiteConfig.ErrorDocument = expandBucketWebsiteConfigurationErrorDocument(v.([]interface{}))
 	}
 
-	if v, ok := d.GetOk("index_document"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
-		websiteConfig.IndexDocument = expandBucketWebsiteConfigurationIndexDocument(v.([]interface{}))
-	}
-
 	_, err = conn.ListObjectsWithContext(ctx, &s3.ListObjectsInput{
 		Bucket: scw.StringPtr(bucket),
 	})
@@ -168,15 +167,12 @@ func resourceBucketWebsiteConfigurationRead(ctx context.Context, d *schema.Resou
 	}
 
 	_ = d.Set("bucket", bucket)
+	_ = d.Set("index_document", flattenBucketWebsiteConfigurationIndexDocument(output.IndexDocument))
 
 	if err := d.Set("error_document", flattenBucketWebsiteConfigurationErrorDocument(output.ErrorDocument)); err != nil {
 		return diag.FromErr(fmt.Errorf("error setting error_document: %w", err))
 	}
 
-	if err := d.Set("index_document", flattenBucketWebsiteConfigurationIndexDocument(output.IndexDocument)); err != nil {
-		return diag.FromErr(fmt.Errorf("error setting index_document: %w", err))
-	}
-
 	// Add website_endpoint and website_domain as attributes
 	websiteEndpoint, err := resourceBucketWebsiteConfigurationWebsiteEndpoint(ctx, conn, bucket, region)
 	if err != nil {
@@ -197,16 +193,14 @@ func resourceBucketWebsiteConfigurationUpdate(ctx context.Context, d *schema.Res
 		return diag.FromErr(err)
 	}
 
-	websiteConfig := &s3.WebsiteConfiguration{}
+	websiteConfig := &s3.WebsiteConfiguration{
+		IndexDocument: expandBucketWebsiteConfigurationIndexDocument(d.Get("index_document").([]interface{})),
+	}
 
 	if v, ok := d.GetOk("error_document"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
 		websiteConfig.ErrorDocument = expandBucketWebsiteConfigurationErrorDocument(v.([]interface{}))
 	}
 
-	if v, ok := d.GetOk("index_document"); ok && len(v.([]interface{})) > 0 && v.([]interface{})[0] != nil {
-		websiteConfig.IndexDocument = expandBucketWebsiteConfigurationIndexDocument(v.([]interface{}))
-	}
-
 	input := &s3.PutBucketWebsiteInput{
 		Bucket:               aws.String(bucket),
 		WebsiteConfiguration: websiteConfig,