fix lint

fix error

fix doc

fix tf lint

fix lint

fix lint

fix lint

fix lint

fix lint

cleanup: remove commented helpers

Author: jremy42

docs/resources/domain_domains_registration.md

@@ -107,6 +107,8 @@ The following arguments are supported:
 
 ## Attributes Reference
 
+In addition to all arguments above, the following attributes are exported:
+
 - `id`: The ID of the domain registration.
 - `updated_at`: Timestamp of the last update.
 - `expired_at`: Expiration date/time of the domain registration.

internal/services/domain/domains_registration.go

@@ -417,10 +417,12 @@ func resourceDomainsRegistrationCreate(ctx context.Context, d *schema.ResourceDa
 	registrarAPI := NewRegistrarDomainAPI(m)
 
 	projectID := d.Get("project_id").(string)
+
 	domainNames := make([]string, 0)
 	for _, v := range d.Get("domain_names").([]interface{}) {
 		domainNames = append(domainNames, v.(string))
 	}
+
 	durationInYears := uint32(d.Get("duration_in_years").(int))
 
 	buyDomainsRequest := &domain.RegistrarAPIBuyDomainsRequest{
@@ -430,6 +432,7 @@ func resourceDomainsRegistrationCreate(ctx context.Context, d *schema.ResourceDa
 	}
 
 	ownerContactID := d.Get("owner_contact_id").(string)
+
 	if ownerContactID != "" {
 		buyDomainsRequest.OwnerContactID = &ownerContactID
 	} else if ownerContacts, ok := d.GetOk("owner_contact"); ok {
@@ -469,20 +472,25 @@ func resourceDomainsRegistrationsRead(ctx context.Context, d *schema.ResourceDat
 	if err != nil {
 		return diag.FromErr(err)
 	}
+
 	if len(domainNames) == 0 {
 		d.SetId("")
+
 		return nil
 	}
 
 	firstDomain := domainNames[0]
+
 	firstResp, err := registrarAPI.GetDomain(&domain.RegistrarAPIGetDomainRequest{
 		Domain: firstDomain,
 	}, scw.WithContext(ctx))
 	if err != nil {
 		if httperrors.Is404(err) {
 			d.SetId("")
+
 			return nil
 		}
+
 		return diag.FromErr(err)
 	}
 
@@ -501,7 +509,6 @@ func resourceDomainsRegistrationsRead(ctx context.Context, d *schema.ResourceDat
 	}
 
 	computedDnssec := false
-
 	if firstResp.Dnssec.Status == domain.DomainFeatureStatusEnabled {
 		computedDnssec = true
 	}
@@ -536,17 +543,16 @@ func resourceDomainsRegistrationUpdate(ctx context.Context, d *schema.ResourceDa
 	if err != nil {
 		return diag.FromErr(err)
 	}
+
 	if len(domainNames) == 0 {
 		d.SetId("")
-		return nil
-	}
 
-	if d.HasChange("owner_contact_id") || d.HasChange("owner_contact") {
-		return diag.FromErr(fmt.Errorf("the domain ownership transfer feature is not implemented in this provider because it requires manual validation through email notifications. This action can only be performed via the Scaleway Console"))
+		return nil
 	}
 
 	if d.HasChange("auto_renew") {
 		newAutoRenew := d.Get("auto_renew").(bool)
+
 		for _, domainName := range domainNames {
 			domainResp, err := registrarAPI.GetDomain(&domain.RegistrarAPIGetDomainRequest{
 				Domain: domainName,
@@ -556,7 +562,8 @@ func resourceDomainsRegistrationUpdate(ctx context.Context, d *schema.ResourceDa
 			}
 
 			if newAutoRenew {
-				if domainResp.AutoRenewStatus != domain.DomainFeatureStatusEnabled && domainResp.AutoRenewStatus != domain.DomainFeatureStatusEnabling {
+				if domainResp.AutoRenewStatus != domain.DomainFeatureStatusEnabled &&
+					domainResp.AutoRenewStatus != domain.DomainFeatureStatusEnabling {
 					_, err = registrarAPI.EnableDomainAutoRenew(&domain.RegistrarAPIEnableDomainAutoRenewRequest{
 						Domain: domainName,
 					}, scw.WithContext(ctx))
@@ -565,7 +572,8 @@ func resourceDomainsRegistrationUpdate(ctx context.Context, d *schema.ResourceDa
 					}
 				}
 			} else {
-				if domainResp.AutoRenewStatus == domain.DomainFeatureStatusEnabled || domainResp.AutoRenewStatus == domain.DomainFeatureStatusEnabling {
+				if domainResp.AutoRenewStatus == domain.DomainFeatureStatusEnabled ||
+					domainResp.AutoRenewStatus == domain.DomainFeatureStatusEnabling {
 					_, err = registrarAPI.DisableDomainAutoRenew(&domain.RegistrarAPIDisableDomainAutoRenewRequest{
 						Domain: domainName,
 					}, scw.WithContext(ctx))
@@ -574,6 +582,7 @@ func resourceDomainsRegistrationUpdate(ctx context.Context, d *schema.ResourceDa
 					}
 				}
 			}
+
 			_, err = waitForAutoRenewStatus(ctx, registrarAPI, domainName, d.Timeout(schema.TimeoutUpdate))
 			if err != nil {
 				return diag.FromErr(err)
@@ -583,6 +592,7 @@ func resourceDomainsRegistrationUpdate(ctx context.Context, d *schema.ResourceDa
 
 	if d.HasChange("dnssec") {
 		newDnssec := d.Get("dnssec").(bool)
+
 		for _, domainName := range domainNames {
 			domainResp, err := registrarAPI.GetDomain(&domain.RegistrarAPIGetDomainRequest{
 				Domain: domainName,
@@ -593,27 +603,31 @@ func resourceDomainsRegistrationUpdate(ctx context.Context, d *schema.ResourceDa
 
 			if newDnssec {
 				var dsRecord *domain.DSRecord
+
 				if v, ok := d.GetOk("ds_record"); ok {
 					dsRecordList := v.([]interface{})
 					if len(dsRecordList) > 0 && dsRecordList[0] != nil {
 						dsRecord = ExpandDSRecord(dsRecordList)
 					}
 				}
+
 				_, err = registrarAPI.EnableDomainDNSSEC(&domain.RegistrarAPIEnableDomainDNSSECRequest{
 					Domain:   domainName,
 					DsRecord: dsRecord,
 				}, scw.WithContext(ctx))
 				if err != nil {
 					return diag.FromErr(fmt.Errorf("failed to enable dnssec for %s: %w", domainName, err))
 				}
-			} else if domainResp.Dnssec != nil && domainResp.Dnssec.Status == domain.DomainFeatureStatusEnabled {
+			} else if domainResp.Dnssec != nil &&
+				domainResp.Dnssec.Status == domain.DomainFeatureStatusEnabled {
 				_, err = registrarAPI.DisableDomainDNSSEC(&domain.RegistrarAPIDisableDomainDNSSECRequest{
 					Domain: domainName,
 				}, scw.WithContext(ctx))
 				if err != nil {
 					return diag.FromErr(fmt.Errorf("failed to disable dnssec for %s: %w", domainName, err))
 				}
 			}
+
 			_, err = waitForDNSSECStatus(ctx, registrarAPI, domainName, d.Timeout(schema.TimeoutUpdate))
 			if err != nil {
 				return diag.FromErr(err)
@@ -641,6 +655,7 @@ func resourceDomainsRegistrationDelete(ctx context.Context, d *schema.ResourceDa
 			if httperrors.Is404(err) {
 				continue
 			}
+
 			return diag.FromErr(fmt.Errorf("failed to get domain details for %s: %w", domainName, err))
 		}
 

internal/services/domain/domains_registration_test.go

@@ -1,6 +1,7 @@
 package domain_test
 
 import (
+	"context"
 	"fmt"
 	"testing"
 
@@ -16,7 +17,7 @@ func TestAccDomainRegistration_SingleDomainWithUpdate(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
-	singleDomain := "test-single-updates34" + ".com" // à adapter
+	singleDomain := "test-single-updates35" + ".com"
 
 	resource.ParallelTest(t, resource.TestCase{
 		PreCheck:          func() { acctest.PreCheck(t) },
@@ -168,7 +169,8 @@ func testAccCheckDomainStatus(tt *acctest.TestTools, expectedAutoRenew, expected
 			}
 
 			registrarAPI := domain.NewRegistrarDomainAPI(tt.Meta)
-			domainNames, err := domain.ExtractDomainsFromTaskID(nil, rs.Primary.ID, registrarAPI)
+
+			domainNames, err := domain.ExtractDomainsFromTaskID(context.TODO(), rs.Primary.ID, registrarAPI)
 			if err != nil {
 				return fmt.Errorf("error extracting domains: %w", err)
 			}
@@ -177,18 +179,21 @@ func testAccCheckDomainStatus(tt *acctest.TestTools, expectedAutoRenew, expected
 				domainResp, getErr := registrarAPI.GetDomain(&domainSDK.RegistrarAPIGetDomainRequest{
 					Domain: domainName,
 				})
+
 				if getErr != nil {
 					return fmt.Errorf("failed to get details for domain %s: %w", domainName, getErr)
 				}
 
 				if domainResp.AutoRenewStatus.String() != expectedAutoRenew {
 					return fmt.Errorf("domain %s has auto_renew status %s, expected %s", domainName, domainResp.AutoRenewStatus, expectedAutoRenew)
 				}
+
 				if domainResp.Dnssec.Status.String() != expectedDNSSEC {
 					return fmt.Errorf("domain %s has dnssec status %s, expected %s", domainName, domainResp.Dnssec.Status.String(), expectedDNSSEC)
 				}
 			}
 		}
+
 		return nil
 	}
 }
@@ -202,9 +207,9 @@ func testAccCheckDomainDestroy(tt *acctest.TestTools) resource.TestCheckFunc {
 
 			registrarAPI := domain.NewRegistrarDomainAPI(tt.Meta)
 
-			domainNames, err := domain.ExtractDomainsFromTaskID(nil, rs.Primary.ID, registrarAPI)
+			domainNames, err := domain.ExtractDomainsFromTaskID(context.TODO(), rs.Primary.ID, registrarAPI)
 			if err != nil {
-				return nil
+				return err
 			}
 
 			for _, domainName := range domainNames {
@@ -215,6 +220,7 @@ func testAccCheckDomainDestroy(tt *acctest.TestTools) resource.TestCheckFunc {
 					if httperrors.Is404(getErr) {
 						continue
 					}
+
 					return fmt.Errorf("failed to get domain details for %s: %w", domainName, getErr)
 				}
 
@@ -227,6 +233,7 @@ func testAccCheckDomainDestroy(tt *acctest.TestTools) resource.TestCheckFunc {
 				}
 			}
 		}
+
 		return nil
 	}
 }