wip

Author: Gnoale

internal/services/jobs/definition.go

@@ -111,7 +111,7 @@ func ResourceDefinition() *schema.Resource {
 						"secret_version": {
 							Type:        schema.TypeString,
 							Description: "The secret version, default to Latest.",
-							Optional:    true,
+							Required:    true,
 						},
 						"file": {
 							Type:         schema.TypeString,

internal/services/jobs/definition_test.go

@@ -161,7 +161,7 @@ func TestAccJobDefinition_Cron(t *testing.T) {
 	})
 }
 
-func TestAccCreateJobDefinitionWithSecretReference(t *testing.T) {
+func TestAccCreateJobDefinition_SecretReference(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 	resource.ParallelTest(t, resource.TestCase{
@@ -255,7 +255,7 @@ func TestAccCreateJobDefinitionWithSecretReference(t *testing.T) {
 	})
 }
 
-func TestAccCreateJobDefinitionWrongSecretReference(t *testing.T) {
+func TestAccCreateJobDefinition_WrongSecretReference(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -285,6 +285,7 @@ func TestAccCreateJobDefinitionWrongSecretReference(t *testing.T) {
 						image_uri = "docker.io/alpine:latest"
 						secret_reference {
 							secret_id = local.secret_uuid
+							secret_version = "1"
 						}
 					}
 				`,

internal/services/jobs/helpers.go

@@ -139,26 +139,21 @@ func CreateJobDefinitionSecret(rawSecretReference any, api *jobs.API, region scw
 	secrets := []*jobs.CreateJobDefinitionSecretsRequestSecretConfig{}
 
 	for _, parsedSecretRef := range parsedSecretReferences {
-		secretVersion := "Latest"
-
-		if parsedSecretRef.SecretVersion != "" {
-			secretVersion = parsedSecretRef.SecretVersion
-		}
 
 		var secretConfig *jobs.CreateJobDefinitionSecretsRequestSecretConfig
 
 		if parsedSecretRef.Environment != "" {
 			secretConfig = &jobs.CreateJobDefinitionSecretsRequestSecretConfig{
 				SecretManagerID:      parsedSecretRef.SecretID,
-				SecretManagerVersion: secretVersion,
+				SecretManagerVersion: parsedSecretRef.SecretVersion,
 				EnvVarName:           &parsedSecretRef.Environment,
 			}
 		}
 
 		if parsedSecretRef.File != "" {
 			secretConfig = &jobs.CreateJobDefinitionSecretsRequestSecretConfig{
 				SecretManagerID:      parsedSecretRef.SecretID,
-				SecretManagerVersion: secretVersion,
+				SecretManagerVersion: parsedSecretRef.SecretVersion,
 				Path:                 &parsedSecretRef.File,
 			}
 		}