Merge branch 'master' into fix_warning_golang

Author: remyleone

.github/workflows/documentation.yml

@@ -65,3 +65,4 @@ jobs:
           go-version: ${{ env.GO_VERSION }}
       - uses: hashicorp/setup-terraform@v3
       - run: go tool tfplugindocs validate
+      - run: go tool tfplugindocs generate

.github/workflows/tfproviderlint.yml

@@ -21,6 +21,8 @@ jobs:
         run: go install github.com/bflad/tfproviderlint/cmd/tfproviderlint
       - name: Run tfproviderlint
         run: make tfproviderlint
+      - name: Run tfproviderlintx
+        run: make tfproviderlintx
   tfproviderdocs:
     runs-on: ubuntu-latest
     steps:

GNUmakefile

@@ -60,3 +60,6 @@ tfproviderlint:
 
 tfproviderdocs:
 	go tool tfproviderdocs check -provider-name scaleway -enable-contents-check
+
+tfproviderlintx:
+	go tool tfproviderlintx -XR001=false -XS002=false ./...

docs/resources/instance_server.md

@@ -295,8 +295,13 @@ In addition to all arguments above, the following attributes are exported:
 - `private_ip` - The Scaleway internal IP address of the server (Deprecated use [ipam_ip datasource](../data-sources/ipam_ip.md#instance-private-network-ip) instead).
 - `public_ip` -  The public IP address of the server (Deprecated use `public_ips` instead).
 - `public_ips` - The list of public IPs of the server.
-    - `id` - The ID of the IP
-    - `address` - The address of the IP
+    - `id` - The ID of the IP.
+    - `address` - The address of the IP.
+    - `gateway` - The IP of the Gateway associated with the IP.
+    - `netmask` - The CIDR netmask of the IP.
+    - `family` - The IP address' family.
+    - `dynamic` - Whether the IP is dynamic.
+    - `provisioning_mode` - The provisioning mode of the IP
 - `ipv6_address` - The default ipv6 address routed to the server. ( Only set when enable_ipv6 is set to true )
   Deprecated: Please use a scaleway_instance_ip with a `routed_ipv6` type.
 - `ipv6_gateway` - The ipv6 gateway address. ( Only set when enable_ipv6 is set to true )

go.mod

@@ -176,6 +176,7 @@ require (
 tool (
 	github.com/bflad/tfproviderdocs
 	github.com/bflad/tfproviderlint/cmd/tfproviderlint
+	github.com/bflad/tfproviderlint/cmd/tfproviderlintx
 	github.com/hashicorp/terraform-plugin-docs/cmd/tfplugindocs
 	github.com/katbyte/terrafmt
 )

internal/services/baremetal/server.go

@@ -185,8 +185,9 @@ If this behaviour is wanted, please set 'reinstall_on_ssh_key_changes' argument
 				Elem:        ResourceServerIP(),
 			},
 			"domain": {
-				Type:     schema.TypeString,
-				Computed: true,
+				Type:        schema.TypeString,
+				Description: "Domain associated with the server",
+				Computed:    true,
 			},
 			"options": {
 				Type:        schema.TypeSet,

internal/services/billing/consumption_data_source.go

@@ -20,8 +20,9 @@ func DataSourceConsumptions() *schema.Resource {
 			"organization_id": account.OrganizationIDSchema(),
 			"project_id":      account.ProjectIDSchema(),
 			"consumptions": {
-				Type:     schema.TypeList,
-				Computed: true,
+				Type:        schema.TypeList,
+				Description: "List of the consumptions.",
+				Computed:    true,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"value": {
@@ -63,8 +64,9 @@ func DataSourceConsumptions() *schema.Resource {
 				},
 			},
 			"updated_at": {
-				Computed: true,
-				Type:     schema.TypeString,
+				Computed:    true,
+				Description: "Date and time when the consumption was updated",
+				Type:        schema.TypeString,
 			},
 		},
 	}

internal/services/billing/invoices_data_source.go

@@ -34,8 +34,9 @@ func DataSourceInvoices() *schema.Resource {
 				Description: "The invoice type. It can either be `periodic` or `purchase`",
 			},
 			"invoices": {
-				Type:     schema.TypeList,
-				Computed: true,
+				Type:        schema.TypeList,
+				Description: "List of invoices",
+				Computed:    true,
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"id": {

internal/services/container/domain.go

@@ -26,7 +26,6 @@ func ResourceDomain() *schema.Resource {
 		Timeouts: &schema.ResourceTimeout{
 			Create:  schema.DefaultTimeout(defaultContainerDomainTimeout),
 			Read:    schema.DefaultTimeout(defaultContainerDomainTimeout),
-			Update:  schema.DefaultTimeout(defaultContainerDomainTimeout),
 			Delete:  schema.DefaultTimeout(defaultContainerDomainTimeout),
 			Default: schema.DefaultTimeout(defaultContainerDomainTimeout),
 		},

internal/services/container/token.go

@@ -28,34 +28,39 @@ func ResourceToken() *schema.Resource {
 		Schema: map[string]*schema.Schema{
 			"container_id": {
 				Type:             schema.TypeString,
+				Description:      "Container ID",
 				ForceNew:         true,
 				Optional:         true,
 				ExactlyOneOf:     []string{"namespace_id"},
 				DiffSuppressFunc: dsf.Locality,
 			},
 			"namespace_id": {
 				Type:             schema.TypeString,
+				Description:      "Namespace ID",
 				ForceNew:         true,
 				Optional:         true,
 				ExactlyOneOf:     []string{"container_id"},
 				DiffSuppressFunc: dsf.Locality,
 			},
 			"description": {
-				Type:     schema.TypeString,
-				Optional: true,
-				ForceNew: true,
+				Type:        schema.TypeString,
+				Description: "Description of the token.",
+				Optional:    true,
+				ForceNew:    true,
 			},
 			"expires_at": {
 				Type:             schema.TypeString,
+				Description:      "Expiration date of the token (TimeRFC3339)",
 				Optional:         true,
 				ForceNew:         true,
 				ValidateDiagFunc: verify.IsDate(),
 				DiffSuppressFunc: dsf.TimeRFC3339,
 			},
 			"token": {
-				Type:      schema.TypeString,
-				Computed:  true,
-				Sensitive: true,
+				Type:        schema.TypeString,
+				Description: "Token",
+				Computed:    true,
+				Sensitive:   true,
 			},
 
 			"region": regional.Schema(),