fix(rdb): read replica: fix default value in doc (#2313)

* fix(rdb): read replica: fix default value for `same_zone`

* test(rdb): read replica: test default value for `same_zone`

Author: Mia-Cross

docs/resources/rdb_read_replica.md

@@ -70,9 +70,9 @@ The following arguments are supported:
       CIDR notation. The IP network address within the private subnet is determined by the IP Address Management (IPAM)
       service if not set.
 
-- `same_zone` - (Defaults to `false`) Defines whether to create the replica in the same availability zone as the main instance nodes or not.
+- `same_zone` - (Defaults to `true`) Defines whether to create the replica in the same availability zone as the main instance nodes or not.
 
-- `region` - (Defaults to [provider](../index.md#region) `region`) The [region](../guides/regions_and_zones.md#regions)
+- `region` - (Defaults to [provider](../index.md#arguments-reference) `region`) The [region](../guides/regions_and_zones.md#regions)
   in which the Database read replica should be created.
 
 ## Attributes Reference

scaleway/resource_rdb_read_replica_test.go

@@ -260,7 +260,6 @@ func TestAccScalewayRdbReadReplica_DifferentZone(t *testing.T) {
 					resource "scaleway_rdb_read_replica" "different_zone" {
   						instance_id = scaleway_rdb_instance.different_zone.id
 						region = scaleway_rdb_instance.different_zone.region
-						same_zone = false
 						private_network {
 							private_network_id = scaleway_vpc_private_network.different_zone.id
 						}
@@ -269,7 +268,7 @@ func TestAccScalewayRdbReadReplica_DifferentZone(t *testing.T) {
 					testAccCheckRdbReadReplicaExists(tt, "scaleway_rdb_read_replica.different_zone"),
 					testAccCheckScalewayVPCPrivateNetworkExists(tt, "scaleway_vpc_private_network.different_zone"),
 					resource.TestCheckResourceAttrPair("scaleway_rdb_read_replica.different_zone", "instance_id", "scaleway_rdb_instance.different_zone", "id"),
-					resource.TestCheckResourceAttr("scaleway_rdb_read_replica.different_zone", "same_zone", "false"),
+					resource.TestCheckResourceAttr("scaleway_rdb_read_replica.different_zone", "same_zone", "true"),
 					testAccCheckScalewayResourceIDPersisted("scaleway_rdb_read_replica.different_zone", &readReplicaID),
 				),
 			},
@@ -303,6 +302,39 @@ func TestAccScalewayRdbReadReplica_DifferentZone(t *testing.T) {
 					testAccCheckScalewayVPCPrivateNetworkExists(tt, "scaleway_vpc_private_network.different_zone"),
 					resource.TestCheckResourceAttrPair("scaleway_rdb_read_replica.different_zone", "instance_id", "scaleway_rdb_instance.different_zone", "id"),
 					resource.TestCheckResourceAttr("scaleway_rdb_read_replica.different_zone", "same_zone", "true"),
+					testAccCheckScalewayResourceIDPersisted("scaleway_rdb_read_replica.different_zone", &readReplicaID),
+				),
+			},
+			{
+				Config: `
+					resource "scaleway_vpc_private_network" "different_zone" {
+						name = "test-rdb-rr-different-zone"
+					}
+
+					resource "scaleway_rdb_instance" "different_zone" {
+						name = "test-rdb-rr-different-zone"
+						node_type = "db-dev-s"
+						engine = "PostgreSQL-14"
+						is_ha_cluster = false
+						disable_backup = true
+						user_name = "my_initial_user"
+						password = "thiZ_is_v&ry_s3cret"
+						tags = [ "terraform-test", "scaleway_rdb_read_replica", "different-zone" ]
+					}
+
+					resource "scaleway_rdb_read_replica" "different_zone" {
+  						instance_id = scaleway_rdb_instance.different_zone.id
+						region = scaleway_rdb_instance.different_zone.region
+						same_zone = false
+						private_network {
+							private_network_id = scaleway_vpc_private_network.different_zone.id
+						}
+					}`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckRdbReadReplicaExists(tt, "scaleway_rdb_read_replica.different_zone"),
+					testAccCheckScalewayVPCPrivateNetworkExists(tt, "scaleway_vpc_private_network.different_zone"),
+					resource.TestCheckResourceAttrPair("scaleway_rdb_read_replica.different_zone", "instance_id", "scaleway_rdb_instance.different_zone", "id"),
+					resource.TestCheckResourceAttr("scaleway_rdb_read_replica.different_zone", "same_zone", "false"),
 					testAccCheckScalewayResourceIDChanged("scaleway_rdb_read_replica.different_zone", &readReplicaID),
 				),
 			},