feat(cockpit): required for retention_days

Author: jremy42

internal/services/cockpit/cockpit_data_source_test.go

@@ -25,18 +25,21 @@ func TestAccDataSourceCockpit_Basic(t *testing.T) {
 						project_id = scaleway_account_project.project.id
 						name       = "my-data-source-metrics"
 						type       = "metrics"
+						retention_days = 31
 					}
 					
 					resource "scaleway_cockpit_source" "logs" {
 						project_id = scaleway_account_project.project.id
 						name       = "my-data-source-logs"
 						type       = "logs"
+						retention_days = 7
 					}
 					
 					resource "scaleway_cockpit_source" "traces" {
 						project_id = scaleway_account_project.project.id
 						name       = "my-data-source-traces"
 						type       = "traces"
+						retention_days = 7
 					}
 					
 					resource "scaleway_cockpit_alert_manager" "alert_manager" {

internal/services/cockpit/source.go

@@ -45,8 +45,7 @@ func ResourceCockpitSource() *schema.Resource {
 			},
 			"retention_days": {
 				Type:        schema.TypeInt,
-				Optional:    true,
-				Default:     6,
+				Required:    true,
 				Description: "The number of days to retain data, must be between 1 and 365.",
 			},
 			// computed
@@ -93,10 +92,6 @@ func ResourceCockpitSourceCreate(ctx context.Context, d *schema.ResourceData, me
 	}
 
 	retentionDays := uint32(d.Get("retention_days").(int))
-	if retentionDays == 0 {
-		retentionDays = 6
-	}
-
 	res, err := api.CreateDataSource(&cockpit.RegionalAPICreateDataSourceRequest{
 		Region:        region,
 		ProjectID:     d.Get("project_id").(string),

internal/services/cockpit/source_test.go

@@ -31,14 +31,15 @@ func TestAccCockpitSource_Basic_metrics(t *testing.T) {
 					  project_id = scaleway_account_project.project.id
 					  name       = "my-source"
 					  type       = "metrics"
+					  retention_days      = 31
 					}
 				`,
 				Check: resource.ComposeTestCheckFunc(
 					isSourcePresent(tt, "scaleway_cockpit_source.main"),
 					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "name", "my-source"),
 					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "type", "metrics"),
 					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "region", "fr-par"),
-					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "retention_days", "6"),
+					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "retention_days", "31"),
 					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "url"),
 					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "push_url"),
 					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "origin"),
@@ -71,6 +72,8 @@ func TestAccCockpitSource_Basic_logs(t *testing.T) {
 					  project_id = scaleway_account_project.project.id
 					  name       = "my-source"
 					  type       = "logs"
+					  retention_days  = 31
+
 					}
 				`,
 				Check: resource.ComposeTestCheckFunc(