fix(lb): ignore order changes on certificate ids (#2439)

* fix(lb): ignore order changes on certificate ids

* fix

Author: yfodil

scaleway/helpers.go

@@ -7,6 +7,8 @@ import (
 	"fmt"
 	"net"
 	"net/http"
+	"reflect"
+	"sort"
 	"strconv"
 	"strings"
 	"testing"
@@ -762,6 +764,39 @@ func diffSuppressFuncLocality(_, oldValue, newValue string, _ *schema.ResourceDa
 	return expandID(oldValue) == expandID(newValue)
 }
 
+// diffSuppressFuncOrderDiff suppresses diffs for TypeList attributes when the only change is the order of elements.
+// https://github.com/hashicorp/terraform-plugin-sdk/issues/477#issuecomment-1238807249
+func diffSuppressFuncOrderDiff(k, _, _ string, d *schema.ResourceData) bool {
+	// Extract the base key path to the list attribute, ignoring the index and value parts
+	lastDotIndex := strings.LastIndex(k, ".")
+	baseKey := k
+	if lastDotIndex != -1 {
+		baseKey = k[:lastDotIndex]
+	}
+
+	oldList, newList := d.GetChange(baseKey)
+	if oldList == nil || newList == nil {
+		return false
+	}
+
+	oldListSlice, newListSlice := oldList.([]interface{}), newList.([]interface{})
+	if len(oldListSlice) != len(newListSlice) {
+		return false // Different lengths means there's definitely a change
+	}
+
+	oldListStr, newListStr := make([]string, len(oldListSlice)), make([]string, len(newListSlice))
+	for i, oldItem := range oldListSlice {
+		oldListStr[i] = fmt.Sprint(oldItem)
+	}
+	for j, newItem := range newListSlice {
+		newListStr[j] = fmt.Sprint(newItem)
+	}
+	sort.Strings(oldListStr)
+	sort.Strings(newListStr)
+
+	return reflect.DeepEqual(oldListStr, newListStr)
+}
+
 // TimedOut returns true if the error represents a "wait timed out" condition.
 // Specifically, TimedOut returns true if the error matches all these conditions:
 //   - err is of type resource.TimeoutError

scaleway/resource_lb_frontend.go

@@ -79,7 +79,8 @@ func resourceScalewayLbFrontend() *schema.Resource {
 					Type:         schema.TypeString,
 					ValidateFunc: validationUUIDorUUIDWithLocality(),
 				},
-				Description: "Collection of Certificate IDs related to the load balancer and domain",
+				Description:      "Collection of Certificate IDs related to the load balancer and domain",
+				DiffSuppressFunc: diffSuppressFuncOrderDiff,
 			},
 			"acl": {
 				Type:        schema.TypeList,