feat(mongodb): fix lint

Author: jremy42

internal/services/mongodb/data_source_instance.go

@@ -15,7 +15,6 @@ import (
 )
 
 func DataSourceInstance() *schema.Resource {
-
 	dsSchema := datasource.SchemaFromResourceSchema(ResourceInstance().Schema)
 
 	datasource.AddOptionalFieldsToSchema(dsSchema, "name", "region", "project_id")

internal/services/mongodb/instance_test.go

@@ -176,8 +176,10 @@ func IsInstanceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc {
 			if err != nil {
 				return err
 			}
-
 			extractRegion, err := zone.Region()
+			if err != nil {
+				return err
+			}
 			instance, err := mongodbAPI.GetInstance(&mongodbSDK.GetInstanceRequest{
 				InstanceID: ID,
 				Region:     extractRegion,

internal/services/mongodb/snapshot.go

@@ -125,6 +125,9 @@ func ResourceSnapshotRead(ctx context.Context, d *schema.ResourceData, m interfa
 		return diag.FromErr(err)
 	}
 	zone, snapshotID, err := zonal.ParseID(d.Id())
+	if err != nil {
+		return diag.FromErr(err)
+	}
 
 	instanceID := locality.ExpandID(d.Get("instance_id").(string))
 	snapshot, err := waitForSnapshot(ctx, mongodbAPI, region, instanceID, snapshotID, d.Timeout(schema.TimeoutCreate))
@@ -152,6 +155,9 @@ func ResourceSnapshotUpdate(ctx context.Context, d *schema.ResourceData, m inter
 		return diag.FromErr(err)
 	}
 	_, snapshotID, err := zonal.ParseID(d.Id())
+	if err != nil {
+		return diag.FromErr(err)
+	}
 
 	updateReq := &mongodb.UpdateSnapshotRequest{
 		SnapshotID: snapshotID,
@@ -181,12 +187,15 @@ func ResourceSnapshotUpdate(ctx context.Context, d *schema.ResourceData, m inter
 	return ResourceSnapshotRead(ctx, d, m)
 }
 
-func ResourceSnapshotDelete(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
+func ResourceSnapshotDelete(_ context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {
 	mongodbAPI, region, err := newAPIWithRegion(d, m)
 	if err != nil {
 		return diag.FromErr(err)
 	}
 	_, snapshotID, err := zonal.ParseID(d.Id())
+	if err != nil {
+		return diag.FromErr(err)
+	}
 
 	deleteReq := &mongodb.DeleteSnapshotRequest{
 		SnapshotID: snapshotID,

internal/services/mongodb/testfuncs/sweep.go

@@ -22,6 +22,9 @@ func testSweepMongodbInstance(_ string) error {
 		mongodbAPI := mongodb.NewAPI(scwClient)
 		logging.L.Debugf("sweeper: destroying the mongodb instance in (%s)", zone)
 		extractRegion, err := zone.Region()
+		if err != nil {
+			return fmt.Errorf("error extract region in (%s) in sweeper: %w", zone, err)
+		}
 		listInstance, err := mongodbAPI.ListInstances(&mongodb.ListInstancesRequest{
 			Region: extractRegion,
 		})