chore: fix contextcheck linter (#1286)

Co-authored-by: jaime Bernabe <[email protected]>

Author: remyleone

.golangci.yml

@@ -7,6 +7,7 @@ linters:
     - bidichk # Checks for dangerous unicode character sequences [fast: true, auto-fix: false]
     - bodyclose # checks whether HTTP response body is closed successfully [fast: false, auto-fix: false]
     - containedctx # containedctx is a linter that detects struct contained context.Context field [fast: true, auto-fix: false]
+    - contextcheck # check the function whether use a non-inherited context [fast: false, auto-fix: false]
     - deadcode # Finds unused code [fast: false, auto-fix: false]
     - decorder # check declaration order and count of types, constants, variables and functions [fast: true, auto-fix: false]
     - depguard # Go linter that checks if package imports are in a list of acceptable packages [fast: true, auto-fix: false]
@@ -61,7 +62,6 @@ linters:
     - whitespace # Tool for detection of leading and trailing whitespace [fast: true, auto-fix: true]
 
   disable:
-    - contextcheck # check the function whether use a non-inherited context [fast: false, auto-fix: false]
     - cyclop # checks function and package cyclomatic complexity [fast: false, auto-fix: false]
     - dupl # Tool for code clone detection [fast: true, auto-fix: false]
     - errorlint # errorlint is a linter for that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13. [fast: false, auto-fix: false]

scaleway/resource_rdb_database.go

@@ -97,7 +97,7 @@ func resourceScalewayRdbDatabaseCreate(ctx context.Context, d *schema.ResourceDa
 
 	var db *rdb.Database
 	//  wrapper around StateChangeConf that will just retry the database creation
-	err = resource.RetryContext(context.Background(), createDatabaseTimeout, func() *resource.RetryError {
+	err = resource.RetryContext(ctx, createDatabaseTimeout, func() *resource.RetryError {
 		currentDB, errCreateDB := rdbAPI.CreateDatabase(createReq, scw.WithContext(ctx))
 		if errCreateDB != nil {
 			// WIP: Issue on creation/write database. Need a database stable status

scaleway/retryable_transport.go

@@ -21,11 +21,11 @@ func newRetryableTransport(defaultTransport http.RoundTripper) http.RoundTripper
 	c.RetryWaitMax = 2 * time.Minute
 	c.Logger = l
 	c.RetryWaitMin = time.Second * 2
-	c.CheckRetry = func(_ context.Context, resp *http.Response, err error) (bool, error) {
+	c.CheckRetry = func(ctx context.Context, resp *http.Response, err error) (bool, error) {
 		if resp == nil || resp.StatusCode == http.StatusTooManyRequests {
 			return true, err
 		}
-		return retryablehttp.DefaultRetryPolicy(context.TODO(), resp, err)
+		return retryablehttp.DefaultRetryPolicy(ctx, resp, err)
 	}
 
 	return &retryableTransport{c}