linter

Author: Mia-Cross

internal/services/instance/server.go

@@ -5,8 +5,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	ipamAPI "github.com/scaleway/scaleway-sdk-go/api/ipam/v1"
-	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/ipam"
 	"io"
 	"log"
 	"strconv"
@@ -21,6 +19,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	block "github.com/scaleway/scaleway-sdk-go/api/block/v1alpha1"
 	instanceSDK "github.com/scaleway/scaleway-sdk-go/api/instance/v1"
+	ipamAPI "github.com/scaleway/scaleway-sdk-go/api/ipam/v1"
 	"github.com/scaleway/scaleway-sdk-go/api/marketplace/v2"
 	"github.com/scaleway/scaleway-sdk-go/scw"
 	scwvalidation "github.com/scaleway/scaleway-sdk-go/validation"
@@ -33,6 +32,7 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/meta"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/account"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/instance/instancehelpers"
+	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/ipam"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/vpc"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/types"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/verify"
@@ -794,30 +794,35 @@ func ResourceInstanceServerRead(ctx context.Context, d *schema.ResourceData, m i
 		return diag.FromErr(err)
 	}
 
-	var privateNICIDs []string
+	privateNICIDs := []string(nil)
 	for _, nic := range ph.privateNICsMap {
 		privateNICIDs = append(privateNICIDs, nic.ID)
 	}
 
-	var allPrivateIPs []map[string]interface{}
+	allPrivateIPs := []map[string]interface{}(nil)
 	resourceType := ipamAPI.ResourceTypeInstancePrivateNic
+
 	region, err := zone.Region()
 	if err != nil {
 		return diag.FromErr(err)
 	}
+
 	for _, nicID := range privateNICIDs {
 		opts := &ipam.GetResourcePrivateIPsOptions{
 			ResourceType: &resourceType,
 			ResourceID:   &nicID,
 		}
+
 		privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
 		if err != nil {
 			return diag.FromErr(err)
 		}
+
 		if privateIPs != nil {
 			allPrivateIPs = append(allPrivateIPs, privateIPs...)
 		}
 	}
+
 	_ = d.Set("private_ips", allPrivateIPs)
 
 	////

internal/services/ipam/helpers.go

@@ -87,12 +87,15 @@ func GetResourcePrivateIPs(ctx context.Context, m interface{}, region scw.Region
 		if opts.PrivateNetworkID != nil {
 			req.PrivateNetworkID = opts.PrivateNetworkID
 		}
+
 		if opts.ResourceID != nil {
 			req.ResourceID = opts.ResourceID
 		}
+
 		if opts.ResourceName != nil {
 			req.ResourceName = opts.ResourceName
 		}
+
 		if opts.ResourceType != nil {
 			req.ResourceType = *opts.ResourceType
 		}
@@ -108,15 +111,18 @@ func GetResourcePrivateIPs(ctx context.Context, m interface{}, region scw.Region
 	}
 
 	ipList := make([]map[string]interface{}, 0, len(resp.IPs))
+
 	for _, ip := range resp.IPs {
 		ipNet := ip.Address
 		if ipNet.IP == nil {
 			continue
 		}
+
 		ipMap := map[string]interface{}{
 			"id":      regional.NewIDString(region, ip.ID),
 			"address": ipNet.IP.String(),
 		}
+
 		ipList = append(ipList, ipMap)
 	}