Apply review suggestions

Author: remyleone

cmd/vcr-compressor/main.go

@@ -23,14 +23,14 @@ func main() {
 		log.Fatalf("Usage: %s <cassette_file_name_without_yaml>\n", os.Args[0])
 	}
 
-	chemin := os.Args[1]
+	path := os.Args[1]
 
-	inputCassette, err := cassette.Load(chemin)
+	inputCassette, err := cassette.Load(path)
 	if err != nil {
 		log.Fatalf("Error while reading file : %v\n", err)
 	}
 
-	outputCassette := cassette.New(chemin)
+	outputCassette := cassette.New(path)
 	transitioning := false
 
 	for i := range len(inputCassette.Interactions) {
@@ -71,29 +71,27 @@ func main() {
 			continue
 		}
 
-		if m["status"] != nil {
-			// We test if the state is transient
-			if _, ok := transientStates[m["status"].(string)]; ok {
-				if transitioning {
-					log.Printf("Interaction %d is in a transient state while we are already in transitient state. No need to record it: %s\n", i, m["status"])
+		// We test if the state is transient
+		if _, ok := transientStates[m["status"].(string)]; ok {
+			if transitioning {
+				log.Printf("Interaction %d is in a transient state while we are already in transitient state. No need to record it: %s\n", i, m["status"])
 
-					continue
-				} else {
-					transitioning = true
+				continue
+			} else {
+				transitioning = true
+
+				log.Printf("Interaction %d is in a transient state: %s, Recording it\n", i, m["status"])
+				outputCassette.AddInteraction(interaction)
+			}
+		} else {
+			if transitioning {
+				log.Printf("Interaction %d is not in a transient state anymore: %s, Recording it\n", i, m["status"])
+				outputCassette.AddInteraction(interaction)
 
-					log.Printf("Interaction %d is in a transient state: %s, Recording it\n", i, m["status"])
-					outputCassette.AddInteraction(interaction)
-				}
+				transitioning = false
 			} else {
-				if transitioning {
-					log.Printf("Interaction %d is not in a transient state anymore: %s, Recording it\n", i, m["status"])
-					outputCassette.AddInteraction(interaction)
-
-					transitioning = false
-				} else {
-					log.Printf("Interaction %d is not in a transient state: %s, Recording it\n", i, m["status"])
-					outputCassette.AddInteraction(interaction)
-				}
+				log.Printf("Interaction %d is not in a transient state: %s, Recording it\n", i, m["status"])
+				outputCassette.AddInteraction(interaction)
 			}
 		}
 	}

cmd/vcr-viewer/main.go

@@ -13,9 +13,9 @@ func main() {
 		log.Fatalf("Usage: %s <cassette_file_name_without_yaml>\n", os.Args[0])
 	}
 
-	chemin := os.Args[1]
+	path := os.Args[1]
 
-	data, err := cassette.Load(chemin)
+	data, err := cassette.Load(path)
 	if err != nil {
 		log.Fatalf("Error while reading file: %v\n", err)
 	}
@@ -46,7 +46,7 @@ func main() {
 
 		if m["status"] != nil {
 			log.Println("++++++++++++++++")
-			log.Printf("status: %s\n", m["status"]) // Modifie le champ "status" pour qu'il soit "ok"
+			log.Printf("status: %s\n", m["status"])
 			log.Println("++++++++++++++++")
 		}