updated wording + handle 403 on ipam

Author: Mia-Cross

docs/resources/redis_cluster.md

@@ -195,7 +195,7 @@ the form `{zone}/{id}`, e.g. `fr-par-1/11111111-1111-1111-1111-111111111111`
     - `endpoint_id` - The ID of the endpoint.
     - `zone` - The zone of the Private Network.
 
-- `private_ip` - The list of private IPv4 addresses associated with the resource.
+- `private_ips` - The list of private IPv4 addresses associated with the resource.
     - `id` - The ID of the IPv4 address resource.
     - `address` - The private IPv4 address.
 

internal/services/redis/cluster.go

@@ -7,6 +7,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -198,18 +199,18 @@ func ResourceCluster() *schema.Resource {
 			"private_ips": {
 				Type:        schema.TypeList,
 				Computed:    true,
-				Description: "List of private IP addresses associated with the resource",
+				Description: "List of private IPv4 addresses associated with the resource",
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"id": {
 							Type:        schema.TypeString,
 							Computed:    true,
-							Description: "The ID of the IP address resource",
+							Description: "The ID of the IPv4 address resource",
 						},
 						"address": {
 							Type:        schema.TypeString,
 							Computed:    true,
-							Description: "The private IP address",
+							Description: "The private IPv4 address",
 						},
 					},
 				},
@@ -365,7 +366,8 @@ func ResourceClusterRead(ctx context.Context, d *schema.ResourceData, m interfac
 	}
 
 	// set endpoints
-	var allPrivateIPs []map[string]interface{}
+	allPrivateIPs := []map[string]interface{}(nil)
+	diags := diag.Diagnostics{}
 
 	pnI, pnExists := flattenPrivateNetwork(cluster.Endpoints)
 	if pnExists {
@@ -395,7 +397,16 @@ func ResourceClusterRead(ctx context.Context, d *schema.ResourceData, m interfac
 
 			privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
 			if err != nil {
-				return diag.FromErr(err)
+				if !httperrors.Is403(err) {
+					return diag.FromErr(err)
+				}
+
+				diags = append(diags, diag.Diagnostic{
+					Severity:      diag.Warning,
+					Summary:       err.Error(),
+					Detail:        "Got 403 while reading private IP from IPAM API, please check your IAM permissions",
+					AttributePath: cty.GetAttrPath("private_ips"),
+				})
 			}
 
 			if privateIPs != nil {
@@ -426,7 +437,7 @@ func ResourceClusterRead(ctx context.Context, d *schema.ResourceData, m interfac
 		_ = d.Set("certificate", "")
 	}
 
-	return nil
+	return diags
 }
 
 func ResourceClusterUpdate(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagnostics {