Skip to content

Commit bf1391f

Browse files
committed
add early return in s3Encoder
1 parent 3cf8ee2 commit bf1391f

File tree

1 file changed

+17
-15
lines changed

1 file changed

+17
-15
lines changed

internal/acctest/acctest.go

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -52,24 +52,26 @@ func folderUsesVCRv4(fullFolderPath string) bool {
5252

5353
// s3Encoder encodes binary payloads as base64 because serialization changed on go-vcr.v4
5454
func s3Encoder(i *cassette.Interaction) error {
55-
if strings.HasSuffix(i.Request.Host, "scw.cloud") {
56-
if i.Request.Body != "" && i.Request.Headers.Get("Content-Type") == "application/octet-stream" {
57-
requestBody := []byte(i.Request.Body)
58-
if !json.Valid(requestBody) {
59-
err := xml.Unmarshal(requestBody, new(any))
60-
if err != nil {
61-
i.Request.Body = base64.StdEncoding.EncodeToString(requestBody)
62-
}
55+
if !strings.HasSuffix(i.Request.Host, "scw.cloud") {
56+
return nil
57+
}
58+
59+
if i.Request.Body != "" && i.Request.Headers.Get("Content-Type") == "application/octet-stream" {
60+
requestBody := []byte(i.Request.Body)
61+
if !json.Valid(requestBody) {
62+
err := xml.Unmarshal(requestBody, new(any))
63+
if err != nil {
64+
i.Request.Body = base64.StdEncoding.EncodeToString(requestBody)
6365
}
6466
}
67+
}
6568

66-
if i.Response.Body != "" && i.Response.Headers.Get("Content-Type") == "binary/octet-stream" {
67-
responseBody := []byte(i.Response.Body)
68-
if !json.Valid(responseBody) {
69-
err := xml.Unmarshal(responseBody, new(any))
70-
if err != nil {
71-
i.Response.Body = base64.StdEncoding.EncodeToString(responseBody)
72-
}
69+
if i.Response.Body != "" && i.Response.Headers.Get("Content-Type") == "binary/octet-stream" {
70+
responseBody := []byte(i.Response.Body)
71+
if !json.Valid(responseBody) {
72+
err := xml.Unmarshal(responseBody, new(any))
73+
if err != nil {
74+
i.Response.Body = base64.StdEncoding.EncodeToString(responseBody)
7375
}
7476
}
7577
}

0 commit comments

Comments
 (0)