add unit test for major minor func

Author: Mia-Cross

internal/services/k8s/k8s_version_data_source.go

@@ -4,13 +4,13 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"strings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/scaleway/scaleway-sdk-go/api/k8s/v1"
 	"github.com/scaleway/scaleway-sdk-go/scw"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/regional"
-	"golang.org/x/mod/semver"
 )
 
 func DataSourceVersion() *schema.Resource {
@@ -94,13 +94,27 @@ func DataSourceK8SVersionRead(ctx context.Context, d *schema.ResourceData, m any
 		version = res
 	}
 
+	majorMinor, err := VersionNameWithoutPatch(version.Name)
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
 	d.SetId(fmt.Sprintf("%s/%s", region, version.Name))
 	_ = d.Set("name", version.Name)
-	_ = d.Set("major_minor_only", semver.MajorMinor(version.Name))
+	_ = d.Set("major_minor_only", majorMinor)
 	_ = d.Set("available_cnis", version.AvailableCnis)
 	_ = d.Set("available_container_runtimes", version.AvailableContainerRuntimes)
 	_ = d.Set("available_feature_gates", version.AvailableFeatureGates)
 	_ = d.Set("region", region)
 
 	return nil
 }
+
+func VersionNameWithoutPatch(version string) (string, error) {
+	versionSplit := strings.Split(version, ".")
+	if len(versionSplit) != 3 {
+		return "", fmt.Errorf("version name must contain 3 parts, got %q", version)
+	}
+
+	return strings.Join(versionSplit[:2], "."), nil
+}

internal/services/k8s/k8s_version_data_source_test.go

@@ -6,9 +6,12 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hashicorp/terraform-plugin-testing/terraform"
-	"github.com/scaleway/scaleway-sdk-go/api/k8s/v1"
+	k8sSDK "github.com/scaleway/scaleway-sdk-go/api/k8s/v1"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/acctest"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/regional"
+	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/k8s"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 	"golang.org/x/mod/semver"
 )
 
@@ -125,9 +128,9 @@ func testAccCheckK8SVersionExists(tt *acctest.TestTools, n string) resource.Test
 			return err
 		}
 
-		k8sAPI := k8s.NewAPI(tt.Meta.ScwClient())
+		k8sAPI := k8sSDK.NewAPI(tt.Meta.ScwClient())
 
-		_, err = k8sAPI.GetVersion(&k8s.GetVersionRequest{
+		_, err = k8sAPI.GetVersion(&k8sSDK.GetVersionRequest{
 			Region:      region,
 			VersionName: name,
 		})
@@ -138,3 +141,35 @@ func testAccCheckK8SVersionExists(tt *acctest.TestTools, n string) resource.Test
 		return nil
 	}
 }
+
+func TestVersionNameWithoutPatch(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+
+	t.Run("ok-without-prefix", func(t *testing.T) {
+		version := "1.32.3"
+		expected := "1.32"
+		actual, err := k8s.VersionNameWithoutPatch(version)
+		require.NoError(t, err)
+		assert.Equal(t, expected, actual)
+	})
+	t.Run("ok-with-prefix", func(t *testing.T) {
+		version := "v2.57.9"
+		expected := "v2.57"
+		actual, err := k8s.VersionNameWithoutPatch(version)
+		require.NoError(t, err)
+		assert.Equal(t, expected, actual)
+	})
+	t.Run("errors", func(t *testing.T) {
+		versionsToTest := []string{
+			"1.32.3.4",
+			"1.32",
+			"",
+		}
+		for _, version := range versionsToTest {
+			expectedError := "version name must contain 3 parts"
+			_, err := k8s.VersionNameWithoutPatch(version)
+			assert.ErrorContains(t, err, expectedError)
+		}
+	})
+}