fix(instance): resource image with option public as a pointer on SDK-Go (#1692)

Author: Monitob

go.mod

@@ -13,7 +13,7 @@ require (
 	github.com/hashicorp/terraform-plugin-log v0.7.0
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.24.1
 	github.com/robfig/cron/v3 v3.0.1
-	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.10.0.20221212155715-1af141c8883f
+	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.11
 	github.com/stretchr/testify v1.8.1
 )
 

go.sum

@@ -227,8 +227,8 @@ github.com/prometheus/client_model v0.0.0-20190812154241-14fe0d1b01d4/go.mod h1:
 github.com/robfig/cron/v3 v3.0.1 h1:WdRxkvbJztn8LMz/QEvLN5sBU+xKpSqwwUO1Pjr4qDs=
 github.com/robfig/cron/v3 v3.0.1/go.mod h1:eQICP3HwyT7UooqI/z+Ov+PtYAWygg1TEWWzGIFLtro=
 github.com/rogpeppe/fastuuid v1.2.0/go.mod h1:jVj6XXZzXRy/MSR5jhDC/2q6DgLz+nrA6LYCDYWNEvQ=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.10.0.20221212155715-1af141c8883f h1:3wdSpuBw2nlULXpYgNsh2uii60adEuWdqP5QXHw5/m0=
-github.com/scaleway/scaleway-sdk-go v1.0.0-beta.10.0.20221212155715-1af141c8883f/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.11 h1:aBAUkfUmdpAs/7Yeq6T3inWFaKPxDmdkLMjbktx7qCs=
+github.com/scaleway/scaleway-sdk-go v1.0.0-beta.11/go.mod h1:fCa7OJZ/9DRTnOKmxvT6pn+LPWUptQAmHF/SBJUGEcg=
 github.com/sebdah/goldie v1.0.0/go.mod h1:jXP4hmWywNEwZzhMuv2ccnqTSFpuq8iyQhtQdkkZBH4=
 github.com/sergi/go-diff v1.1.0/go.mod h1:STckp+ISIX8hZLjrqAeVduY0gWCT9IjLuqbuNXdaHfM=
 github.com/sergi/go-diff v1.2.0 h1:XU+rvMAioB0UC3q1MFrIQy4Vo5/4VsRDQQXHsEya6xQ=

scaleway/resource_instance_image.go

@@ -183,7 +183,7 @@ func resourceScalewayInstanceImageCreate(ctx context.Context, d *schema.Resource
 		RootVolume: expandZonedID(d.Get("root_volume_id").(string)).ID,
 		Arch:       instance.Arch(d.Get("architecture").(string)),
 		Project:    expandStringPtr(d.Get("project_id")),
-		Public:     false,
+		Public:     expandBoolPtr(d.Get("public")),
 	}
 
 	extraVolumesIds, volumesExist := d.GetOk("additional_volume_ids")
@@ -198,8 +198,8 @@ func resourceScalewayInstanceImageCreate(ctx context.Context, d *schema.Resource
 	if tagsExist {
 		req.Tags = expandStrings(tags)
 	}
-	if isPublic := d.Get("public"); isPublic == true {
-		req.Public = true
+	if _, exist := d.GetOk("public"); exist {
+		req.Public = expandBoolPtr(getBool(d, "public"))
 	}
 
 	res, err := instanceAPI.CreateImage(req, scw.WithContext(ctx))
@@ -275,7 +275,7 @@ func resourceScalewayInstanceImageUpdate(ctx context.Context, d *schema.Resource
 		req.Arch = instance.Arch(d.Get("architecture").(string))
 	}
 	if d.HasChange("public") {
-		req.Public = d.Get("public").(bool)
+		req.Public = *expandBoolPtr(getBool(d, "public"))
 	}
 	req.Tags = expandUpdatedStringsPtr(d.Get("tags"))