refactor: replace interface{} with any and remove unnecessary comments

Author: jremy42

internal/services/rdb/instance.go

@@ -699,9 +699,9 @@ func ResourceRdbInstanceRead(ctx context.Context, d *schema.ResourceData, m any)
 		_ = d.Set("encryption_at_rest", res.Encryption.Enabled)
 	}
 
-	upgradableVersions := make([]map[string]interface{}, len(res.UpgradableVersion))
+	upgradableVersions := make([]map[string]any, len(res.UpgradableVersion))
 	for i, version := range res.UpgradableVersion {
-		upgradableVersions[i] = map[string]interface{}{
+		upgradableVersions[i] = map[string]any{
 			"id":            version.ID,
 			"name":          version.Name,
 			"version":       version.Version,

internal/services/rdb/instance_test.go

@@ -1585,28 +1585,24 @@ func TestAccInstance_EngineUpgrade(t *testing.T) {
 					isInstancePresent(tt, "scaleway_rdb_instance.main"),
 					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "engine", oldVersion),
 					resource.TestCheckResourceAttrSet("scaleway_rdb_instance.main", "upgradable_versions.#"),
-					// Capture old instance ID and verify upgradable_versions fields
 					func(s *terraform.State) error {
 						rs, ok := s.RootModule().Resources["scaleway_rdb_instance.main"]
 						if !ok {
 							return errors.New("resource not found: scaleway_rdb_instance.main")
 						}
 
-						// Capture the old instance ID
 						_, _, ID, err := rdb.NewAPIWithRegionAndID(tt.Meta, rs.Primary.ID)
 						if err != nil {
 							return err
 						}
 
 						oldInstanceID = ID
 
-						// Verify upgradable_versions is populated
 						upgradableVersionsCount := rs.Primary.Attributes["upgradable_versions.#"]
 						if upgradableVersionsCount == "" || upgradableVersionsCount == "0" {
 							return fmt.Errorf("expected at least one upgradable version, got %s", upgradableVersionsCount)
 						}
 
-						// Check that each version has the required fields
 						for i := 0; ; i++ {
 							idKey := fmt.Sprintf("upgradable_versions.%d.id", i)
 							if _, ok := rs.Primary.Attributes[idKey]; !ok {
@@ -1672,9 +1668,7 @@ func TestAccInstance_EngineUpgrade(t *testing.T) {
 					isInstancePresent(tt, "scaleway_rdb_instance.main"),
 					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "engine", newVersion),
 					resource.TestCheckResourceAttr("scaleway_rdb_instance.main", "name", "test-rdb-engine-upgrade"),
-					// Verify endpoints are preserved
 					resource.TestCheckResourceAttrSet("scaleway_rdb_instance.main", "load_balancer.0.ip"),
-					// Verify instance ID changed and old instance is destroyed
 					func(s *terraform.State) error {
 						rs, ok := s.RootModule().Resources["scaleway_rdb_instance.main"]
 						if !ok {
@@ -1686,12 +1680,10 @@ func TestAccInstance_EngineUpgrade(t *testing.T) {
 							return err
 						}
 
-						// Verify the instance ID has changed
 						if newInstanceID == oldInstanceID {
 							return fmt.Errorf("expected new instance ID after upgrade, but got same ID: %s", newInstanceID)
 						}
 
-						// Verify the old instance is destroyed (should return 404)
 						_, err = rdbAPI.GetInstance(&rdbSDK.GetInstanceRequest{
 							Region:     region,
 							InstanceID: oldInstanceID,
@@ -1700,7 +1692,6 @@ func TestAccInstance_EngineUpgrade(t *testing.T) {
 							return fmt.Errorf("expected old instance %s to be destroyed, but it still exists", oldInstanceID)
 						}
 
-						// Check that the error is a 404
 						if !httperrors.Is404(err) {
 							return fmt.Errorf("expected 404 error for old instance %s, got: %w", oldInstanceID, err)
 						}