Remove useless changes

Author: remyleone

internal/locality/dsf.go

@@ -2,6 +2,7 @@ package locality
 
 import "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 
+// SuppressSDKNullAssignment aims to remove apply inconsistency on SDKv2 based resources
 func SuppressSDKNullAssignment(k, old, new string, d *schema.ResourceData) bool {
 	return (new == "" && old != "") || (new != "" && old == "")
 }

internal/provider/testdata/test-mux-server.cassette.yaml

@@ -172,7 +172,7 @@ func ResourceInstanceIPRead(ctx context.Context, d *schema.ResourceData, m any)
 
 	_ = d.Set("address", address)
 	_ = d.Set("prefix", prefix)
-	_ = d.Set("zone", res.IP.Zone)
+	_ = d.Set("zone", zone)
 	_ = d.Set("organization_id", res.IP.Organization)
 	_ = d.Set("project_id", res.IP.Project)
 	_ = d.Set("reverse", res.IP.Reverse)

internal/services/instance/ip.go

@@ -281,7 +281,7 @@ func ResourceIPAMIPRead(ctx context.Context, d *schema.ResourceData, m any) diag
 	_ = d.Set("created_at", types.FlattenTime(res.CreatedAt))
 	_ = d.Set("updated_at", types.FlattenTime(res.UpdatedAt))
 	_ = d.Set("is_ipv6", res.IsIPv6)
-	_ = d.Set("region", res.Region.String())
+	_ = d.Set("region", region)
 
 	if res.Zone != nil {
 		_ = d.Set("zone", res.Zone.String())

internal/services/ipam/ip.go

@@ -224,8 +224,10 @@ func ResourceRdbReadReplicaRead(ctx context.Context, d *schema.ResourceData, m a
 	directAccess, privateNetwork := flattenReadReplicaEndpoints(rr.Endpoints)
 	_ = d.Set("direct_access", directAccess)
 	_ = d.Set("private_network", privateNetwork)
+
+	regionStr := region.String()
 	_ = d.Set("same_zone", rr.SameZone)
-	_ = d.Set("region", rr.Region.String())
+	_ = d.Set("region", regionStr)
 	_ = d.Set("instance_id", regional.NewIDString(region, rr.InstanceID))
 
 	return nil

internal/services/rdb/read_replica.go

@@ -126,7 +126,6 @@ func ResourceDomainValidationRead(ctx context.Context, d *schema.ResourceData, m
 	}
 
 	_ = d.Set("validated", domain.Status == "checked")
-	_ = d.Set("region", domain.Region.String())
 
 	return nil
 }

internal/services/tem/domain_validation.go

@@ -266,7 +266,7 @@ func ResourceVPCPrivateNetworkRead(ctx context.Context, d *schema.ResourceData,
 	_ = d.Set("updated_at", types.FlattenTime(pn.UpdatedAt))
 	_ = d.Set("tags", pn.Tags)
 	_ = d.Set("enable_default_route_propagation", pn.DefaultRoutePropagationEnabled)
-	_ = d.Set("region", pn.Region.String())
+	_ = d.Set("region", region)
 	_ = d.Set("is_regional", true)
 	_ = d.Set("zone", zone)
 

internal/services/vpc/private_network.go

@@ -142,7 +142,7 @@ func ResourceVPCRead(ctx context.Context, d *schema.ResourceData, m any) diag.Di
 	_ = d.Set("is_default", res.IsDefault)
 	_ = d.Set("enable_routing", res.RoutingEnabled)
 	_ = d.Set("enable_custom_routes_propagation", res.CustomRoutesPropagationEnabled)
-	_ = d.Set("region", res.Region.String())
+	_ = d.Set("region", region)
 
 	if len(res.Tags) > 0 {
 		_ = d.Set("tags", res.Tags)

internal/services/vpc/vpc.go

@@ -325,7 +325,7 @@ func resourceWebhostingRead(ctx context.Context, d *schema.ResourceData, m any)
 	_ = d.Set("dns_status", webhostingResponse.DNSStatus.String()) //nolint:staticcheck
 	_ = d.Set("cpanel_urls", flattenHostingCpanelUrls(webhostingResponse.Platform.ControlPanel.URLs))
 	_ = d.Set("username", webhostingResponse.User.Username)
-	_ = d.Set("region", webhostingResponse.Region.String())
+	_ = d.Set("region", string(region))
 	_ = d.Set("organization_id", "")
 	_ = d.Set("project_id", webhostingResponse.ProjectID)