tests(object): enable tests and handle s3 with cassettes (#1555)

Co-authored-by: Rémy Léone <[email protected]>

Author: Codelax

.github/workflows/coverage.yml

@@ -19,5 +19,7 @@ jobs:
           TF_TEST_DOMAIN: scaleway-terraform.com
           TF_UPDATE_CASSETTES: false
           TF_TEST_DOMAIN_ZONE: tf
+          SCW_ACCESS_KEY: "SCWXXXXXXXXXXXXXFAKE"
+          SCW_SECRET_KEY: "11111111-1111-1111-1111-111111111111"
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v2

scaleway/data_source_object_bucket_test.go

@@ -9,9 +9,6 @@ import (
 )
 
 func TestAccScalewayDataSourceObjectStorage_Basic(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
 	bucketName := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-bucket")

scaleway/provider_test.go

@@ -3,6 +3,7 @@ package scaleway
 import (
 	"context"
 	"encoding/json"
+	"encoding/xml"
 	"flag"
 	"fmt"
 	"io"
@@ -121,6 +122,12 @@ func cassetteBodyMatcher(actual *http.Request, expected cassette.Request) bool {
 	actualJSON := make(map[string]interface{})
 	expectedJSON := make(map[string]interface{})
 
+	err = xml.Unmarshal(actualRawBody, new(interface{}))
+	if err == nil {
+		// match if content is xml
+		return true
+	}
+
 	err = json.Unmarshal(actualRawBody, &actualJSON)
 	if err != nil {
 		panic(fmt.Errorf("cassette body matcher: failed to parse json body: %w", err))
@@ -154,6 +161,31 @@ func cassetteMatcher(actual *http.Request, expected cassette.Request) bool {
 	actualURL.RawQuery = actualURLValues.Encode()
 	expectedURL.RawQuery = expectedURLValues.Encode()
 
+	// Specific handling of s3 URLs
+	// Url format is https://test-acc-scaleway-object-bucket-lifecycle-8445817190507446251.s3.fr-par.scw.cloud/?lifecycle=
+	if strings.HasSuffix(actualURL.Host, "scw.cloud") {
+		if !strings.HasSuffix(expectedURL.Host, "scw.cloud") {
+			return false
+		}
+		actualS3Host := strings.Split(actualURL.Host, ".")
+		expectedS3Host := strings.Split(expectedURL.Host, ".")
+
+		if len(actualS3Host) >= 5 {
+			// Host is bucket.s3.region.scw.cloud
+			// it could be a host without bucket name (ex: function upload)
+			actualBucket := actualS3Host[0]
+			expectedBucket := expectedS3Host[0]
+
+			// Remove random number at the end of the bucket name
+			actualBucket = actualBucket[:strings.LastIndex(actualBucket, "-")]
+			expectedBucket = expectedBucket[:strings.LastIndex(expectedBucket, "-")]
+
+			if actualBucket != expectedBucket {
+				return false
+			}
+		}
+	}
+
 	return actual.Method == expected.Method &&
 		actual.URL.Path == expectedURL.Path &&
 		actualURL.RawQuery == expectedURL.RawQuery &&

scaleway/resource_object_bucket_acl_test.go

@@ -3,18 +3,15 @@ package scaleway
 import (
 	"fmt"
 	"testing"
-	"time"
 
+	sdkacctest "github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
 )
 
 func TestAccScalewayObjectBucketACL_Basic(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
-	testBucketName := fmt.Sprintf("terraform-test-%d", time.Now().Unix())
+	testBucketName := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-acl-basic")
 
 	resource.Test(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },
@@ -62,12 +59,10 @@ func TestAccScalewayObjectBucketACL_Basic(t *testing.T) {
 }
 
 func TestAccScalewayObjectBucketACL_Grantee(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
-	testBucketName := fmt.Sprintf("terraform-test-%d", time.Now().Unix())
+	testBucketName := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-acl-grantee")
+
 	ownerID := "105bdce1-64c0-48ab-899d-868455867ecf"
 	ownerIDChild := "50ab77d5-56bd-4981-a118-4e0fa5309b59"
 	resource.Test(t, resource.TestCase{
@@ -147,12 +142,9 @@ func TestAccScalewayObjectBucketACL_Grantee(t *testing.T) {
 }
 
 func TestAccScalewayObjectBucketACL_GranteeWithOwner(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
-	testBucketName := fmt.Sprintf("terraform-test-%d", time.Now().Unix())
+	testBucketName := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-acl-grantee-owner")
 	ownerID := "105bdce1-64c0-48ab-899d-868455867ecf"
 	resource.Test(t, resource.TestCase{
 		PreCheck:          func() { testAccPreCheck(t) },

scaleway/resource_object_bucket_test.go

@@ -24,16 +24,13 @@ func init() {
 }
 
 func TestAccScalewayObjectBucket_Basic(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
 	testBucketACL := "private"
 	testBucketUpdatedACL := "public-read"
-	bucketBasic := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-bucket-basic-")
-	bucketAms := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-bucket-ams-")
-	bucketPar := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-bucket-par-")
+	bucketBasic := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-bucket-basic")
+	bucketAms := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-bucket-ams")
+	bucketPar := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-bucket-par")
 	bucketLifecycle := sdkacctest.RandomWithPrefix("test-acc-scaleway-object-bucket-lifecycle")
 	resourceNameLifecycle := "scaleway_object_bucket.par-bucket-lifecycle"
 	resource.ParallelTest(t, resource.TestCase{
@@ -392,9 +389,6 @@ func testSweepStorageObjectBucket(_ string) error {
 }
 
 func TestAccScalewayObjectBucket_Cors_Update(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -493,9 +487,6 @@ func TestAccScalewayObjectBucket_Cors_Update(t *testing.T) {
 }
 
 func TestAccScalewayObjectBucket_Cors_Delete(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
 	ctx := context.Background()
@@ -551,9 +542,6 @@ func TestAccScalewayObjectBucket_Cors_Delete(t *testing.T) {
 }
 
 func TestAccScalewayObjectBucket_Cors_EmptyOrigin(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -657,9 +645,6 @@ func testAccCheckScalewayObjectBucketExists(tt *TestTools, n string) resource.Te
 }
 
 func TestAccScalewayObjectBucket_DestroyForce(t *testing.T) {
-	if !*UpdateCassettes {
-		t.Skip("Skipping ObjectStorage test as this kind of resource can't be deleted before 24h")
-	}
 	tt := NewTestTools(t)
 	defer tt.Cleanup()