fix(instance): get server-type instead of listing (#1959)

* fix(instance): get server-type instead of listing

* update InstanceServer cassettes

* update InstanceServers cassette

* update lb cassette

* update vpc cassettes

* update instance root_volume_boot cassette

* update instance snapshot cassettes

* update instance image cassettes

* update instance private-nic cassettes

* update instance placement group cassette

* update instance user-data cassette

Author: Codelax

scaleway/helpers_instance.go

@@ -193,21 +193,20 @@ func reachState(ctx context.Context, instanceAPI *instance.API, zone scw.Zone, s
 
 // getServerType is a util to get a instance.ServerType by its commercialType
 func getServerType(ctx context.Context, apiInstance *instance.API, zone scw.Zone, commercialType string) *instance.ServerType {
-	serverType := (*instance.ServerType)(nil)
-
-	serverTypesRes, err := apiInstance.ListServersTypes(&instance.ListServersTypesRequest{
+	serverType, err := apiInstance.GetServerType(&instance.GetServerTypeRequest{
 		Zone: zone,
+		Name: commercialType,
 	})
 	if err != nil {
 		tflog.Warn(ctx, fmt.Sprintf("cannot get server types: %s", err))
 	} else {
-		serverType = serverTypesRes.Servers[commercialType]
 		if serverType == nil {
 			tflog.Warn(ctx, fmt.Sprintf("unrecognized server type: %s", commercialType))
 		}
+		return serverType
 	}
 
-	return serverType
+	return nil
 }
 
 // validateLocalVolumeSizes validates the total size of local volumes.