instance failed cassette + linter + cassette validation ok

Author: Mia-Cross

internal/services/baremetal/server.go

@@ -548,6 +548,7 @@ func ResourceServerRead(ctx context.Context, d *schema.ResourceData, m interface
 		}
 
 		privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, pnRegion, opts)
+
 		switch {
 		case err == nil:
 			allPrivateIPs = append(allPrivateIPs, privateIPs...)

internal/services/instance/private_nic.go

@@ -189,6 +189,7 @@ func ResourceInstancePrivateNICRead(ctx context.Context, d *schema.ResourceData,
 
 	// Get private NIC's private IPs if possible
 	diags := diag.Diagnostics{}
+
 	region, err := zone.Region()
 	if err != nil {
 		return append(diags, diag.Diagnostic{
@@ -216,6 +217,7 @@ func ResourceInstancePrivateNICRead(ctx context.Context, d *schema.ResourceData,
 	}
 
 	privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
+
 	switch {
 	case err == nil:
 		_ = d.Set("private_ips", privateIPs)

internal/services/instance/server.go

@@ -785,6 +785,7 @@ func ResourceInstanceServerRead(ctx context.Context, d *schema.ResourceData, m i
 	// Display warning if server will soon reach End of Service
 	////
 	diags := diag.Diagnostics{}
+
 	if server.EndOfService {
 		compatibleTypes, err := api.GetServerCompatibleTypes(&instanceSDK.GetServerCompatibleTypesRequest{
 			Zone:     zone,
@@ -855,6 +856,7 @@ You can check the full list of compatible server types:
 		}
 
 		privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
+
 		switch {
 		case err == nil:
 			allPrivateIPs = append(allPrivateIPs, privateIPs...)

internal/services/instance/testdata/private-nic-basic.cassette.yaml

@@ -449,30 +449,36 @@ func ResourceK8SPoolRead(ctx context.Context, d *schema.ResourceData, m interfac
 				continue
 			}
 
+			authorized := true
 			opts := &ipam.GetResourcePrivateIPsOptions{
 				ResourceName: &nodeName,
 				ProjectID:    &projectID,
 			}
 
 			privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
+
 			switch {
 			case err == nil:
 				nodes[i]["private_ips"] = privateIPs
 			case httperrors.Is403(err):
+				authorized = false
+
 				diags = append(diags, diag.Diagnostic{
 					Severity: diag.Warning,
 					Summary:  "Unauthorized to read nodes' private IPs, please check your IAM permissions",
 					Detail:   err.Error(),
 				})
-
-				break
 			default:
 				diags = append(diags, diag.Diagnostic{
 					Severity: diag.Warning,
 					Summary:  fmt.Sprintf("Unable to get private IPs for node %q", nodeName),
 					Detail:   err.Error(),
 				})
 			}
+
+			if !authorized {
+				break
+			}
 		}
 	}
 

internal/services/k8s/pool.go

@@ -685,19 +685,19 @@ func ResourceRdbInstanceRead(ctx context.Context, d *schema.ResourceData, m inte
 			}
 
 			endpointPrivateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
+
 			switch {
 			case err == nil:
 				privateIPs = append(privateIPs, endpointPrivateIPs...)
 			case httperrors.Is403(err):
 				authorized = false
+
 				diags = append(diags, diag.Diagnostic{
 					Severity:      diag.Warning,
 					Summary:       "Unauthorized to read RDB Instance's private IP, please check your IAM permissions",
 					Detail:        err.Error(),
 					AttributePath: cty.GetAttrPath("private_ip"),
 				})
-
-				break
 			default:
 				diags = append(diags, diag.Diagnostic{
 					Severity:      diag.Warning,
@@ -706,6 +706,10 @@ func ResourceRdbInstanceRead(ctx context.Context, d *schema.ResourceData, m inte
 					AttributePath: cty.GetAttrPath("private_ip"),
 				})
 			}
+
+			if !authorized {
+				break
+			}
 		}
 	}
 

internal/services/k8s/testdata/pool-public-ip-disabled.cassette.yaml

@@ -386,6 +386,7 @@ func ResourceClusterRead(ctx context.Context, d *schema.ResourceData, m interfac
 		} else {
 			resourceType := ipamAPI.ResourceTypeRedisCluster
 			privateNetworkIDs := []string(nil)
+
 			for _, endpoint := range cluster.Endpoints {
 				if endpoint.PrivateNetwork != nil {
 					privateNetworkIDs = append(privateNetworkIDs, endpoint.PrivateNetwork.ID)
@@ -401,19 +402,19 @@ func ResourceClusterRead(ctx context.Context, d *schema.ResourceData, m interfac
 				}
 
 				privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
+
 				switch {
 				case err == nil:
 					allPrivateIPs = append(allPrivateIPs, privateIPs...)
 				case httperrors.Is403(err):
 					authorized = false
+
 					diags = append(diags, diag.Diagnostic{
 						Severity:      diag.Warning,
 						Summary:       "Unauthorized to read cluster's private IPs, please check your IAM permissions",
 						Detail:        err.Error(),
 						AttributePath: cty.GetAttrPath("private_ips"),
 					})
-
-					break
 				default:
 					diags = append(diags, diag.Diagnostic{
 						Severity:      diag.Warning,
@@ -422,6 +423,10 @@ func ResourceClusterRead(ctx context.Context, d *schema.ResourceData, m interfac
 						AttributePath: cty.GetAttrPath("private_ips"),
 					})
 				}
+
+				if !authorized {
+					break
+				}
 			}
 		}
 	}