fix forceNew add Locality to customDiff

Author: Laure-di

internal/services/block/helpers_block.go

@@ -11,6 +11,7 @@ import (
 	"github.com/scaleway/scaleway-sdk-go/scw"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/dsf"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
+	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/zonal"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/meta"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/instance/instancehelpers"
@@ -69,9 +70,11 @@ func customDiffSnapshot(key string) schema.CustomizeDiffFunc {
 		}
 
 		blockAPI := block.NewAPI(meta.ExtractScwClient(i))
+		zone, id, _ := locality.ParseLocalizedID(oldValue.(string))
 
 		_, err := blockAPI.GetSnapshot(&block.GetSnapshotRequest{
-			SnapshotID: oldValue.(string),
+			SnapshotID: id,
+			Zone:       scw.Zone(zone),
 		})
 		if (httperrors.Is403(err) || httperrors.Is404(err)) && newValue == "" {
 			return nil

internal/services/block/volume.go

@@ -7,8 +7,8 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	block "github.com/scaleway/scaleway-sdk-go/api/block/v1alpha1"
-	"github.com/scaleway/scaleway-sdk-go/logger"
 	"github.com/scaleway/scaleway-sdk-go/scw"
+	"github.com/scaleway/terraform-provider-scaleway/v2/internal/dsf"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/httperrors"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/zonal"
@@ -52,9 +52,10 @@ func ResourceVolume() *schema.Resource {
 				Description: "The volume size in GB",
 			},
 			"snapshot_id": {
-				Type:        schema.TypeString,
-				Optional:    true,
-				Description: "The snapshot to create the volume from",
+				Type:             schema.TypeString,
+				Optional:         true,
+				Description:      "The snapshot to create the volume from",
+				DiffSuppressFunc: dsf.Locality,
 			},
 			"instance_volume_id": {
 				Type:          schema.TypeString,
@@ -173,7 +174,6 @@ func ResourceBlockVolumeRead(ctx context.Context, d *schema.ResourceData, m any)
 	snapshotID := ""
 
 	if volume.ParentSnapshotID != nil {
-		logger.Debugf("found snapshot In READ %s", volume.ParentSnapshotID)
 		_, err := api.GetSnapshot(&block.GetSnapshotRequest{
 			SnapshotID: *volume.ParentSnapshotID,
 			Zone:       zone,