cassettes + lint

Author: Mia-Cross

internal/services/ipam/helpers.go

@@ -87,12 +87,15 @@ func GetResourcePrivateIPs(ctx context.Context, m interface{}, region scw.Region
 		if opts.PrivateNetworkID != nil {
 			req.PrivateNetworkID = opts.PrivateNetworkID
 		}
+
 		if opts.ResourceID != nil {
 			req.ResourceID = opts.ResourceID
 		}
+
 		if opts.ResourceName != nil {
 			req.ResourceName = opts.ResourceName
 		}
+
 		if opts.ResourceType != nil {
 			req.ResourceType = *opts.ResourceType
 		}
@@ -108,11 +111,13 @@ func GetResourcePrivateIPs(ctx context.Context, m interface{}, region scw.Region
 	}
 
 	ipList := make([]map[string]interface{}, 0, len(resp.IPs))
+
 	for _, ip := range resp.IPs {
 		ipNet := ip.Address
 		if ipNet.IP == nil {
 			continue
 		}
+
 		ipMap := map[string]interface{}{
 			"id":      regional.NewIDString(region, ip.ID),
 			"address": ipNet.IP.String(),

internal/services/lb/lb.go

@@ -3,8 +3,6 @@ package lb
 import (
 	"context"
 	"fmt"
-	ipamAPI "github.com/scaleway/scaleway-sdk-go/api/ipam/v1"
-	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/ipam"
 	"net"
 	"strings"
 	"time"
@@ -13,6 +11,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	ipamAPI "github.com/scaleway/scaleway-sdk-go/api/ipam/v1"
 	lbSDK "github.com/scaleway/scaleway-sdk-go/api/lb/v1"
 	"github.com/scaleway/scaleway-sdk-go/scw"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/cdf"
@@ -22,6 +21,7 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/regional"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/zonal"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/account"
+	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/ipam"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/types"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/verify"
 )
@@ -360,17 +360,20 @@ func resourceLbRead(ctx context.Context, d *schema.ResourceData, m interface{})
 		privateNetworkIDs = append(privateNetworkIDs, pn.PrivateNetworkID)
 	}
 
-	var allPrivateIPs []map[string]interface{}
+	allPrivateIPs := []map[string]interface{}(nil)
 	resourceType := ipamAPI.ResourceTypeLBServer
+
 	for _, privateNetworkID := range privateNetworkIDs {
 		opts := &ipam.GetResourcePrivateIPsOptions{
 			ResourceType:     &resourceType,
 			PrivateNetworkID: &privateNetworkID,
 		}
+
 		privateIPs, err := ipam.GetResourcePrivateIPs(ctx, m, region, opts)
 		if err != nil {
 			return diag.FromErr(err)
 		}
+
 		if privateIPs != nil {
 			allPrivateIPs = append(allPrivateIPs, privateIPs...)
 		}