go mod tidy + fix placement group test

Author: Mia-Cross

go.mod

@@ -35,6 +35,7 @@ require (
 	golang.org/x/crypto v0.43.0
 	golang.org/x/sync v0.17.0
 	gopkg.in/dnaeon/go-vcr.v3 v3.2.0
+	gopkg.in/dnaeon/go-vcr.v4 v4.0.5
 )
 
 require (
@@ -172,7 +173,6 @@ require (
 	google.golang.org/genproto/googleapis/rpc v0.0.0-20250825161204-c5933d9347a5 // indirect
 	google.golang.org/grpc v1.75.1 // indirect
 	google.golang.org/protobuf v1.36.9 // indirect
-	gopkg.in/dnaeon/go-vcr.v4 v4.0.5 // indirect
 	gopkg.in/ini.v1 v1.66.4 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect

internal/services/instance/server_test.go

@@ -710,6 +710,29 @@ func TestAccServer_AdditionalVolumesDetach(t *testing.T) {
 	})
 }
 
+//resource "scaleway_instance_server" "ha0" {
+//name = "tf-tests-server-with-placement-group-0"
+//image = "ubuntu_focal"
+//type  = "PLAY2-PICO"
+//placement_group_id = "${scaleway_instance_placement_group.ha.id}"
+//tags  = [ "terraform-test", "scaleway_instance_server", "placement_group", "0" ]
+//}
+//
+//resource "scaleway_instance_server" "ha1" {
+//name = "tf-tests-server-with-placement-group-1"
+//image = "ubuntu_focal"
+//type  = "PLAY2-PICO"
+//placement_group_id = "${scaleway_instance_placement_group.ha.id}"
+//tags  = [ "terraform-test", "scaleway_instance_server", "placement_group", "1" ]
+//}
+//
+//resource "scaleway_instance_server" "ha2" {
+//name = "tf-tests-server-with-placement-group-2"
+//image = "ubuntu_focal"
+//type  = "PLAY2-PICO"
+//placement_group_id = "${scaleway_instance_placement_group.ha.id}"
+//tags  = [ "terraform-test", "scaleway_instance_server", "placement_group", "2" ]
+
 func TestAccServer_WithPlacementGroup(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
@@ -726,25 +749,25 @@ func TestAccServer_WithPlacementGroup(t *testing.T) {
 						policy_type = "max_availability"
 					}
 					
-					resource "scaleway_instance_server" "base" {
+					resource "scaleway_instance_server" "ha" {
 						count = 3
 						name = "tf-tests-server-${count.index}-with-placement-group"
 						image = "ubuntu_focal"
 						type  = "PLAY2-PICO"
 						placement_group_id = "${scaleway_instance_placement_group.ha.id}"
-						tags  = [ "terraform-test", "scaleway_instance_server", "placement_group" ]
+						tags  = [ "terraform-test", "scaleway_instance_server", "placement_group", "${count.index}" ]
 					}`,
 				Check: resource.ComposeTestCheckFunc(
-					isServerPresent(tt, "scaleway_instance_server.base.0"),
-					isServerPresent(tt, "scaleway_instance_server.base.1"),
-					isServerPresent(tt, "scaleway_instance_server.base.2"),
+					isServerPresent(tt, "scaleway_instance_server.ha.0"),
+					isServerPresent(tt, "scaleway_instance_server.ha.1"),
+					isServerPresent(tt, "scaleway_instance_server.ha.2"),
 					isPlacementGroupPresent(tt, "scaleway_instance_placement_group.ha"),
 					resource.TestCheckResourceAttr("scaleway_instance_placement_group.ha", "policy_respected", "true"),
 
 					// placement_group_policy_respected is deprecated and should always be false.
-					resource.TestCheckResourceAttr("scaleway_instance_server.base.0", "placement_group_policy_respected", "false"),
-					resource.TestCheckResourceAttr("scaleway_instance_server.base.1", "placement_group_policy_respected", "false"),
-					resource.TestCheckResourceAttr("scaleway_instance_server.base.2", "placement_group_policy_respected", "false"),
+					resource.TestCheckResourceAttr("scaleway_instance_server.ha.0", "placement_group_policy_respected", "false"),
+					resource.TestCheckResourceAttr("scaleway_instance_server.ha.1", "placement_group_policy_respected", "false"),
+					resource.TestCheckResourceAttr("scaleway_instance_server.ha.2", "placement_group_policy_respected", "false"),
 				),
 			},
 		},