set snapshot_id to null if legagcy one

Author: Laure-di

internal/services/block/helpers_block.go

@@ -2,7 +2,6 @@ package block
 
 import (
 	"context"
-	"github.com/scaleway/terraform-provider-scaleway/v2/internal/logging"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/customdiff"
@@ -69,15 +68,9 @@ func customDiffSnapshot(key string) schema.CustomizeDiffFunc {
 		_, err := blockAPI.GetSnapshot(&block.GetSnapshotRequest{
 			SnapshotID: oldValue.(string),
 		})
-		logging.L.Debugf("customDiffSnapshot: old=%s, new=%s", oldValue, newValue)
-		logging.L.Debugf("error: %v", err)
-
 		if (httperrors.Is403(err) || httperrors.Is404(err)) && newValue == "" {
-			logging.L.Infof("customDiffSnapshot: snapshot %s is missing or forbidden", oldValue)
 			return nil
 		}
-
-		logging.L.Infof("customDiffSnapshot: forcing recreation due to snapshot_id change")
 		return diff.ForceNew(key)
 	}
 }

internal/services/block/volume.go

@@ -53,6 +53,7 @@ func ResourceVolume() *schema.Resource {
 			"snapshot_id": {
 				Type:             schema.TypeString,
 				Optional:         true,
+				ForceNew:         true,
 				Description:      "The snapshot to create the volume from",
 				DiffSuppressFunc: dsf.Locality,
 			},
@@ -76,8 +77,8 @@ func ResourceVolume() *schema.Resource {
 			"project_id": account.ProjectIDSchema(),
 		},
 		CustomizeDiff: customdiff.All(
-			customDiffCannotShrink("size_in_gb"),
 			customDiffSnapshot("snapshot_id"),
+			customDiffCannotShrink("size_in_gb"),
 		),
 	}
 }
@@ -170,8 +171,11 @@ func ResourceBlockVolumeRead(ctx context.Context, d *schema.ResourceData, m any)
 	_ = d.Set("zone", volume.Zone)
 	_ = d.Set("project_id", volume.ProjectID)
 	_ = d.Set("tags", volume.Tags)
-
-	if volume.ParentSnapshotID != nil {
+	_, err = api.GetSnapshot(&block.GetSnapshotRequest{
+		SnapshotID: *volume.ParentSnapshotID,
+		Zone:       zone,
+	})
+	if volume.ParentSnapshotID != nil && !httperrors.Is403(err) && !httperrors.Is404(err) {
 		_ = d.Set("snapshot_id", zonal.NewIDString(zone, *volume.ParentSnapshotID))
 	} else {
 		_ = d.Set("snapshot_id", "")