From 1ac4f22b6743536dfbd10b559444a79afb01c97c Mon Sep 17 00:00:00 2001 From: Jules Casteran Date: Fri, 13 Dec 2024 15:21:15 +0100 Subject: [PATCH 1/3] doc(instance_server): mark private_ip as deprecated --- docs/resources/instance_server.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/resources/instance_server.md b/docs/resources/instance_server.md index 9e892e6e2f..302abfe89d 100644 --- a/docs/resources/instance_server.md +++ b/docs/resources/instance_server.md @@ -286,8 +286,8 @@ In addition to all arguments above, the following attributes are exported: - `placement_group_policy_respected` - True when the placement group policy is respected. - `root_volume` - `volume_id` - The volume ID of the root volume of the server. -- `private_ip` - The Scaleway internal IP address of the server. -- `public_ip` - The public IP address of the server (Deprecated use `public_ips` instead). +- `private_ip` - The Scaleway internal IP address of the server (Deprecated use [ipam_ip datasource](../data-sources/ipam_ip#instance-private-network-ip) instead). +- `public_ip` - The public IP address of the server (Deprecated use `public_ips` instead). - `public_ips` - The list of public IPs of the server. - `id` - The ID of the IP - `address` - The address of the IP From 210f17e8b1dc469849029ec14bf118a7be6b2aa7 Mon Sep 17 00:00:00 2001 From: Jules Casteran Date: Fri, 13 Dec 2024 16:25:10 +0100 Subject: [PATCH 2/3] fix link --- docs/resources/instance_server.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/resources/instance_server.md b/docs/resources/instance_server.md index 302abfe89d..05567fcb15 100644 --- a/docs/resources/instance_server.md +++ b/docs/resources/instance_server.md @@ -286,7 +286,7 @@ In addition to all arguments above, the following attributes are exported: - `placement_group_policy_respected` - True when the placement group policy is respected. - `root_volume` - `volume_id` - The volume ID of the root volume of the server. -- `private_ip` - The Scaleway internal IP address of the server (Deprecated use [ipam_ip datasource](../data-sources/ipam_ip#instance-private-network-ip) instead). +- `private_ip` - The Scaleway internal IP address of the server (Deprecated use [ipam_ip datasource](../data-sources/ipam_ip.md#instance-private-network-ip) instead). - `public_ip` - The public IP address of the server (Deprecated use `public_ips` instead). - `public_ips` - The list of public IPs of the server. - `id` - The ID of the IP From ebc7645f1cedbd971991926a1cbc5847bc0fecf3 Mon Sep 17 00:00:00 2001 From: Jules Casteran Date: Mon, 16 Dec 2024 17:41:21 +0100 Subject: [PATCH 3/3] add deprecation notice in schema --- internal/services/instance/server.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/services/instance/server.go b/internal/services/instance/server.go index 4a41539bfd..ea6a8b05bc 100644 --- a/internal/services/instance/server.go +++ b/internal/services/instance/server.go @@ -189,6 +189,7 @@ func ResourceServer() *schema.Resource { Type: schema.TypeString, Computed: true, Description: "The Scaleway internal IP address of the server", + Deprecated: "Use ipam_ip datasource instead to fetch your server's IP in your private network.", }, "public_ip": { Type: schema.TypeString,