-
Notifications
You must be signed in to change notification settings - Fork 133
feat(iam): creation of user as Member #3029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @giacomosirri and thank you for this PR. The guest type will disappear in the next months, and the fields you mentioned that cannot be updated will be updatable in very soon too. However, I would like to thank you for your contribution. Can you give me your Organization-id (here or on Slack Scaleway community - Cyril Scw) so that I can put a voucher on your Organization? Thanks again |
|
Hello @crlptl, Anyway, the organization id is: daf36079-e52c-416c-9535-d06742e48acc. Btw, I also tried to access the slack community from the link in the footer of the website, but it appears to be broken: Thank you again. |
|
Hello @giacomosirri, after careful consideration it happens that your approach fits well the current API state and is future proof. |
cbafdfd to
9fcac44
Compare
Gnoale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, I made a few suggestion, feel free to tell me if you don't have time to work on this I would then make the changes myself
|
Hello @Gnoale, thank you for the update, that's good to hear! |
3282040 to
344f1e8
Compare
|
@Gnoale @remyleone hello, |
Gnoale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @giacomosirri thanks for you work, I made another review pass, it is almost good I think
I suggest we remove the ForceNew flag from the "email" field and return an error in case of a guest email update attempt.
Since guest will be deprecated
We could add a hint about this behavior in the documentation too
What do you think @remyleone @crlptl
344f1e8 to
cb2d847
Compare
|
@Gnoale @remyleone hello, |
Gnoale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !

This Pull Request implements the feature requested in the issue #3021