Skip to content

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Jul 16, 2025

close #2764

@jremy42 jremy42 requested review from a team and remyleone as code owners July 16, 2025 12:37
@github-actions github-actions bot added the domain Domains issues, bugs and feature requests label Jul 16, 2025
@remyleone remyleone changed the title fix(domaim): remove keep empty zone fix(domain): remove keep empty zone Jul 16, 2025
@remyleone remyleone enabled auto-merge July 16, 2025 13:15
@jremy42 jremy42 force-pushed the fix/remove_keep_empty_zone branch from 85818f8 to c26e20c Compare July 16, 2025 14:01
@remyleone remyleone added this pull request to the merge queue Jul 16, 2025
Merged via the queue into master with commit 209bb81 Jul 16, 2025
51 checks passed
@remyleone remyleone deleted the fix/remove_keep_empty_zone branch July 16, 2025 14:10
@ndrpnt
Copy link
Contributor

ndrpnt commented Jul 26, 2025

Sorry to comment on a closed PR; doesn't this PR does exactly the opposite of what the issue was asking for ? I.e. it always delete an empty zone, instead of never deleting it.

Laure-di pushed a commit to Laure-di/terraform-provider-scaleway that referenced this pull request Jul 28, 2025
@remyleone
Copy link
Member

@ndrpnt sorry for the inconvenience it will be fixed with #3234

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain Domains issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

domain_record: remove keep_empty_zone

4 participants