diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index 88ca10f07f..dd6f5401f0 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -7,6 +7,7 @@ jobs: permissions: contents: read pull-requests: write + issues: write runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.golangci.yml b/.golangci.yml index 73b111f115..2babc2e93e 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -88,7 +88,7 @@ linters: - usetesting # Reports uses of functions with replacement inside the testing package. [auto-fix] - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false] - whitespace # Tool for detection of leading and trailing whitespace [fast: true, auto-fix: true] - - wsl # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false] + - wsl_v5 # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false] - zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false] disable: @@ -141,6 +141,11 @@ linters: reject: - anon + wsl_v5: + allow-first-in-block: true + allow-whole-block: false + branch-max-lines: 2 + exclusions: rules: - path: _test\.go diff --git a/internal/services/account/project_test.go b/internal/services/account/project_test.go index 76d8ef382d..0b7fb4edef 100644 --- a/internal/services/account/project_test.go +++ b/internal/services/account/project_test.go @@ -15,6 +15,7 @@ import ( func TestAccProject_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: isProjectDestroyed(tt), @@ -52,6 +53,7 @@ func TestAccProject_Basic(t *testing.T) { func TestAccProject_NoUpdate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: isProjectDestroyed(tt), diff --git a/internal/services/applesilicon/server_test.go b/internal/services/applesilicon/server_test.go index 65c135b600..8cfc91d718 100644 --- a/internal/services/applesilicon/server_test.go +++ b/internal/services/applesilicon/server_test.go @@ -15,6 +15,7 @@ import ( func TestAccServer_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -67,6 +68,7 @@ func TestAccServer_Basic(t *testing.T) { func TestAccServer_EnableDisabledVPC(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -121,6 +123,7 @@ func TestAccServer_EnableDisabledVPC(t *testing.T) { func TestAccServer_EnableVPC(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -265,6 +268,7 @@ func TestAccServer_Commitment(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/autoscaling/instance_group_test.go b/internal/services/autoscaling/instance_group_test.go index e348755959..7374282d03 100644 --- a/internal/services/autoscaling/instance_group_test.go +++ b/internal/services/autoscaling/instance_group_test.go @@ -154,7 +154,6 @@ func testAccCheckInstanceGroupDestroy(tt *acctest.TestTools) resource.TestCheckF InstanceGroupID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("autoscaling instance group (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/autoscaling/instance_policy_test.go b/internal/services/autoscaling/instance_policy_test.go index b469b42377..b53a4c5cf7 100644 --- a/internal/services/autoscaling/instance_policy_test.go +++ b/internal/services/autoscaling/instance_policy_test.go @@ -170,7 +170,6 @@ func testAccCheckInstancePolicyDestroy(tt *acctest.TestTools) resource.TestCheck PolicyID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("autoscaling instance policy (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/autoscaling/instance_template_test.go b/internal/services/autoscaling/instance_template_test.go index bc94ef0089..ced40e3472 100644 --- a/internal/services/autoscaling/instance_template_test.go +++ b/internal/services/autoscaling/instance_template_test.go @@ -166,7 +166,6 @@ func testAccCheckInstanceTemplateDestroy(tt *acctest.TestTools) resource.TestChe TemplateID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("autoscaling instance template (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/az/availability_zones_data_source_test.go b/internal/services/az/availability_zones_data_source_test.go index 3529d87cbf..b4d3edd406 100644 --- a/internal/services/az/availability_zones_data_source_test.go +++ b/internal/services/az/availability_zones_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceAvailabilityZones_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/baremetal/server.go b/internal/services/baremetal/server.go index 0d89d529a4..ac572a37a2 100644 --- a/internal/services/baremetal/server.go +++ b/internal/services/baremetal/server.go @@ -606,6 +606,7 @@ func ResourceServerUpdate(ctx context.Context, d *schema.ResourceData, m any) di } var serverGetOptionIDs []*baremetal.ServerOption + serverGetOptionIDs = append(serverGetOptionIDs, server.Options...) if d.HasChange("offer") { diff --git a/internal/services/block/snapshot_data_source_test.go b/internal/services/block/snapshot_data_source_test.go index 0973a237f7..04259da6c2 100644 --- a/internal/services/block/snapshot_data_source_test.go +++ b/internal/services/block/snapshot_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceSnapshot_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/block/testfuncs/checks.go b/internal/services/block/testfuncs/checks.go index 2802f58518..124ed3c6e6 100644 --- a/internal/services/block/testfuncs/checks.go +++ b/internal/services/block/testfuncs/checks.go @@ -75,7 +75,6 @@ func IsVolumeDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { VolumeID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("block volume (%s) still exists", rs.Primary.ID) } @@ -105,7 +104,6 @@ func IsSnapshotDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { SnapshotID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("block snapshot (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/block/volume_data_source_test.go b/internal/services/block/volume_data_source_test.go index 20159dfc48..5a65c6a1a8 100644 --- a/internal/services/block/volume_data_source_test.go +++ b/internal/services/block/volume_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceVolume_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/cockpit/source_test.go b/internal/services/cockpit/source_test.go index 52aa6de266..65ed838979 100644 --- a/internal/services/cockpit/source_test.go +++ b/internal/services/cockpit/source_test.go @@ -245,7 +245,6 @@ func isSourceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { Region: region, DataSourceID: ID, }) - if err == nil { return fmt.Errorf("cockpit source (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/container/container_data_source_test.go b/internal/services/container/container_data_source_test.go index f57b0b02a7..0187ef4fcc 100644 --- a/internal/services/container/container_data_source_test.go +++ b/internal/services/container/container_data_source_test.go @@ -91,6 +91,7 @@ func TestAccDataSourceContainer_HealthCheck(t *testing.T) { func TestAccDataSourceContainer_ScalingOption(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/container/container_test.go b/internal/services/container/container_test.go index a4fb62c411..24d00b8bca 100644 --- a/internal/services/container/container_test.go +++ b/internal/services/container/container_test.go @@ -18,6 +18,7 @@ import ( func TestAccContainer_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -135,6 +136,7 @@ func TestAccContainer_Basic(t *testing.T) { func TestAccContainer_Env(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -278,6 +280,7 @@ func TestAccContainer_WithIMG(t *testing.T) { func TestAccContainer_HTTPOption(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -334,6 +337,7 @@ func TestAccContainer_HTTPOption(t *testing.T) { func TestAccContainer_Sandbox(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -404,6 +408,7 @@ func TestAccContainer_Sandbox(t *testing.T) { func TestAccContainer_HealthCheck(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -458,6 +463,7 @@ func TestAccContainer_HealthCheck(t *testing.T) { func TestAccContainer_ScalingOption(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -547,6 +553,7 @@ func TestAccContainer_ScalingOption(t *testing.T) { func TestAccContainer_CommandAndArgs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -629,6 +636,7 @@ func TestAccContainer_CommandAndArgs(t *testing.T) { func TestAccContainer_PrivateNetwork(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -797,7 +805,6 @@ func isContainerDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { ContainerID: id, Region: region, }) - if err == nil { return fmt.Errorf("container (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/container/cron_test.go b/internal/services/container/cron_test.go index cb87dff934..0e3639a45d 100644 --- a/internal/services/container/cron_test.go +++ b/internal/services/container/cron_test.go @@ -182,7 +182,6 @@ func isCronDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { CronID: id, Region: region, }) - if err == nil { return fmt.Errorf("containerSDK cron (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/container/namespace_test.go b/internal/services/container/namespace_test.go index ff09b2fdbf..65837a6cf0 100644 --- a/internal/services/container/namespace_test.go +++ b/internal/services/container/namespace_test.go @@ -364,7 +364,6 @@ func isNamespaceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NamespaceID: id, Region: region, }) - if err == nil { return fmt.Errorf("container namespace (%s) still exists", rs.Primary.ID) } @@ -394,7 +393,6 @@ func isRegistryDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NamespaceID: rs.Primary.Attributes["registry_namespace_id"], Region: region, }) - if err == nil { return fmt.Errorf("registry namespace (%s) still exists", rs.Primary.Attributes["registry_namespace_id"]) } diff --git a/internal/services/container/token_test.go b/internal/services/container/token_test.go index e45bd24c59..609b14c2d7 100644 --- a/internal/services/container/token_test.go +++ b/internal/services/container/token_test.go @@ -101,7 +101,6 @@ func isTokenDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { TokenID: id, Region: region, }) - if err == nil { return fmt.Errorf("container token (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/container/trigger_test.go b/internal/services/container/trigger_test.go index c86bf31f4c..ba453aa04b 100644 --- a/internal/services/container/trigger_test.go +++ b/internal/services/container/trigger_test.go @@ -198,7 +198,6 @@ func isTriggerDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { TriggerID: id, Region: region, }) - if err == nil { return fmt.Errorf("container trigger (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/domain/record_data_source_test.go b/internal/services/domain/record_data_source_test.go index 78270ecd2a..f000364db7 100644 --- a/internal/services/domain/record_data_source_test.go +++ b/internal/services/domain/record_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceDomainRecord_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/domain/registration_test.go b/internal/services/domain/registration_test.go index e4fb083c90..1cac16dd35 100644 --- a/internal/services/domain/registration_test.go +++ b/internal/services/domain/registration_test.go @@ -191,7 +191,6 @@ func testAccCheckDomainStatus(tt *acctest.TestTools, expectedAutoRenew, expected domainResp, getErr := registrarAPI.GetDomain(&domainSDK.RegistrarAPIGetDomainRequest{ Domain: domainName, }) - if getErr != nil { return fmt.Errorf("failed to get details for domain %s: %w", domainName, getErr) } diff --git a/internal/services/edgeservices/backend_stage_test.go b/internal/services/edgeservices/backend_stage_test.go index dd915a1738..843844ceba 100644 --- a/internal/services/edgeservices/backend_stage_test.go +++ b/internal/services/edgeservices/backend_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesBackend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -57,6 +58,7 @@ func TestAccEdgeServicesBackend_Basic(t *testing.T) { func TestAccEdgeServicesBackend_LB(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/cache_stage_test.go b/internal/services/edgeservices/cache_stage_test.go index 2160188f76..0dd0edec73 100644 --- a/internal/services/edgeservices/cache_stage_test.go +++ b/internal/services/edgeservices/cache_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesCache_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/dns_stage_test.go b/internal/services/edgeservices/dns_stage_test.go index ecddf90208..093888083e 100644 --- a/internal/services/edgeservices/dns_stage_test.go +++ b/internal/services/edgeservices/dns_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesDNS_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/pipeline_test.go b/internal/services/edgeservices/pipeline_test.go index e0c77a9c8e..88c954bb09 100644 --- a/internal/services/edgeservices/pipeline_test.go +++ b/internal/services/edgeservices/pipeline_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesPipeline_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/plan_test.go b/internal/services/edgeservices/plan_test.go index 4e026be888..7b3196f84a 100644 --- a/internal/services/edgeservices/plan_test.go +++ b/internal/services/edgeservices/plan_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesPlan_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/route_stage_test.go b/internal/services/edgeservices/route_stage_test.go index b16158c4aa..c8eb8d1d1b 100644 --- a/internal/services/edgeservices/route_stage_test.go +++ b/internal/services/edgeservices/route_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesRoute_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/tls_stage_test.go b/internal/services/edgeservices/tls_stage_test.go index 31c1c402ba..e0ec426175 100644 --- a/internal/services/edgeservices/tls_stage_test.go +++ b/internal/services/edgeservices/tls_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesTLS_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/waf_stage_test.go b/internal/services/edgeservices/waf_stage_test.go index f09284baad..f2e37a756f 100644 --- a/internal/services/edgeservices/waf_stage_test.go +++ b/internal/services/edgeservices/waf_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesWAF_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/file/testfuncs/checks.go b/internal/services/file/testfuncs/checks.go index 1c5c5ef754..a20f480c54 100644 --- a/internal/services/file/testfuncs/checks.go +++ b/internal/services/file/testfuncs/checks.go @@ -27,7 +27,6 @@ func CheckFileDestroy(tt *acctest.TestTools) resource.TestCheckFunc { Region: region, FilesystemID: id, }) - if err == nil { return fmt.Errorf("filesystem (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/flexibleip/data_source_flexible_ip_test.go b/internal/services/flexibleip/data_source_flexible_ip_test.go index b27f0ab55d..a60aa98b8f 100644 --- a/internal/services/flexibleip/data_source_flexible_ip_test.go +++ b/internal/services/flexibleip/data_source_flexible_ip_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceFlexibleIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -47,6 +48,7 @@ func TestAccDataSourceFlexibleIP_Basic(t *testing.T) { func TestAccDataSourceFlexibleIP_Multiple(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/flexibleip/data_source_flexible_ips_test.go b/internal/services/flexibleip/data_source_flexible_ips_test.go index b56918af7c..704b461b0f 100644 --- a/internal/services/flexibleip/data_source_flexible_ips_test.go +++ b/internal/services/flexibleip/data_source_flexible_ips_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceFlexibleIPs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -60,6 +61,7 @@ func TestAccDataSourceFlexibleIPs_Basic(t *testing.T) { func TestAccDataSourceFlexibleIPs_WithBaremetalIDs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/flexibleip/ip_test.go b/internal/services/flexibleip/ip_test.go index dd7e20368b..80728aa20e 100644 --- a/internal/services/flexibleip/ip_test.go +++ b/internal/services/flexibleip/ip_test.go @@ -22,6 +22,7 @@ const SSHKeyFlexibleIP = "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIM7HUxRyQtB2rnlhQU func TestAccFlexibleIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), @@ -47,6 +48,7 @@ func TestAccFlexibleIP_Basic(t *testing.T) { func TestAccFlexibleIP_WithZone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), @@ -78,6 +80,7 @@ func TestAccFlexibleIP_WithZone(t *testing.T) { func TestAccFlexibleIP_IPv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), diff --git a/internal/services/flexibleip/mac_address_test.go b/internal/services/flexibleip/mac_address_test.go index 1be5153651..bbfa5d3b09 100644 --- a/internal/services/flexibleip/mac_address_test.go +++ b/internal/services/flexibleip/mac_address_test.go @@ -16,6 +16,7 @@ import ( func TestAccFlexibleIPMACAddress_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), @@ -44,6 +45,7 @@ func TestAccFlexibleIPMACAddress_Basic(t *testing.T) { func TestAccFlexibleIPMACAddress_MoveToAnotherFlexibleIP(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), @@ -99,6 +101,7 @@ func TestAccFlexibleIPMACAddress_MoveToAnotherFlexibleIP(t *testing.T) { func TestAccFlexibleIPMACAddress_DuplicateOnOtherFlexibleIPs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( diff --git a/internal/services/function/cron_test.go b/internal/services/function/cron_test.go index a573ccd744..6e53b9461b 100644 --- a/internal/services/function/cron_test.go +++ b/internal/services/function/cron_test.go @@ -199,7 +199,6 @@ func testAccCheckFunctionCronDestroy(tt *acctest.TestTools) resource.TestCheckFu CronID: id, Region: region, }) - if err == nil { return fmt.Errorf("function cron (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/domain_test.go b/internal/services/function/domain_test.go index 57d76e49c0..1e09e555f1 100644 --- a/internal/services/function/domain_test.go +++ b/internal/services/function/domain_test.go @@ -100,7 +100,6 @@ func testAccCheckFunctionDomainDestroy(tt *acctest.TestTools) resource.TestCheck DomainID: id, Region: region, }) - if err == nil { return fmt.Errorf("function domain (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/function_test.go b/internal/services/function/function_test.go index 01bb95f9a1..95dc2cd664 100644 --- a/internal/services/function/function_test.go +++ b/internal/services/function/function_test.go @@ -414,6 +414,7 @@ func TestAccFunction_Sandbox(t *testing.T) { func TestAccFunction_PrivateNetwork(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -603,7 +604,6 @@ func testAccCheckFunctionDestroy(tt *acctest.TestTools) resource.TestCheckFunc { FunctionID: id, Region: region, }) - if err == nil { return fmt.Errorf("function (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/namespace_test.go b/internal/services/function/namespace_test.go index 9358be7e8e..63342f77b6 100644 --- a/internal/services/function/namespace_test.go +++ b/internal/services/function/namespace_test.go @@ -284,7 +284,6 @@ func testAccCheckFunctionNamespaceDestroy(tt *acctest.TestTools) resource.TestCh NamespaceID: id, Region: region, }) - if err == nil { return fmt.Errorf("function namespace (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/token_test.go b/internal/services/function/token_test.go index 46d9b15fd0..599612a9c3 100644 --- a/internal/services/function/token_test.go +++ b/internal/services/function/token_test.go @@ -104,7 +104,6 @@ func testAccCheckFunctionTokenDestroy(tt *acctest.TestTools) resource.TestCheckF TokenID: id, Region: region, }) - if err == nil { return fmt.Errorf("function token (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/trigger_test.go b/internal/services/function/trigger_test.go index 4e74759849..c09eb28364 100644 --- a/internal/services/function/trigger_test.go +++ b/internal/services/function/trigger_test.go @@ -260,7 +260,6 @@ func testAccCheckFunctionTriggerDestroy(tt *acctest.TestTools) resource.TestChec TriggerID: id, Region: region, }) - if err == nil { return fmt.Errorf("function trigger (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/iam/api_key_test.go b/internal/services/iam/api_key_test.go index fe1f6b9206..394c0faf3d 100644 --- a/internal/services/iam/api_key_test.go +++ b/internal/services/iam/api_key_test.go @@ -15,6 +15,7 @@ import ( func TestAccApiKey_WithApplication(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( @@ -71,6 +72,7 @@ func TestAccApiKey_WithApplication(t *testing.T) { func TestAccApiKey_WithApplicationChange(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( @@ -135,6 +137,7 @@ func TestAccApiKey_WithApplicationChange(t *testing.T) { func TestAccApiKey_Expires(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( diff --git a/internal/services/iam/application_data_source_test.go b/internal/services/iam/application_data_source_test.go index f8e1b0e1a2..89e1d7c62a 100644 --- a/internal/services/iam/application_data_source_test.go +++ b/internal/services/iam/application_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceApplication_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/application_test.go b/internal/services/iam/application_test.go index 82d66103c0..2f6a5a7455 100644 --- a/internal/services/iam/application_test.go +++ b/internal/services/iam/application_test.go @@ -15,6 +15,7 @@ import ( func TestAccApplication_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckIamApplicationDestroy(tt), diff --git a/internal/services/iam/group_data_source_test.go b/internal/services/iam/group_data_source_test.go index 734c4713db..0807871136 100644 --- a/internal/services/iam/group_data_source_test.go +++ b/internal/services/iam/group_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceGroup_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -47,6 +48,7 @@ func TestAccDataSourceGroup_Basic(t *testing.T) { func TestAccDataSourceGroup_UsersAndApplications(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/group_test.go b/internal/services/iam/group_test.go index 377f704088..082cb9de5f 100644 --- a/internal/services/iam/group_test.go +++ b/internal/services/iam/group_test.go @@ -15,6 +15,7 @@ import ( func TestAccGroup_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckIamGroupDestroy(tt), @@ -102,6 +103,7 @@ func TestAccGroup_Basic(t *testing.T) { func TestAccGroup_Applications(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( @@ -200,6 +202,7 @@ func TestAccGroup_Applications(t *testing.T) { func TestAccGroup_Users(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( @@ -291,6 +294,7 @@ func TestAccGroup_Users(t *testing.T) { func TestAccGroup_UsersAndApplications(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( diff --git a/internal/services/iam/ssh_key_account_data_source_test.go b/internal/services/iam/ssh_key_account_data_source_test.go index 9daf8b484e..d782973d2d 100644 --- a/internal/services/iam/ssh_key_account_data_source_test.go +++ b/internal/services/iam/ssh_key_account_data_source_test.go @@ -16,6 +16,7 @@ func TestAccDataSourceAccountSSHKey_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/ssh_key_data_source_test.go b/internal/services/iam/ssh_key_data_source_test.go index 51d5269bdf..34ffe0ce65 100644 --- a/internal/services/iam/ssh_key_data_source_test.go +++ b/internal/services/iam/ssh_key_data_source_test.go @@ -16,6 +16,7 @@ func TestAccDataSourceSSHKey_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/user_data_source_test.go b/internal/services/iam/user_data_source_test.go index c664f385d1..a64e94a955 100644 --- a/internal/services/iam/user_data_source_test.go +++ b/internal/services/iam/user_data_source_test.go @@ -14,6 +14,7 @@ import ( func TestAccDataSourceUser_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/user_test.go b/internal/services/iam/user_test.go index 0f272488a5..22fa908114 100644 --- a/internal/services/iam/user_test.go +++ b/internal/services/iam/user_test.go @@ -15,6 +15,7 @@ import ( func TestAccUser_Member(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: isUserDestroyed(tt), diff --git a/internal/services/inference/testfuncs/checks.go b/internal/services/inference/testfuncs/checks.go index 5dc3000aa8..ad72024628 100644 --- a/internal/services/inference/testfuncs/checks.go +++ b/internal/services/inference/testfuncs/checks.go @@ -27,7 +27,6 @@ func IsDeploymentDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { Region: region, DeploymentID: ID, }) - if err == nil { return fmt.Errorf("deployment %s (%s) still exists", deployment.Name, deployment.ID) } @@ -57,7 +56,6 @@ func IsModelDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { Region: region, ModelID: id, }) - if err == nil { return fmt.Errorf("model %s (%s) still exists", model.Name, model.ID) } diff --git a/internal/services/instance/data_source_instance_private_nic_test.go b/internal/services/instance/data_source_instance_private_nic_test.go index bd44d375b4..6fd21fb9fb 100644 --- a/internal/services/instance/data_source_instance_private_nic_test.go +++ b/internal/services/instance/data_source_instance_private_nic_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourcePrivateNIC_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/image_data_source_test.go b/internal/services/instance/image_data_source_test.go index 86d90ea4d8..d7b28a959f 100644 --- a/internal/services/instance/image_data_source_test.go +++ b/internal/services/instance/image_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceImage_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/image_test.go b/internal/services/instance/image_test.go index 7138fb94af..98cbcb4471 100644 --- a/internal/services/instance/image_test.go +++ b/internal/services/instance/image_test.go @@ -20,6 +20,7 @@ func TestAccImage_BlockVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -116,6 +117,7 @@ func TestAccImage_BlockVolume(t *testing.T) { func TestAccImage_ExternalBlockVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -211,6 +213,7 @@ func TestAccImage_ExternalBlockVolume(t *testing.T) { func TestAccImage_Server(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -286,6 +289,7 @@ func TestAccImage_ServerWithBlockVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -438,6 +442,7 @@ func TestAccImage_ServerWithBlockVolume(t *testing.T) { func TestAccImage_ServerWithLocalVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -559,6 +564,7 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) { func TestAccImage_ServerWithSBSVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/ip_data_source_test.go b/internal/services/instance/ip_data_source_test.go index a8c16aa8ad..b2e3695bdb 100644 --- a/internal/services/instance/ip_data_source_test.go +++ b/internal/services/instance/ip_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/ip_test.go b/internal/services/instance/ip_test.go index 9d0aba049f..cd9fc7e2eb 100644 --- a/internal/services/instance/ip_test.go +++ b/internal/services/instance/ip_test.go @@ -17,6 +17,7 @@ import ( func TestAccIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: instancechecks.IsIPDestroyed(tt), @@ -38,6 +39,7 @@ func TestAccIP_Basic(t *testing.T) { func TestAccIP_WithZone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: instancechecks.IsIPDestroyed(tt), @@ -69,6 +71,7 @@ func TestAccIP_WithZone(t *testing.T) { func TestAccIP_Tags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: instancechecks.IsIPDestroyed(tt), diff --git a/internal/services/instance/placement_group_data_source_test.go b/internal/services/instance/placement_group_data_source_test.go index 582abbfac8..0cebb2cebc 100644 --- a/internal/services/instance/placement_group_data_source_test.go +++ b/internal/services/instance/placement_group_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourcePlacementGroup_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/placement_group_test.go b/internal/services/instance/placement_group_test.go index 17a8638fff..c46d2e08ce 100644 --- a/internal/services/instance/placement_group_test.go +++ b/internal/services/instance/placement_group_test.go @@ -16,6 +16,7 @@ import ( func TestAccPlacementGroup_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -62,6 +63,7 @@ func TestAccPlacementGroup_Basic(t *testing.T) { func TestAccPlacementGroup_Rename(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -104,6 +106,7 @@ func TestAccPlacementGroup_Rename(t *testing.T) { func TestAccPlacementGroup_Tags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: instancechecks.IsIPDestroyed(tt), diff --git a/internal/services/instance/private_nic_test.go b/internal/services/instance/private_nic_test.go index 4ec7b5ed5d..19c30cbb08 100644 --- a/internal/services/instance/private_nic_test.go +++ b/internal/services/instance/private_nic_test.go @@ -15,6 +15,7 @@ import ( func TestAccPrivateNIC_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -52,6 +53,7 @@ func TestAccPrivateNIC_Basic(t *testing.T) { func TestAccPrivateNIC_Tags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -140,6 +142,7 @@ func TestAccPrivateNIC_Tags(t *testing.T) { func TestAccPrivateNIC_WithIPAM(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -245,7 +248,6 @@ func isPrivateNICDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { PrivateNicID: innerID, Zone: zone, }) - if err == nil { return fmt.Errorf( "instanceSDK private NIC %s still exists", diff --git a/internal/services/instance/security_group_rules_test.go b/internal/services/instance/security_group_rules_test.go index 2719943c90..b1c8f0279a 100644 --- a/internal/services/instance/security_group_rules_test.go +++ b/internal/services/instance/security_group_rules_test.go @@ -10,6 +10,7 @@ import ( func TestAccSecurityGroupRules_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/security_group_test.go b/internal/services/instance/security_group_test.go index 9314dac897..6316adbac3 100644 --- a/internal/services/instance/security_group_test.go +++ b/internal/services/instance/security_group_test.go @@ -241,6 +241,7 @@ func TestAccSecurityGroup_ICMP(t *testing.T) { func TestAccSecurityGroup_ANY(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -382,6 +383,7 @@ func TestAccSecurityGroup_RemovePort(t *testing.T) { func TestAccSecurityGroup_WithPortRange(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -439,6 +441,7 @@ func TestAccSecurityGroup_WithPortRange(t *testing.T) { func TestAccSecurityGroup_Tags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -594,6 +597,7 @@ func isSecurityGroupDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { func TestAccSecurityGroup_EnableDefaultSecurity(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/server_test.go b/internal/services/instance/server_test.go index 7b3edb6e37..551fb87bbb 100644 --- a/internal/services/instance/server_test.go +++ b/internal/services/instance/server_test.go @@ -23,6 +23,7 @@ import ( func TestAccServer_Minimal1(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -79,6 +80,7 @@ func TestAccServer_Minimal1(t *testing.T) { func TestAccServer_Minimal2(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -202,6 +204,7 @@ func TestAccServer_RootVolume1(t *testing.T) { func TestAccServer_RootVolume_Boot(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -252,6 +255,7 @@ func TestAccServer_RootVolume_ID(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -288,6 +292,7 @@ func TestAccServer_RootVolume_ID(t *testing.T) { func TestAccServer_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -349,6 +354,7 @@ func TestAccServer_Basic(t *testing.T) { func TestAccServer_State1(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -418,6 +424,7 @@ func TestAccServer_State1(t *testing.T) { func TestAccServer_State2(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -468,6 +475,7 @@ func TestAccServer_State2(t *testing.T) { func TestAccServer_UserData_WithCloudInitAtStart(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -501,6 +509,7 @@ EOF func TestAccServer_UserData_WithoutCloudInitAtStart(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -554,6 +563,7 @@ func TestAccServer_AdditionalVolumes(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -632,6 +642,7 @@ func TestAccServer_AdditionalVolumesDetach(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -699,6 +710,7 @@ func TestAccServer_AdditionalVolumesDetach(t *testing.T) { func TestAccServer_WithPlacementGroup(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -739,6 +751,7 @@ func TestAccServer_WithPlacementGroup(t *testing.T) { func TestAccServer_Ipv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -783,6 +796,7 @@ func TestAccServer_Ipv6(t *testing.T) { func TestAccServer_Basic2(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -813,6 +827,7 @@ func TestAccServer_Basic2(t *testing.T) { func TestAccServer_WithReservedIP(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -979,6 +994,7 @@ func serverHasNewVolume(_ *acctest.TestTools, n string) resource.TestCheckFunc { func TestAccServer_AlterTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1022,6 +1038,7 @@ func TestAccServer_WithDefaultRootVolumeAndAdditionalVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1056,6 +1073,7 @@ func TestAccServer_ServerWithBlockNonDefaultZone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1092,6 +1110,7 @@ func TestAccServer_ServerWithBlockNonDefaultZone(t *testing.T) { func TestAccServer_PrivateNetwork(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1246,6 +1265,7 @@ func TestAccServer_PrivateNetwork(t *testing.T) { func TestAccServer_Migrate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1294,6 +1314,7 @@ func TestAccServer_Migrate(t *testing.T) { func TestAccServer_MigrateInvalidLocalVolumeSize(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1336,6 +1357,7 @@ func TestAccServer_MigrateInvalidLocalVolumeSize(t *testing.T) { func TestAccServer_CustomDiffImage(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1490,6 +1512,7 @@ func serverIDsAreDifferent(nameFirst, nameSecond string) resource.TestCheckFunc func TestAccServer_IPs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1574,6 +1597,7 @@ func TestAccServer_IPs(t *testing.T) { func TestAccServer_IPRemoved(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1620,6 +1644,7 @@ func TestAccServer_IPRemoved(t *testing.T) { func TestAccServer_IPsRemoved(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1669,6 +1694,7 @@ func TestAccServer_IPsRemoved(t *testing.T) { func TestAccServer_BlockExternal(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1817,6 +1843,7 @@ func TestAccServer_BlockExternalRootVolume(t *testing.T) { func TestAccServer_BlockExternalRootVolumeUpdate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1869,6 +1896,7 @@ func TestAccServer_BlockExternalRootVolumeUpdate(t *testing.T) { func TestAccServer_RootVolumeFromExternalSnapshot(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1944,6 +1972,7 @@ func TestAccServer_RootVolumeFromExternalSnapshot(t *testing.T) { func TestAccServer_PrivateNetworkMissingPNIC(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -2178,6 +2207,7 @@ func TestAccServer_AdminPasswordEncryptionSSHKeyID(t *testing.T) { func TestGetEndOfServiceDate(t *testing.T) { tt := acctest.NewTestTools(t) + client := meta.ExtractScwClient(tt.Meta) defer tt.Cleanup() diff --git a/internal/services/instance/servers_data_source_test.go b/internal/services/instance/servers_data_source_test.go index 65d9723e23..fba22a4671 100644 --- a/internal/services/instance/servers_data_source_test.go +++ b/internal/services/instance/servers_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceServers_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -92,6 +93,7 @@ func TestAccDataSourceServers_Basic(t *testing.T) { func TestAccDataSourceServers_PrivateIPs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/snapshot_test.go b/internal/services/instance/snapshot_test.go index d1cdb7d3f8..c098a27503 100644 --- a/internal/services/instance/snapshot_test.go +++ b/internal/services/instance/snapshot_test.go @@ -18,6 +18,7 @@ import ( func TestAccSnapshot_Server(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/user_data_test.go b/internal/services/instance/user_data_test.go index d51d84a88d..144ff56d34 100644 --- a/internal/services/instance/user_data_test.go +++ b/internal/services/instance/user_data_test.go @@ -11,6 +11,7 @@ import ( func TestAccServerUserData_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/volume_test.go b/internal/services/instance/volume_test.go index ae5c37292d..d9b3443292 100644 --- a/internal/services/instance/volume_test.go +++ b/internal/services/instance/volume_test.go @@ -12,6 +12,7 @@ import ( func TestAccVolume_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -53,6 +54,7 @@ func TestAccVolume_Basic(t *testing.T) { func TestAccVolume_DifferentNameGenerated(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -83,6 +85,7 @@ func TestAccVolume_ResizeBlock(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -117,6 +120,7 @@ func TestAccVolume_ResizeBlock(t *testing.T) { func TestAccVolume_ResizeNotBlock(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -150,6 +154,7 @@ func TestAccVolume_CannotResizeBlockDown(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -177,6 +182,7 @@ func TestAccVolume_CannotResizeBlockDown(t *testing.T) { func TestAccVolume_Scratch(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/data_source_iot_device_test.go b/internal/services/iot/data_source_iot_device_test.go index b7f97b864b..d483614d55 100644 --- a/internal/services/iot/data_source_iot_device_test.go +++ b/internal/services/iot/data_source_iot_device_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceDevice_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/data_source_iot_hub_test.go b/internal/services/iot/data_source_iot_hub_test.go index dcd541677b..3072529760 100644 --- a/internal/services/iot/data_source_iot_hub_test.go +++ b/internal/services/iot/data_source_iot_hub_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceHub_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/device_test.go b/internal/services/iot/device_test.go index 8ffcf96aa8..b65e6d54dc 100644 --- a/internal/services/iot/device_test.go +++ b/internal/services/iot/device_test.go @@ -38,6 +38,7 @@ WuePu1khrEuTaXKyaiLD3pmxM86F/6Ho6V86mJpKXr/wmMU56TcKk9UURucVQZ1o func TestAccDevice_Minimal(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -73,6 +74,7 @@ func TestAccDevice_MessageFilters(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -129,6 +131,7 @@ func TestAccDevice_MessageFilters(t *testing.T) { func TestAccDevice_AllowInsecure(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -184,6 +187,7 @@ func TestAccDevice_AllowInsecure(t *testing.T) { func TestAccDevice_Certificate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/helpers_iot.go b/internal/services/iot/helpers_iot.go index ccc407c2e8..08f6c75c63 100644 --- a/internal/services/iot/helpers_iot.go +++ b/internal/services/iot/helpers_iot.go @@ -88,6 +88,7 @@ func computeIotHubMQTTCa(ctx context.Context, mqttCaURL string, m any) (string, } defer mqttCa.Body.Close() //nolint: errcheck + resp, _ := io.ReadAll(mqttCa.Body) return string(resp), nil diff --git a/internal/services/iot/hub_test.go b/internal/services/iot/hub_test.go index 46d9f7ac64..0ac38faca2 100644 --- a/internal/services/iot/hub_test.go +++ b/internal/services/iot/hub_test.go @@ -15,6 +15,7 @@ import ( func TestAccHub_Minimal(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -64,6 +65,7 @@ func TestAccHub_Minimal(t *testing.T) { func TestAccHub_Dedicated(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/network_test.go b/internal/services/iot/network_test.go index ae71dff20c..3a9cdea88b 100644 --- a/internal/services/iot/network_test.go +++ b/internal/services/iot/network_test.go @@ -14,6 +14,7 @@ import ( func TestAccNetwork_Minimal(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -52,6 +53,7 @@ func TestAccNetwork_Minimal(t *testing.T) { func TestAccNetwork_RESTWithTopicPrefix(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -92,6 +94,7 @@ func TestAccNetwork_RESTWithTopicPrefix(t *testing.T) { func TestAccNetwork_Sigfox(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/routes_test.go b/internal/services/iot/routes_test.go index c1542f9fc4..d614de3f29 100644 --- a/internal/services/iot/routes_test.go +++ b/internal/services/iot/routes_test.go @@ -145,6 +145,7 @@ func TestAccRoute_S3(t *testing.T) { func TestAccRoute_REST(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/ipam/ip_data_source_test.go b/internal/services/ipam/ip_data_source_test.go index dca138e165..602a3243df 100644 --- a/internal/services/ipam/ip_data_source_test.go +++ b/internal/services/ipam/ip_data_source_test.go @@ -14,6 +14,7 @@ import ( func TestAccDataSourceIPAMIP_Instance(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -67,6 +68,7 @@ func TestAccDataSourceIPAMIP_Instance(t *testing.T) { func TestAccDataSourceIPAMIP_InstanceLB(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -182,6 +184,7 @@ func TestAccDataSourceIPAMIP_RDB(t *testing.T) { func TestAccDataSourceIPAMIP_ID(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/ipam/ip_test.go b/internal/services/ipam/ip_test.go index 29147b1324..d516896efb 100644 --- a/internal/services/ipam/ip_test.go +++ b/internal/services/ipam/ip_test.go @@ -15,6 +15,7 @@ import ( func TestAccIPAMIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -56,6 +57,7 @@ func TestAccIPAMIP_Basic(t *testing.T) { func TestAccIPAMIP_WithStandaloneAddress(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -93,6 +95,7 @@ func TestAccIPAMIP_WithStandaloneAddress(t *testing.T) { func TestAccIPAMIP_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -160,6 +163,7 @@ func TestAccIPAMIP_WithTags(t *testing.T) { func TestAccIPAMIP_WithCustomResource(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/ipam/ips_data_source_test.go b/internal/services/ipam/ips_data_source_test.go index bc11aacf4a..ab64538f93 100644 --- a/internal/services/ipam/ips_data_source_test.go +++ b/internal/services/ipam/ips_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceIPAMIPs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -96,6 +97,7 @@ func TestAccDataSourceIPAMIPs_Basic(t *testing.T) { func TestAccDataSourceIPAMIPs_RedisCluster(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/ipam/testfuncs/checks.go b/internal/services/ipam/testfuncs/checks.go index b5af5da644..e9cae883b9 100644 --- a/internal/services/ipam/testfuncs/checks.go +++ b/internal/services/ipam/testfuncs/checks.go @@ -27,7 +27,6 @@ func CheckIPDestroy(tt *acctest.TestTools) resource.TestCheckFunc { IPID: ID, Region: region, }) - if err == nil { return fmt.Errorf("IP (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/jobs/jobs_test.go b/internal/services/jobs/jobs_test.go index 50b9182efc..43877deea8 100644 --- a/internal/services/jobs/jobs_test.go +++ b/internal/services/jobs/jobs_test.go @@ -168,6 +168,7 @@ func TestAccJobDefinition_Cron(t *testing.T) { func TestAccJobDefinition_SecretReference(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -382,7 +383,6 @@ func testAccCheckJobDefinitionDestroy(tt *acctest.TestTools) resource.TestCheckF JobDefinitionID: id, Region: region, }) - if err == nil { return fmt.Errorf("jobs jobdefinition (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/k8s/pool_test.go b/internal/services/k8s/pool_test.go index 04ebbdeb69..f88b405ae3 100644 --- a/internal/services/k8s/pool_test.go +++ b/internal/services/k8s/pool_test.go @@ -96,6 +96,7 @@ func TestAccPool_Basic(t *testing.T) { func TestAccPool_Wait(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestK8SVersion := testAccK8SClusterGetLatestK8SVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, diff --git a/internal/services/lb/acl_test.go b/internal/services/lb/acl_test.go index 2c62e774b7..d36fa4342e 100644 --- a/internal/services/lb/acl_test.go +++ b/internal/services/lb/acl_test.go @@ -15,6 +15,7 @@ import ( func TestAccAcl_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/acls_data_source_test.go b/internal/services/lb/acls_data_source_test.go index ce88d3c273..df407d7823 100644 --- a/internal/services/lb/acls_data_source_test.go +++ b/internal/services/lb/acls_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceACLs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/backend_data_source_test.go b/internal/services/lb/backend_data_source_test.go index cf2858c791..578fbe53d4 100644 --- a/internal/services/lb/backend_data_source_test.go +++ b/internal/services/lb/backend_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceBackend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/backend_test.go b/internal/services/lb/backend_test.go index 48a6e5bcb4..c0d2330c85 100644 --- a/internal/services/lb/backend_test.go +++ b/internal/services/lb/backend_test.go @@ -17,6 +17,7 @@ import ( func TestAccBackend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -134,6 +135,7 @@ func TestAccBackend_Basic(t *testing.T) { func TestAccBackend_HealthCheck(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -239,6 +241,7 @@ func TestAccBackend_WithFailoverHost(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -385,6 +388,7 @@ func TestAccBackend_WithFailoverHost(t *testing.T) { func TestAccBackend_HealthCheck_Port(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/backends_data_source_test.go b/internal/services/lb/backends_data_source_test.go index fea0bd01a8..80a39b6e43 100644 --- a/internal/services/lb/backends_data_source_test.go +++ b/internal/services/lb/backends_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceBackends_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/certificate_data_source_test.go b/internal/services/lb/certificate_data_source_test.go index bcba101099..2747c6cec7 100644 --- a/internal/services/lb/certificate_data_source_test.go +++ b/internal/services/lb/certificate_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceCertificate_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/certificate_test.go b/internal/services/lb/certificate_test.go index d15e8cdf93..64a3ff12f3 100644 --- a/internal/services/lb/certificate_test.go +++ b/internal/services/lb/certificate_test.go @@ -23,6 +23,7 @@ func TestAccCertificate_Basic(t *testing.T) { */ tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/data_source_lb_frontends_test.go b/internal/services/lb/data_source_lb_frontends_test.go index 25e1ef345d..92b5ee5e66 100644 --- a/internal/services/lb/data_source_lb_frontends_test.go +++ b/internal/services/lb/data_source_lb_frontends_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceFrontends_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/data_source_lb_ip_test.go b/internal/services/lb/data_source_lb_ip_test.go index 86e6e80433..b01358936f 100644 --- a/internal/services/lb/data_source_lb_ip_test.go +++ b/internal/services/lb/data_source_lb_ip_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/frontend_data_source_test.go b/internal/services/lb/frontend_data_source_test.go index 35352fc203..7c745d5e93 100644 --- a/internal/services/lb/frontend_data_source_test.go +++ b/internal/services/lb/frontend_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceFrontend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/frontend_test.go b/internal/services/lb/frontend_test.go index 24b3a59cc7..77d5003ff6 100644 --- a/internal/services/lb/frontend_test.go +++ b/internal/services/lb/frontend_test.go @@ -20,6 +20,7 @@ import ( func TestAccFrontend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -248,6 +249,7 @@ func isFrontendDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { func TestAccFrontend_ACLBasic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -460,6 +462,7 @@ func TestAccFrontend_ACLBasic(t *testing.T) { func TestAccFrontend_ACLRedirectAction(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/ip_test.go b/internal/services/lb/ip_test.go index f3b5f5ad5d..d677ada58f 100644 --- a/internal/services/lb/ip_test.go +++ b/internal/services/lb/ip_test.go @@ -15,6 +15,7 @@ import ( func TestAccIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -82,6 +83,7 @@ func TestAccIP_Basic(t *testing.T) { func TestAccIP_IPv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -106,6 +108,7 @@ func TestAccIP_IPv6(t *testing.T) { func TestAccIP_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/ips_data_source_test.go b/internal/services/lb/ips_data_source_test.go index 4ee90575d6..011ed5ad12 100644 --- a/internal/services/lb/ips_data_source_test.go +++ b/internal/services/lb/ips_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceIPs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -55,6 +56,7 @@ func TestAccDataSourceIPs_Basic(t *testing.T) { func TestAccDataSourceIPs_WithType(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -115,6 +117,7 @@ func TestAccDataSourceIPs_WithType(t *testing.T) { func TestAccDataSourceIPs_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/lb_data_source_test.go b/internal/services/lb/lb_data_source_test.go index 69166b392b..7e2a6358e9 100644 --- a/internal/services/lb/lb_data_source_test.go +++ b/internal/services/lb/lb_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceLb_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/lb_test.go b/internal/services/lb/lb_test.go index 38ef3543fb..ec4286811f 100644 --- a/internal/services/lb/lb_test.go +++ b/internal/services/lb/lb_test.go @@ -19,6 +19,7 @@ import ( func TestAccLB_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -77,6 +78,7 @@ func TestAccLB_Basic(t *testing.T) { func TestAccLB_Private(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -132,6 +134,7 @@ func TestAccLB_Private(t *testing.T) { func TestAccLB_AssignedIPs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -163,6 +166,7 @@ func TestAccLB_AssignedIPs(t *testing.T) { func TestAccLB_WithIPv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -202,6 +206,7 @@ func TestAccLB_WithIPv6(t *testing.T) { func TestAccLB_UpdateToIPv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -361,6 +366,7 @@ func TestAccLB_Migrate(t *testing.T) { func TestAccLB_WithPrivateNetworksIPAMIDs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -429,6 +435,7 @@ func TestAccLB_WithPrivateNetworksIPAMIDs(t *testing.T) { func TestAccLB_WithoutPNConfig(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -470,6 +477,7 @@ func TestAccLB_WithoutPNConfig(t *testing.T) { func TestAccLB_DifferentLocalityIPID(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/lbs_data_source_test.go b/internal/services/lb/lbs_data_source_test.go index d33d2cfca0..444c692f46 100644 --- a/internal/services/lb/lbs_data_source_test.go +++ b/internal/services/lb/lbs_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceLbs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/route_data_source_test.go b/internal/services/lb/route_data_source_test.go index 23a6b180cc..68a13b7aca 100644 --- a/internal/services/lb/route_data_source_test.go +++ b/internal/services/lb/route_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceRoute_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/route_test.go b/internal/services/lb/route_test.go index 1742f46bea..2de3070c61 100644 --- a/internal/services/lb/route_test.go +++ b/internal/services/lb/route_test.go @@ -15,6 +15,7 @@ import ( func TestAccRoute_WithSNI(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -94,6 +95,7 @@ func TestAccRoute_WithSNI(t *testing.T) { func TestAccRoute_WithHostHeader(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -138,6 +140,7 @@ func TestAccRoute_WithHostHeader(t *testing.T) { func TestAccRoute_WithPathBegin(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/routes_data_source_test.go b/internal/services/lb/routes_data_source_test.go index f1dce735c8..fd92c6f1e8 100644 --- a/internal/services/lb/routes_data_source_test.go +++ b/internal/services/lb/routes_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceRoutes_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/marketplace/image_data_source_test.go b/internal/services/marketplace/image_data_source_test.go index 82f59b4015..f0f0388068 100644 --- a/internal/services/marketplace/image_data_source_test.go +++ b/internal/services/marketplace/image_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceMarketplaceImage_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -34,6 +35,7 @@ func TestAccDataSourceMarketplaceImage_Basic(t *testing.T) { func TestAccDataSourceMarketplaceImage_SBS(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/mnq/nats_account_test.go b/internal/services/mnq/nats_account_test.go index 04f5308fef..1a87da4c6a 100644 --- a/internal/services/mnq/nats_account_test.go +++ b/internal/services/mnq/nats_account_test.go @@ -82,7 +82,6 @@ func isNatsAccountDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NatsAccountID: id, Region: region, }) - if err == nil { return fmt.Errorf("mnq nats account (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/mnq/nats_credentials_test.go b/internal/services/mnq/nats_credentials_test.go index ff37d12a84..97ebfbc0fa 100644 --- a/internal/services/mnq/nats_credentials_test.go +++ b/internal/services/mnq/nats_credentials_test.go @@ -139,7 +139,6 @@ func isNatsCredentialsDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NatsCredentialsID: id, Region: region, }) - if err == nil { return fmt.Errorf("mnq nats credentials (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/mnq/sns_credentials_test.go b/internal/services/mnq/sns_credentials_test.go index 58ffdae455..b444cb4a96 100644 --- a/internal/services/mnq/sns_credentials_test.go +++ b/internal/services/mnq/sns_credentials_test.go @@ -142,7 +142,6 @@ func isSNSCredentialsDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { SnsCredentialsID: id, Region: region, }) - if err == nil { return fmt.Errorf("mnq sns credentials (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/mnq/sns_data_source_test.go b/internal/services/mnq/sns_data_source_test.go index 7e5c29c2dc..f02fef98d9 100644 --- a/internal/services/mnq/sns_data_source_test.go +++ b/internal/services/mnq/sns_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceSNS_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/mnq/sqs_credentials_test.go b/internal/services/mnq/sqs_credentials_test.go index 183ab07d36..fba48c90a1 100644 --- a/internal/services/mnq/sqs_credentials_test.go +++ b/internal/services/mnq/sqs_credentials_test.go @@ -142,7 +142,6 @@ func isSQSCredentialsDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { SqsCredentialsID: id, Region: region, }) - if err == nil { return fmt.Errorf("mnq sqs credentials (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/mnq/sqs_data_source_test.go b/internal/services/mnq/sqs_data_source_test.go index 01c020c6aa..0dff84d7e8 100644 --- a/internal/services/mnq/sqs_data_source_test.go +++ b/internal/services/mnq/sqs_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceSQS_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/mongodb/instance_test.go b/internal/services/mongodb/instance_test.go index 8704c90ee3..72c9c84c83 100644 --- a/internal/services/mongodb/instance_test.go +++ b/internal/services/mongodb/instance_test.go @@ -516,7 +516,6 @@ func IsInstanceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { InstanceID: ID, Region: extractRegion, }) - if err == nil { return fmt.Errorf("instance (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/rdb/snapshots_test.go b/internal/services/rdb/snapshots_test.go index 9af61ab4ce..771f57d46c 100644 --- a/internal/services/rdb/snapshots_test.go +++ b/internal/services/rdb/snapshots_test.go @@ -136,7 +136,6 @@ func IsSnapshotDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { SnapshotID: ID, Region: region, }) - if err == nil { return fmt.Errorf("snapshot (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/redis/cluster_data_source_test.go b/internal/services/redis/cluster_data_source_test.go index ee29e5ad65..e33594d929 100644 --- a/internal/services/redis/cluster_data_source_test.go +++ b/internal/services/redis/cluster_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceCluster_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, diff --git a/internal/services/redis/cluster_test.go b/internal/services/redis/cluster_test.go index a7e641c662..b9cd6aceae 100644 --- a/internal/services/redis/cluster_test.go +++ b/internal/services/redis/cluster_test.go @@ -88,6 +88,7 @@ func TestAccCluster_Basic(t *testing.T) { func TestAccCluster_Migrate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -151,6 +152,7 @@ func TestAccCluster_Migrate(t *testing.T) { func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) clusterID := "" resource.ParallelTest(t, resource.TestCase{ @@ -235,6 +237,7 @@ func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) { func TestAccCluster_ACL(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -311,6 +314,7 @@ func TestAccCluster_ACL(t *testing.T) { func TestAccCluster_Settings(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -387,6 +391,7 @@ func TestAccCluster_Endpoints_Standalone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -579,6 +584,7 @@ func TestAccCluster_Endpoints_Standalone(t *testing.T) { func TestAccCluster_Endpoints_ClusterMode(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -645,6 +651,7 @@ func TestAccCluster_Endpoints_ClusterMode(t *testing.T) { func TestAccCluster_Certificate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -686,6 +693,7 @@ func TestAccCluster_Certificate(t *testing.T) { func TestAccCluster_NoCertificate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -727,6 +735,7 @@ func TestAccCluster_NoCertificate(t *testing.T) { func TestAccCluster_MigrateToHAMode(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ @@ -774,7 +783,6 @@ func isClusterDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { ClusterID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf("cluster (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/registry/namespace_test.go b/internal/services/registry/namespace_test.go index edc8ada39e..8880a12fef 100644 --- a/internal/services/registry/namespace_test.go +++ b/internal/services/registry/namespace_test.go @@ -94,7 +94,6 @@ func isNamespaceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NamespaceID: id, Region: region, }) - if err == nil { return fmt.Errorf("namespace (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/sdb/database_test.go b/internal/services/sdb/database_test.go index 0679736314..8ec4ef784d 100644 --- a/internal/services/sdb/database_test.go +++ b/internal/services/sdb/database_test.go @@ -123,7 +123,6 @@ func testAccCheckServerlessSQLDBDatabaseDestroy(tt *acctest.TestTools) resource. DatabaseID: id, Region: region, }) - if err == nil { return fmt.Errorf("serverless_sql database (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/secret/secret_test.go b/internal/services/secret/secret_test.go index 87abe676ec..b6b0cf3818 100644 --- a/internal/services/secret/secret_test.go +++ b/internal/services/secret/secret_test.go @@ -330,7 +330,6 @@ func testAccCheckSecretDestroy(tt *acctest.TestTools) resource.TestCheckFunc { SecretID: id, Region: region, }) - if err == nil { return fmt.Errorf("secret (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/secret/version_test.go b/internal/services/secret/version_test.go index 581d3971ba..e35d0ceff8 100644 --- a/internal/services/secret/version_test.go +++ b/internal/services/secret/version_test.go @@ -213,7 +213,6 @@ func testAccCheckSecretVersionDestroy(tt *acctest.TestTools) resource.TestCheckF Region: region, Revision: revision, }) - if err == nil { return fmt.Errorf("secret version (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/tem/offer_subscription_data_source_test.go b/internal/services/tem/offer_subscription_data_source_test.go index f1e0f5ddab..9eb136d5fa 100644 --- a/internal/services/tem/offer_subscription_data_source_test.go +++ b/internal/services/tem/offer_subscription_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceOfferSubscription_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + orgID, orgIDExists := tt.Meta.ScwClient().GetDefaultOrganizationID() if !orgIDExists { diff --git a/internal/services/vpc/acl_test.go b/internal/services/vpc/acl_test.go index e3bbd91e3f..1e9c602516 100644 --- a/internal/services/vpc/acl_test.go +++ b/internal/services/vpc/acl_test.go @@ -15,6 +15,7 @@ import ( func TestAccACL_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -64,6 +65,7 @@ func TestAccACL_Basic(t *testing.T) { func TestAccACL_WithRules(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -224,7 +226,6 @@ func isACLDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { VpcID: ID, Region: region, }) - if err == nil { return fmt.Errorf("acl (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/vpc/private_network_data_source_test.go b/internal/services/vpc/private_network_data_source_test.go index 4c8e16e31e..8dc0c0982b 100644 --- a/internal/services/vpc/private_network_data_source_test.go +++ b/internal/services/vpc/private_network_data_source_test.go @@ -80,6 +80,7 @@ func TestAccDataSourceVPCPrivateNetwork_Basic(t *testing.T) { func TestAccDataSourceVPCPrivateNetwork_VpcID(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpc/private_network_test.go b/internal/services/vpc/private_network_test.go index a5cf219cc4..96e108748a 100644 --- a/internal/services/vpc/private_network_test.go +++ b/internal/services/vpc/private_network_test.go @@ -87,6 +87,7 @@ func TestAccVPCPrivateNetwork_Basic(t *testing.T) { func TestAccVPCPrivateNetwork_DefaultName(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -109,6 +110,7 @@ func TestAccVPCPrivateNetwork_DefaultName(t *testing.T) { func TestAccVPCPrivateNetwork_Subnets(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -214,6 +216,7 @@ func TestAccVPCPrivateNetwork_Subnets(t *testing.T) { func TestAccVPCPrivateNetwork_OneSubnet(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpc/route_test.go b/internal/services/vpc/route_test.go index 5ba54583fd..37f1caa5ae 100644 --- a/internal/services/vpc/route_test.go +++ b/internal/services/vpc/route_test.go @@ -15,6 +15,7 @@ import ( func TestAccVPCRoute_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -164,7 +165,6 @@ func isRouteDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { RouteID: ID, Region: region, }) - if err == nil { return fmt.Errorf("route (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/vpc/routes_data_source_test.go b/internal/services/vpc/routes_data_source_test.go index 9e3aaaf639..8683e87952 100644 --- a/internal/services/vpc/routes_data_source_test.go +++ b/internal/services/vpc/routes_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceRoutes_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpc/testfuncs/checks.go b/internal/services/vpc/testfuncs/checks.go index 8c691a3b5c..bc627f1391 100644 --- a/internal/services/vpc/testfuncs/checks.go +++ b/internal/services/vpc/testfuncs/checks.go @@ -27,7 +27,6 @@ func CheckPrivateNetworkDestroy(tt *acctest.TestTools) resource.TestCheckFunc { PrivateNetworkID: ID, Region: region, }) - if err == nil { return fmt.Errorf( "VPC private network %s still exists", diff --git a/internal/services/vpc/vpc_data_source_test.go b/internal/services/vpc/vpc_data_source_test.go index 59be4fb922..4a3d16c137 100644 --- a/internal/services/vpc/vpc_data_source_test.go +++ b/internal/services/vpc/vpc_data_source_test.go @@ -51,6 +51,7 @@ func TestAccDataSourceVPC_Basic(t *testing.T) { func TestAccDataSourceVPC_Default(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpc/vpc_test.go b/internal/services/vpc/vpc_test.go index 8baf8b26b0..bc8442e0dd 100644 --- a/internal/services/vpc/vpc_test.go +++ b/internal/services/vpc/vpc_test.go @@ -16,6 +16,7 @@ import ( func TestAccVPC_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -44,6 +45,7 @@ func TestAccVPC_Basic(t *testing.T) { func TestAccVPC_WithRegion(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -79,6 +81,7 @@ func TestAccVPC_WithRegion(t *testing.T) { func TestAccVPC_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -116,6 +119,7 @@ func TestAccVPC_WithTags(t *testing.T) { func TestAccVPC_DisableRouting(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -185,7 +189,6 @@ func testAccCheckVPCDestroy(tt *acctest.TestTools) resource.TestCheckFunc { VpcID: ID, Region: region, }) - if err == nil { return fmt.Errorf("VPC (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/vpc/vpcs_data_source_test.go b/internal/services/vpc/vpcs_data_source_test.go index 8bceab3286..02cbeffa1b 100644 --- a/internal/services/vpc/vpcs_data_source_test.go +++ b/internal/services/vpc/vpcs_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceVPCs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpcgw/ip_test.go b/internal/services/vpcgw/ip_test.go index dc74fc27a5..32017ced1c 100644 --- a/internal/services/vpcgw/ip_test.go +++ b/internal/services/vpcgw/ip_test.go @@ -15,6 +15,7 @@ import ( func TestAccVPCPublicGatewayIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: vpcgwchecks.IsIPDestroyed(tt), @@ -37,6 +38,7 @@ func TestAccVPCPublicGatewayIP_Basic(t *testing.T) { func TestAccVPCPublicGatewayIP_WithZone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: vpcgwchecks.IsIPDestroyed(tt), @@ -68,6 +70,7 @@ func TestAccVPCPublicGatewayIP_WithZone(t *testing.T) { func TestAccVPCPublicGatewayIP_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: vpcgwchecks.IsIPDestroyed(tt), diff --git a/internal/services/vpcgw/network_data_source_test.go b/internal/services/vpcgw/network_data_source_test.go index 6595e7a85f..8557daaaf0 100644 --- a/internal/services/vpcgw/network_data_source_test.go +++ b/internal/services/vpcgw/network_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceVPCGatewayNetwork_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpcgw/network_test.go b/internal/services/vpcgw/network_test.go index 887d805e2d..e6bf0a0a4b 100644 --- a/internal/services/vpcgw/network_test.go +++ b/internal/services/vpcgw/network_test.go @@ -16,6 +16,7 @@ import ( func TestAccVPCGatewayNetwork_WithIPAMConfig(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpcgw/pat_rule_test.go b/internal/services/vpcgw/pat_rule_test.go index 3f74826e79..3563715534 100644 --- a/internal/services/vpcgw/pat_rule_test.go +++ b/internal/services/vpcgw/pat_rule_test.go @@ -131,7 +131,6 @@ func testAccCheckVPCPublicGatewayPATRuleDestroy(tt *acctest.TestTools) resource. PatRuleID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC public gateway pat rule %s still exists", diff --git a/internal/services/vpcgw/testfuncs/checks.go b/internal/services/vpcgw/testfuncs/checks.go index 9a9deb35d5..9924df5dbc 100644 --- a/internal/services/vpcgw/testfuncs/checks.go +++ b/internal/services/vpcgw/testfuncs/checks.go @@ -28,7 +28,6 @@ func IsGatewayNetworkDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { GatewayNetworkID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC gateway network %s still exists", @@ -62,7 +61,6 @@ func IsGatewayDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { GatewayID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC public gateway %s still exists", @@ -96,7 +94,6 @@ func IsDHCPDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { DHCPID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC public gateway DHCP config %s still exists", @@ -130,7 +127,6 @@ func IsIPDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { IPID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC public gateway ip %s still exists", diff --git a/internal/services/webhosting/offer_data_source_test.go b/internal/services/webhosting/offer_data_source_test.go index ae6d128da2..82a9c40956 100644 --- a/internal/services/webhosting/offer_data_source_test.go +++ b/internal/services/webhosting/offer_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceOffer_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/webhosting/webhosting_data_source_test.go b/internal/services/webhosting/webhosting_data_source_test.go index 1932a21e8a..01a9ca06c4 100644 --- a/internal/services/webhosting/webhosting_data_source_test.go +++ b/internal/services/webhosting/webhosting_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceWebhosting_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/verify/enum.go b/internal/verify/enum.go index b8ab03b0dd..a1913405cc 100644 --- a/internal/verify/enum.go +++ b/internal/verify/enum.go @@ -28,6 +28,7 @@ func ValidateEnumIgnoreCase[T EnumValues[T]]() schema.SchemaValidateDiagFunc { func getValues[T EnumValues[T]]() []string { var t T + values := t.Values() result := make([]string, len(values)) diff --git a/internal/workerpool/workerpool.go b/internal/workerpool/workerpool.go index 936b532819..8c0fa4d2ca 100644 --- a/internal/workerpool/workerpool.go +++ b/internal/workerpool/workerpool.go @@ -29,6 +29,7 @@ func NewWorkerPool(size int) *WorkerPool { func (p *WorkerPool) AddTask(task Task) { p.tasksWaitingGroup.Add(1) + p.tasksToDispatch <- task }