From 11fd559e9f5deaeb717bc79d44a94ce5b14e3115 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20L=C3=A9one?= Date: Tue, 19 Aug 2025 14:16:41 +0200 Subject: [PATCH 1/3] chore: fix golangci-lint warning --- .golangci.yml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.golangci.yml b/.golangci.yml index eb39037b68..8ba98ff7c5 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -88,7 +88,7 @@ linters: - usetesting # Reports uses of functions with replacement inside the testing package. [auto-fix] - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false] - whitespace # Tool for detection of leading and trailing whitespace [fast: true, auto-fix: true] - - wsl # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false] + - wsl_v5 # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false] - zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false] disable: @@ -129,6 +129,11 @@ linters: reject: - anon + wsl_v5: + allow-first-in-block: true + allow-whole-block: false + branch-max-lines: 2 + exclusions: rules: - path: _test\.go From 376f245646eb16c9b6de3fda526ebb4d2e314a04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20L=C3=A9one?= Date: Tue, 19 Aug 2025 14:26:01 +0200 Subject: [PATCH 2/3] fix linters issues --- internal/services/account/project_test.go | 2 ++ internal/services/applesilicon/server_test.go | 4 +++ .../autoscaling/instance_group_test.go | 1 - .../autoscaling/instance_policy_test.go | 1 - .../autoscaling/instance_template_test.go | 1 - .../az/availability_zones_data_source_test.go | 1 + internal/services/baremetal/server.go | 1 + .../block/snapshot_data_source_test.go | 1 + internal/services/block/testfuncs/checks.go | 2 -- .../services/block/volume_data_source_test.go | 1 + internal/services/cockpit/source_test.go | 1 - .../container/container_data_source_test.go | 1 + internal/services/container/container_test.go | 9 +++++- internal/services/container/cron_test.go | 1 - internal/services/container/namespace_test.go | 2 -- internal/services/container/token_test.go | 1 - internal/services/container/trigger_test.go | 1 - .../domain/record_data_source_test.go | 1 + internal/services/domain/registration_test.go | 1 - .../edgeservices/backend_stage_test.go | 2 ++ .../services/edgeservices/cache_stage_test.go | 1 + .../services/edgeservices/dns_stage_test.go | 1 + .../services/edgeservices/pipeline_test.go | 1 + internal/services/edgeservices/plan_test.go | 1 + .../services/edgeservices/route_stage_test.go | 1 + .../services/edgeservices/tls_stage_test.go | 1 + .../services/edgeservices/waf_stage_test.go | 1 + internal/services/file/testfuncs/checks.go | 1 - .../data_source_flexible_ip_test.go | 2 ++ .../data_source_flexible_ips_test.go | 2 ++ internal/services/flexibleip/ip_test.go | 3 ++ .../services/flexibleip/mac_address_test.go | 3 ++ internal/services/function/cron_test.go | 1 - internal/services/function/domain_test.go | 1 - internal/services/function/function_test.go | 2 +- internal/services/function/namespace_test.go | 1 - internal/services/function/token_test.go | 1 - internal/services/function/trigger_test.go | 1 - internal/services/iam/api_key_test.go | 3 ++ .../iam/application_data_source_test.go | 1 + internal/services/iam/application_test.go | 1 + .../services/iam/group_data_source_test.go | 2 ++ internal/services/iam/group_test.go | 4 +++ .../iam/ssh_key_account_data_source_test.go | 1 + .../services/iam/ssh_key_data_source_test.go | 1 + .../services/iam/user_data_source_test.go | 1 + internal/services/iam/user_test.go | 1 + .../services/inference/testfuncs/checks.go | 2 -- .../data_source_instance_private_nic_test.go | 1 + .../instance/image_data_source_test.go | 1 + internal/services/instance/image_test.go | 6 ++++ .../services/instance/ip_data_source_test.go | 1 + internal/services/instance/ip_test.go | 3 ++ .../placement_group_data_source_test.go | 1 + .../services/instance/placement_group_test.go | 3 ++ .../services/instance/private_nic_test.go | 4 ++- .../instance/security_group_rules_test.go | 1 + .../services/instance/security_group_test.go | 4 +++ internal/services/instance/server_test.go | 30 +++++++++++++++++++ .../instance/servers_data_source_test.go | 2 ++ internal/services/instance/snapshot_test.go | 1 + internal/services/instance/user_data_test.go | 1 + internal/services/instance/volume_test.go | 6 ++++ .../iot/data_source_iot_device_test.go | 1 + .../services/iot/data_source_iot_hub_test.go | 1 + internal/services/iot/device_test.go | 4 +++ internal/services/iot/helpers_iot.go | 1 + internal/services/iot/hub_test.go | 2 ++ internal/services/iot/network_test.go | 3 ++ internal/services/iot/routes_test.go | 1 + internal/services/ipam/ip_data_source_test.go | 3 ++ internal/services/ipam/ip_test.go | 4 +++ .../services/ipam/ips_data_source_test.go | 2 ++ internal/services/ipam/testfuncs/checks.go | 1 - internal/services/jobs/jobs_test.go | 2 +- internal/services/k8s/pool_test.go | 1 + internal/services/lb/acl_test.go | 1 + internal/services/lb/acls_data_source_test.go | 1 + .../services/lb/backend_data_source_test.go | 1 + internal/services/lb/backend_test.go | 4 +++ .../services/lb/backends_data_source_test.go | 1 + .../lb/certificate_data_source_test.go | 1 + internal/services/lb/certificate_test.go | 1 + .../lb/data_source_lb_frontends_test.go | 1 + .../services/lb/data_source_lb_ip_test.go | 1 + .../services/lb/frontend_data_source_test.go | 1 + internal/services/lb/frontend_test.go | 3 ++ internal/services/lb/ip_test.go | 3 ++ internal/services/lb/ips_data_source_test.go | 3 ++ internal/services/lb/lb_data_source_test.go | 1 + internal/services/lb/lb_test.go | 8 +++++ internal/services/lb/lbs_data_source_test.go | 1 + .../services/lb/route_data_source_test.go | 1 + internal/services/lb/route_test.go | 3 ++ .../services/lb/routes_data_source_test.go | 1 + .../marketplace/image_data_source_test.go | 2 ++ internal/services/mnq/nats_account_test.go | 1 - .../services/mnq/nats_credentials_test.go | 1 - internal/services/mnq/sns_credentials_test.go | 1 - internal/services/mnq/sns_data_source_test.go | 1 + internal/services/mnq/sqs_credentials_test.go | 1 - internal/services/mnq/sqs_data_source_test.go | 1 + internal/services/mongodb/instance_test.go | 1 - internal/services/rdb/snapshots_test.go | 1 - .../redis/cluster_data_source_test.go | 1 + internal/services/redis/cluster_test.go | 10 ++++++- internal/services/registry/namespace_test.go | 1 - internal/services/sdb/database_test.go | 1 - internal/services/secret/secret_test.go | 1 - internal/services/secret/version_test.go | 1 - .../offer_subscription_data_source_test.go | 1 + internal/services/vpc/acl_test.go | 3 +- .../vpc/private_network_data_source_test.go | 1 + internal/services/vpc/private_network_test.go | 3 ++ internal/services/vpc/route_test.go | 2 +- .../services/vpc/routes_data_source_test.go | 1 + internal/services/vpc/testfuncs/checks.go | 1 - internal/services/vpc/vpc_data_source_test.go | 1 + internal/services/vpc/vpc_test.go | 5 +++- .../services/vpc/vpcs_data_source_test.go | 1 + internal/services/vpcgw/ip_test.go | 3 ++ .../vpcgw/network_data_source_test.go | 1 + internal/services/vpcgw/network_test.go | 1 + internal/services/vpcgw/pat_rule_test.go | 1 - internal/services/vpcgw/testfuncs/checks.go | 4 --- .../webhosting/offer_data_source_test.go | 1 + .../webhosting/webhosting_data_source_test.go | 1 + internal/verify/enum.go | 1 + internal/workerpool/workerpool.go | 1 + 129 files changed, 218 insertions(+), 45 deletions(-) diff --git a/internal/services/account/project_test.go b/internal/services/account/project_test.go index fa5c094229..206156dc45 100644 --- a/internal/services/account/project_test.go +++ b/internal/services/account/project_test.go @@ -15,6 +15,7 @@ import ( func TestAccProject_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: isProjectDestroyed(tt), @@ -52,6 +53,7 @@ func TestAccProject_Basic(t *testing.T) { func TestAccProject_NoUpdate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: isProjectDestroyed(tt), diff --git a/internal/services/applesilicon/server_test.go b/internal/services/applesilicon/server_test.go index e3a9081062..43b6f03933 100644 --- a/internal/services/applesilicon/server_test.go +++ b/internal/services/applesilicon/server_test.go @@ -15,6 +15,7 @@ import ( func TestAccServer_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -67,6 +68,7 @@ func TestAccServer_Basic(t *testing.T) { func TestAccServer_EnableDisabledVPC(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -121,6 +123,7 @@ func TestAccServer_EnableDisabledVPC(t *testing.T) { func TestAccServer_EnableVPC(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -265,6 +268,7 @@ func TestAccServer_Commitment(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/autoscaling/instance_group_test.go b/internal/services/autoscaling/instance_group_test.go index 5c54d6c4b4..fdcf3c64d7 100644 --- a/internal/services/autoscaling/instance_group_test.go +++ b/internal/services/autoscaling/instance_group_test.go @@ -154,7 +154,6 @@ func testAccCheckInstanceGroupDestroy(tt *acctest.TestTools) resource.TestCheckF InstanceGroupID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("autoscaling instance group (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/autoscaling/instance_policy_test.go b/internal/services/autoscaling/instance_policy_test.go index 8ee2291ca9..57e4ce4a1a 100644 --- a/internal/services/autoscaling/instance_policy_test.go +++ b/internal/services/autoscaling/instance_policy_test.go @@ -170,7 +170,6 @@ func testAccCheckInstancePolicyDestroy(tt *acctest.TestTools) resource.TestCheck PolicyID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("autoscaling instance policy (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/autoscaling/instance_template_test.go b/internal/services/autoscaling/instance_template_test.go index a13a3e454e..7fd5e155b0 100644 --- a/internal/services/autoscaling/instance_template_test.go +++ b/internal/services/autoscaling/instance_template_test.go @@ -166,7 +166,6 @@ func testAccCheckInstanceTemplateDestroy(tt *acctest.TestTools) resource.TestChe TemplateID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("autoscaling instance template (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/az/availability_zones_data_source_test.go b/internal/services/az/availability_zones_data_source_test.go index e97bc26ac1..63c5030bbe 100644 --- a/internal/services/az/availability_zones_data_source_test.go +++ b/internal/services/az/availability_zones_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceAvailabilityZones_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/baremetal/server.go b/internal/services/baremetal/server.go index c6a4a26a78..0aa42d6aeb 100644 --- a/internal/services/baremetal/server.go +++ b/internal/services/baremetal/server.go @@ -605,6 +605,7 @@ func ResourceServerUpdate(ctx context.Context, d *schema.ResourceData, m any) di } var serverGetOptionIDs []*baremetal.ServerOption + serverGetOptionIDs = append(serverGetOptionIDs, server.Options...) if d.HasChange("offer") { diff --git a/internal/services/block/snapshot_data_source_test.go b/internal/services/block/snapshot_data_source_test.go index ea2fbb9e70..e485b86465 100644 --- a/internal/services/block/snapshot_data_source_test.go +++ b/internal/services/block/snapshot_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceSnapshot_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/block/testfuncs/checks.go b/internal/services/block/testfuncs/checks.go index 8af50841e7..87f8712728 100644 --- a/internal/services/block/testfuncs/checks.go +++ b/internal/services/block/testfuncs/checks.go @@ -75,7 +75,6 @@ func IsVolumeDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { VolumeID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("block volume (%s) still exists", rs.Primary.ID) } @@ -105,7 +104,6 @@ func IsSnapshotDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { SnapshotID: id, Zone: zone, }) - if err == nil { return fmt.Errorf("block snapshot (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/block/volume_data_source_test.go b/internal/services/block/volume_data_source_test.go index a0f43824f2..c4731a77f6 100644 --- a/internal/services/block/volume_data_source_test.go +++ b/internal/services/block/volume_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceVolume_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/cockpit/source_test.go b/internal/services/cockpit/source_test.go index 295e35a107..f80bfca6a2 100644 --- a/internal/services/cockpit/source_test.go +++ b/internal/services/cockpit/source_test.go @@ -245,7 +245,6 @@ func isSourceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { Region: region, DataSourceID: ID, }) - if err == nil { return fmt.Errorf("cockpit source (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/container/container_data_source_test.go b/internal/services/container/container_data_source_test.go index 02f72a114d..88220c10ca 100644 --- a/internal/services/container/container_data_source_test.go +++ b/internal/services/container/container_data_source_test.go @@ -91,6 +91,7 @@ func TestAccDataSourceContainer_HealthCheck(t *testing.T) { func TestAccDataSourceContainer_ScalingOption(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/container/container_test.go b/internal/services/container/container_test.go index 329acb83f3..d423742afb 100644 --- a/internal/services/container/container_test.go +++ b/internal/services/container/container_test.go @@ -18,6 +18,7 @@ import ( func TestAccContainer_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -135,6 +136,7 @@ func TestAccContainer_Basic(t *testing.T) { func TestAccContainer_Env(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -278,6 +280,7 @@ func TestAccContainer_WithIMG(t *testing.T) { func TestAccContainer_HTTPOption(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -334,6 +337,7 @@ func TestAccContainer_HTTPOption(t *testing.T) { func TestAccContainer_Sandbox(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -404,6 +408,7 @@ func TestAccContainer_Sandbox(t *testing.T) { func TestAccContainer_HealthCheck(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -458,6 +463,7 @@ func TestAccContainer_HealthCheck(t *testing.T) { func TestAccContainer_ScalingOption(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -547,6 +553,7 @@ func TestAccContainer_ScalingOption(t *testing.T) { func TestAccContainer_CommandAndArgs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -629,6 +636,7 @@ func TestAccContainer_CommandAndArgs(t *testing.T) { func TestAccContainer_PrivateNetwork(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -797,7 +805,6 @@ func isContainerDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { ContainerID: id, Region: region, }) - if err == nil { return fmt.Errorf("container (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/container/cron_test.go b/internal/services/container/cron_test.go index 10c2c4614a..56c66772d9 100644 --- a/internal/services/container/cron_test.go +++ b/internal/services/container/cron_test.go @@ -182,7 +182,6 @@ func isCronDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { CronID: id, Region: region, }) - if err == nil { return fmt.Errorf("containerSDK cron (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/container/namespace_test.go b/internal/services/container/namespace_test.go index 90b4ca0953..41c3d53947 100644 --- a/internal/services/container/namespace_test.go +++ b/internal/services/container/namespace_test.go @@ -379,7 +379,6 @@ func isNamespaceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NamespaceID: id, Region: region, }) - if err == nil { return fmt.Errorf("container namespace (%s) still exists", rs.Primary.ID) } @@ -409,7 +408,6 @@ func isRegistryDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NamespaceID: rs.Primary.Attributes["registry_namespace_id"], Region: region, }) - if err == nil { return fmt.Errorf("registry namespace (%s) still exists", rs.Primary.Attributes["registry_namespace_id"]) } diff --git a/internal/services/container/token_test.go b/internal/services/container/token_test.go index aac82d2f99..81b96837b3 100644 --- a/internal/services/container/token_test.go +++ b/internal/services/container/token_test.go @@ -101,7 +101,6 @@ func isTokenDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { TokenID: id, Region: region, }) - if err == nil { return fmt.Errorf("container token (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/container/trigger_test.go b/internal/services/container/trigger_test.go index 3cad685e0c..e3e9c56827 100644 --- a/internal/services/container/trigger_test.go +++ b/internal/services/container/trigger_test.go @@ -198,7 +198,6 @@ func isTriggerDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { TriggerID: id, Region: region, }) - if err == nil { return fmt.Errorf("container trigger (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/domain/record_data_source_test.go b/internal/services/domain/record_data_source_test.go index 72cd7afaf6..d01a6e69be 100644 --- a/internal/services/domain/record_data_source_test.go +++ b/internal/services/domain/record_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceDomainRecord_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/domain/registration_test.go b/internal/services/domain/registration_test.go index 915e665d14..1e5e2c7f99 100644 --- a/internal/services/domain/registration_test.go +++ b/internal/services/domain/registration_test.go @@ -191,7 +191,6 @@ func testAccCheckDomainStatus(tt *acctest.TestTools, expectedAutoRenew, expected domainResp, getErr := registrarAPI.GetDomain(&domainSDK.RegistrarAPIGetDomainRequest{ Domain: domainName, }) - if getErr != nil { return fmt.Errorf("failed to get details for domain %s: %w", domainName, getErr) } diff --git a/internal/services/edgeservices/backend_stage_test.go b/internal/services/edgeservices/backend_stage_test.go index 534eefd69f..441f8294c7 100644 --- a/internal/services/edgeservices/backend_stage_test.go +++ b/internal/services/edgeservices/backend_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesBackend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -57,6 +58,7 @@ func TestAccEdgeServicesBackend_Basic(t *testing.T) { func TestAccEdgeServicesBackend_LB(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/cache_stage_test.go b/internal/services/edgeservices/cache_stage_test.go index ff5a65ebfd..7b2b09ea91 100644 --- a/internal/services/edgeservices/cache_stage_test.go +++ b/internal/services/edgeservices/cache_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesCache_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/dns_stage_test.go b/internal/services/edgeservices/dns_stage_test.go index 058cc70243..9f11a587f6 100644 --- a/internal/services/edgeservices/dns_stage_test.go +++ b/internal/services/edgeservices/dns_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesDNS_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/pipeline_test.go b/internal/services/edgeservices/pipeline_test.go index 8e13985113..6fdb7bfa22 100644 --- a/internal/services/edgeservices/pipeline_test.go +++ b/internal/services/edgeservices/pipeline_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesPipeline_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/plan_test.go b/internal/services/edgeservices/plan_test.go index 7f36d8ac4f..e57f9912e4 100644 --- a/internal/services/edgeservices/plan_test.go +++ b/internal/services/edgeservices/plan_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesPlan_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/route_stage_test.go b/internal/services/edgeservices/route_stage_test.go index 20cbd5637a..55e9803d67 100644 --- a/internal/services/edgeservices/route_stage_test.go +++ b/internal/services/edgeservices/route_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesRoute_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/tls_stage_test.go b/internal/services/edgeservices/tls_stage_test.go index a9d6dcb296..db9d406577 100644 --- a/internal/services/edgeservices/tls_stage_test.go +++ b/internal/services/edgeservices/tls_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesTLS_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/edgeservices/waf_stage_test.go b/internal/services/edgeservices/waf_stage_test.go index ae2417f8e6..ac24d02b6e 100644 --- a/internal/services/edgeservices/waf_stage_test.go +++ b/internal/services/edgeservices/waf_stage_test.go @@ -11,6 +11,7 @@ import ( func TestAccEdgeServicesWAF_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/file/testfuncs/checks.go b/internal/services/file/testfuncs/checks.go index 9aa1a9d128..3237c77070 100644 --- a/internal/services/file/testfuncs/checks.go +++ b/internal/services/file/testfuncs/checks.go @@ -27,7 +27,6 @@ func CheckFileDestroy(tt *acctest.TestTools) resource.TestCheckFunc { Region: region, FilesystemID: id, }) - if err == nil { return fmt.Errorf("filesystem (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/flexibleip/data_source_flexible_ip_test.go b/internal/services/flexibleip/data_source_flexible_ip_test.go index 5c55137953..4286e0285c 100644 --- a/internal/services/flexibleip/data_source_flexible_ip_test.go +++ b/internal/services/flexibleip/data_source_flexible_ip_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceFlexibleIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -47,6 +48,7 @@ func TestAccDataSourceFlexibleIP_Basic(t *testing.T) { func TestAccDataSourceFlexibleIP_Multiple(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/flexibleip/data_source_flexible_ips_test.go b/internal/services/flexibleip/data_source_flexible_ips_test.go index 257a49cc0a..7a7c154af1 100644 --- a/internal/services/flexibleip/data_source_flexible_ips_test.go +++ b/internal/services/flexibleip/data_source_flexible_ips_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceFlexibleIPs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -60,6 +61,7 @@ func TestAccDataSourceFlexibleIPs_Basic(t *testing.T) { func TestAccDataSourceFlexibleIPs_WithBaremetalIDs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/flexibleip/ip_test.go b/internal/services/flexibleip/ip_test.go index 05f5030cf0..f79dff793e 100644 --- a/internal/services/flexibleip/ip_test.go +++ b/internal/services/flexibleip/ip_test.go @@ -22,6 +22,7 @@ const SSHKeyFlexibleIP = "ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIM7HUxRyQtB2rnlhQU func TestAccFlexibleIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), @@ -47,6 +48,7 @@ func TestAccFlexibleIP_Basic(t *testing.T) { func TestAccFlexibleIP_WithZone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), @@ -78,6 +80,7 @@ func TestAccFlexibleIP_WithZone(t *testing.T) { func TestAccFlexibleIP_IPv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), diff --git a/internal/services/flexibleip/mac_address_test.go b/internal/services/flexibleip/mac_address_test.go index f546458714..ca8446896c 100644 --- a/internal/services/flexibleip/mac_address_test.go +++ b/internal/services/flexibleip/mac_address_test.go @@ -16,6 +16,7 @@ import ( func TestAccFlexibleIPMACAddress_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), @@ -44,6 +45,7 @@ func TestAccFlexibleIPMACAddress_Basic(t *testing.T) { func TestAccFlexibleIPMACAddress_MoveToAnotherFlexibleIP(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckFlexibleIPDestroy(tt), @@ -99,6 +101,7 @@ func TestAccFlexibleIPMACAddress_MoveToAnotherFlexibleIP(t *testing.T) { func TestAccFlexibleIPMACAddress_DuplicateOnOtherFlexibleIPs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( diff --git a/internal/services/function/cron_test.go b/internal/services/function/cron_test.go index 25e08a0455..9564d21145 100644 --- a/internal/services/function/cron_test.go +++ b/internal/services/function/cron_test.go @@ -199,7 +199,6 @@ func testAccCheckFunctionCronDestroy(tt *acctest.TestTools) resource.TestCheckFu CronID: id, Region: region, }) - if err == nil { return fmt.Errorf("function cron (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/domain_test.go b/internal/services/function/domain_test.go index bb5967aa62..ff01d598d9 100644 --- a/internal/services/function/domain_test.go +++ b/internal/services/function/domain_test.go @@ -100,7 +100,6 @@ func testAccCheckFunctionDomainDestroy(tt *acctest.TestTools) resource.TestCheck DomainID: id, Region: region, }) - if err == nil { return fmt.Errorf("function domain (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/function_test.go b/internal/services/function/function_test.go index 02aa4feec3..1c2a089e7a 100644 --- a/internal/services/function/function_test.go +++ b/internal/services/function/function_test.go @@ -414,6 +414,7 @@ func TestAccFunction_Sandbox(t *testing.T) { func TestAccFunction_PrivateNetwork(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -603,7 +604,6 @@ func testAccCheckFunctionDestroy(tt *acctest.TestTools) resource.TestCheckFunc { FunctionID: id, Region: region, }) - if err == nil { return fmt.Errorf("function (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/namespace_test.go b/internal/services/function/namespace_test.go index 1c29bc1662..36edd22578 100644 --- a/internal/services/function/namespace_test.go +++ b/internal/services/function/namespace_test.go @@ -302,7 +302,6 @@ func testAccCheckFunctionNamespaceDestroy(tt *acctest.TestTools) resource.TestCh NamespaceID: id, Region: region, }) - if err == nil { return fmt.Errorf("function namespace (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/token_test.go b/internal/services/function/token_test.go index 9087ba5d4d..f58ca9239e 100644 --- a/internal/services/function/token_test.go +++ b/internal/services/function/token_test.go @@ -104,7 +104,6 @@ func testAccCheckFunctionTokenDestroy(tt *acctest.TestTools) resource.TestCheckF TokenID: id, Region: region, }) - if err == nil { return fmt.Errorf("function token (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/function/trigger_test.go b/internal/services/function/trigger_test.go index d3292e848f..f129aedd37 100644 --- a/internal/services/function/trigger_test.go +++ b/internal/services/function/trigger_test.go @@ -260,7 +260,6 @@ func testAccCheckFunctionTriggerDestroy(tt *acctest.TestTools) resource.TestChec TriggerID: id, Region: region, }) - if err == nil { return fmt.Errorf("function trigger (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/iam/api_key_test.go b/internal/services/iam/api_key_test.go index 47c8947265..ef42ef6c97 100644 --- a/internal/services/iam/api_key_test.go +++ b/internal/services/iam/api_key_test.go @@ -15,6 +15,7 @@ import ( func TestAccApiKey_WithApplication(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( @@ -71,6 +72,7 @@ func TestAccApiKey_WithApplication(t *testing.T) { func TestAccApiKey_WithApplicationChange(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( @@ -135,6 +137,7 @@ func TestAccApiKey_WithApplicationChange(t *testing.T) { func TestAccApiKey_Expires(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( diff --git a/internal/services/iam/application_data_source_test.go b/internal/services/iam/application_data_source_test.go index f80870ecf8..fdf8491255 100644 --- a/internal/services/iam/application_data_source_test.go +++ b/internal/services/iam/application_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceApplication_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/application_test.go b/internal/services/iam/application_test.go index 4fed85d610..fa1713413b 100644 --- a/internal/services/iam/application_test.go +++ b/internal/services/iam/application_test.go @@ -15,6 +15,7 @@ import ( func TestAccApplication_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckIamApplicationDestroy(tt), diff --git a/internal/services/iam/group_data_source_test.go b/internal/services/iam/group_data_source_test.go index 906df2ee5c..daad63995e 100644 --- a/internal/services/iam/group_data_source_test.go +++ b/internal/services/iam/group_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceGroup_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -47,6 +48,7 @@ func TestAccDataSourceGroup_Basic(t *testing.T) { func TestAccDataSourceGroup_UsersAndApplications(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/group_test.go b/internal/services/iam/group_test.go index cc4689261e..5fb454ee72 100644 --- a/internal/services/iam/group_test.go +++ b/internal/services/iam/group_test.go @@ -15,6 +15,7 @@ import ( func TestAccGroup_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: testAccCheckIamGroupDestroy(tt), @@ -102,6 +103,7 @@ func TestAccGroup_Basic(t *testing.T) { func TestAccGroup_Applications(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( @@ -200,6 +202,7 @@ func TestAccGroup_Applications(t *testing.T) { func TestAccGroup_Users(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( @@ -291,6 +294,7 @@ func TestAccGroup_Users(t *testing.T) { func TestAccGroup_UsersAndApplications(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: resource.ComposeTestCheckFunc( diff --git a/internal/services/iam/ssh_key_account_data_source_test.go b/internal/services/iam/ssh_key_account_data_source_test.go index 9b2aee9627..9d5ed3aa85 100644 --- a/internal/services/iam/ssh_key_account_data_source_test.go +++ b/internal/services/iam/ssh_key_account_data_source_test.go @@ -16,6 +16,7 @@ func TestAccDataSourceAccountSSHKey_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/ssh_key_data_source_test.go b/internal/services/iam/ssh_key_data_source_test.go index 977e3cacde..a1ac52f837 100644 --- a/internal/services/iam/ssh_key_data_source_test.go +++ b/internal/services/iam/ssh_key_data_source_test.go @@ -16,6 +16,7 @@ func TestAccDataSourceSSHKey_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/user_data_source_test.go b/internal/services/iam/user_data_source_test.go index e6c872c2a5..852ba6ba40 100644 --- a/internal/services/iam/user_data_source_test.go +++ b/internal/services/iam/user_data_source_test.go @@ -14,6 +14,7 @@ import ( func TestAccDataSourceUser_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iam/user_test.go b/internal/services/iam/user_test.go index f4e3974214..33399ffb85 100644 --- a/internal/services/iam/user_test.go +++ b/internal/services/iam/user_test.go @@ -15,6 +15,7 @@ import ( func TestAccUser_Member(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: isUserDestroyed(tt), diff --git a/internal/services/inference/testfuncs/checks.go b/internal/services/inference/testfuncs/checks.go index f617f5a7fd..606ee453f0 100644 --- a/internal/services/inference/testfuncs/checks.go +++ b/internal/services/inference/testfuncs/checks.go @@ -27,7 +27,6 @@ func IsDeploymentDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { Region: region, DeploymentID: ID, }) - if err == nil { return fmt.Errorf("deployment %s (%s) still exists", deployment.Name, deployment.ID) } @@ -57,7 +56,6 @@ func IsModelDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { Region: region, ModelID: id, }) - if err == nil { return fmt.Errorf("model %s (%s) still exists", model.Name, model.ID) } diff --git a/internal/services/instance/data_source_instance_private_nic_test.go b/internal/services/instance/data_source_instance_private_nic_test.go index f67b8b422d..5114ebcd23 100644 --- a/internal/services/instance/data_source_instance_private_nic_test.go +++ b/internal/services/instance/data_source_instance_private_nic_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourcePrivateNIC_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/image_data_source_test.go b/internal/services/instance/image_data_source_test.go index e3505b5940..3ff370fbb4 100644 --- a/internal/services/instance/image_data_source_test.go +++ b/internal/services/instance/image_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceImage_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/image_test.go b/internal/services/instance/image_test.go index e290926ab4..f61d932740 100644 --- a/internal/services/instance/image_test.go +++ b/internal/services/instance/image_test.go @@ -20,6 +20,7 @@ func TestAccImage_BlockVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -116,6 +117,7 @@ func TestAccImage_BlockVolume(t *testing.T) { func TestAccImage_ExternalBlockVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -211,6 +213,7 @@ func TestAccImage_ExternalBlockVolume(t *testing.T) { func TestAccImage_Server(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -286,6 +289,7 @@ func TestAccImage_ServerWithBlockVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -438,6 +442,7 @@ func TestAccImage_ServerWithBlockVolume(t *testing.T) { func TestAccImage_ServerWithLocalVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -559,6 +564,7 @@ func TestAccImage_ServerWithLocalVolume(t *testing.T) { func TestAccImage_ServerWithSBSVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/ip_data_source_test.go b/internal/services/instance/ip_data_source_test.go index b0d9bc16cf..0f66c27387 100644 --- a/internal/services/instance/ip_data_source_test.go +++ b/internal/services/instance/ip_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/ip_test.go b/internal/services/instance/ip_test.go index 078d206f42..39ea12f8c3 100644 --- a/internal/services/instance/ip_test.go +++ b/internal/services/instance/ip_test.go @@ -17,6 +17,7 @@ import ( func TestAccIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: instancechecks.IsIPDestroyed(tt), @@ -38,6 +39,7 @@ func TestAccIP_Basic(t *testing.T) { func TestAccIP_WithZone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: instancechecks.IsIPDestroyed(tt), @@ -69,6 +71,7 @@ func TestAccIP_WithZone(t *testing.T) { func TestAccIP_Tags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: instancechecks.IsIPDestroyed(tt), diff --git a/internal/services/instance/placement_group_data_source_test.go b/internal/services/instance/placement_group_data_source_test.go index 88176cd2e1..38eb36c358 100644 --- a/internal/services/instance/placement_group_data_source_test.go +++ b/internal/services/instance/placement_group_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourcePlacementGroup_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/placement_group_test.go b/internal/services/instance/placement_group_test.go index ba55e61d69..caa46c3df7 100644 --- a/internal/services/instance/placement_group_test.go +++ b/internal/services/instance/placement_group_test.go @@ -16,6 +16,7 @@ import ( func TestAccPlacementGroup_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -62,6 +63,7 @@ func TestAccPlacementGroup_Basic(t *testing.T) { func TestAccPlacementGroup_Rename(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -104,6 +106,7 @@ func TestAccPlacementGroup_Rename(t *testing.T) { func TestAccPlacementGroup_Tags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: instancechecks.IsIPDestroyed(tt), diff --git a/internal/services/instance/private_nic_test.go b/internal/services/instance/private_nic_test.go index 05c398f7fe..ecf5990774 100644 --- a/internal/services/instance/private_nic_test.go +++ b/internal/services/instance/private_nic_test.go @@ -15,6 +15,7 @@ import ( func TestAccPrivateNIC_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -52,6 +53,7 @@ func TestAccPrivateNIC_Basic(t *testing.T) { func TestAccPrivateNIC_Tags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -140,6 +142,7 @@ func TestAccPrivateNIC_Tags(t *testing.T) { func TestAccPrivateNIC_WithIPAM(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -245,7 +248,6 @@ func isPrivateNICDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { PrivateNicID: innerID, Zone: zone, }) - if err == nil { return fmt.Errorf( "instanceSDK private NIC %s still exists", diff --git a/internal/services/instance/security_group_rules_test.go b/internal/services/instance/security_group_rules_test.go index 13487385dd..62821639ef 100644 --- a/internal/services/instance/security_group_rules_test.go +++ b/internal/services/instance/security_group_rules_test.go @@ -10,6 +10,7 @@ import ( func TestAccSecurityGroupRules_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/security_group_test.go b/internal/services/instance/security_group_test.go index d95992cb5e..12074de2c9 100644 --- a/internal/services/instance/security_group_test.go +++ b/internal/services/instance/security_group_test.go @@ -241,6 +241,7 @@ func TestAccSecurityGroup_ICMP(t *testing.T) { func TestAccSecurityGroup_ANY(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -382,6 +383,7 @@ func TestAccSecurityGroup_RemovePort(t *testing.T) { func TestAccSecurityGroup_WithPortRange(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -439,6 +441,7 @@ func TestAccSecurityGroup_WithPortRange(t *testing.T) { func TestAccSecurityGroup_Tags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -594,6 +597,7 @@ func isSecurityGroupDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { func TestAccSecurityGroup_EnableDefaultSecurity(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/server_test.go b/internal/services/instance/server_test.go index 1fc4e70b6a..3ddd84ef93 100644 --- a/internal/services/instance/server_test.go +++ b/internal/services/instance/server_test.go @@ -23,6 +23,7 @@ import ( func TestAccServer_Minimal1(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -79,6 +80,7 @@ func TestAccServer_Minimal1(t *testing.T) { func TestAccServer_Minimal2(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -202,6 +204,7 @@ func TestAccServer_RootVolume1(t *testing.T) { func TestAccServer_RootVolume_Boot(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -252,6 +255,7 @@ func TestAccServer_RootVolume_ID(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -288,6 +292,7 @@ func TestAccServer_RootVolume_ID(t *testing.T) { func TestAccServer_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -349,6 +354,7 @@ func TestAccServer_Basic(t *testing.T) { func TestAccServer_State1(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -418,6 +424,7 @@ func TestAccServer_State1(t *testing.T) { func TestAccServer_State2(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -468,6 +475,7 @@ func TestAccServer_State2(t *testing.T) { func TestAccServer_UserData_WithCloudInitAtStart(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -501,6 +509,7 @@ EOF func TestAccServer_UserData_WithoutCloudInitAtStart(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -554,6 +563,7 @@ func TestAccServer_AdditionalVolumes(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -632,6 +642,7 @@ func TestAccServer_AdditionalVolumesDetach(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -699,6 +710,7 @@ func TestAccServer_AdditionalVolumesDetach(t *testing.T) { func TestAccServer_WithPlacementGroup(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -739,6 +751,7 @@ func TestAccServer_WithPlacementGroup(t *testing.T) { func TestAccServer_Ipv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -783,6 +796,7 @@ func TestAccServer_Ipv6(t *testing.T) { func TestAccServer_Basic2(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -813,6 +827,7 @@ func TestAccServer_Basic2(t *testing.T) { func TestAccServer_WithReservedIP(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -979,6 +994,7 @@ func serverHasNewVolume(_ *acctest.TestTools, n string) resource.TestCheckFunc { func TestAccServer_AlterTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1022,6 +1038,7 @@ func TestAccServer_WithDefaultRootVolumeAndAdditionalVolume(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1056,6 +1073,7 @@ func TestAccServer_ServerWithBlockNonDefaultZone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1092,6 +1110,7 @@ func TestAccServer_ServerWithBlockNonDefaultZone(t *testing.T) { func TestAccServer_PrivateNetwork(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1246,6 +1265,7 @@ func TestAccServer_PrivateNetwork(t *testing.T) { func TestAccServer_Migrate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1294,6 +1314,7 @@ func TestAccServer_Migrate(t *testing.T) { func TestAccServer_MigrateInvalidLocalVolumeSize(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1336,6 +1357,7 @@ func TestAccServer_MigrateInvalidLocalVolumeSize(t *testing.T) { func TestAccServer_CustomDiffImage(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1490,6 +1512,7 @@ func serverIDsAreDifferent(nameFirst, nameSecond string) resource.TestCheckFunc func TestAccServer_IPs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1568,6 +1591,7 @@ func TestAccServer_IPs(t *testing.T) { func TestAccServer_IPRemoved(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1614,6 +1638,7 @@ func TestAccServer_IPRemoved(t *testing.T) { func TestAccServer_IPsRemoved(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1663,6 +1688,7 @@ func TestAccServer_IPsRemoved(t *testing.T) { func TestAccServer_BlockExternal(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1811,6 +1837,7 @@ func TestAccServer_BlockExternalRootVolume(t *testing.T) { func TestAccServer_BlockExternalRootVolumeUpdate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1863,6 +1890,7 @@ func TestAccServer_BlockExternalRootVolumeUpdate(t *testing.T) { func TestAccServer_RootVolumeFromExternalSnapshot(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -1938,6 +1966,7 @@ func TestAccServer_RootVolumeFromExternalSnapshot(t *testing.T) { func TestAccServer_PrivateNetworkMissingPNIC(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -2172,6 +2201,7 @@ func TestAccServer_AdminPasswordEncryptionSSHKeyID(t *testing.T) { func TestGetEndOfServiceDate(t *testing.T) { tt := acctest.NewTestTools(t) + client := meta.ExtractScwClient(tt.Meta) defer tt.Cleanup() diff --git a/internal/services/instance/servers_data_source_test.go b/internal/services/instance/servers_data_source_test.go index d02fb291ea..eaddefd84c 100644 --- a/internal/services/instance/servers_data_source_test.go +++ b/internal/services/instance/servers_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceServers_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -92,6 +93,7 @@ func TestAccDataSourceServers_Basic(t *testing.T) { func TestAccDataSourceServers_PrivateIPs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/snapshot_test.go b/internal/services/instance/snapshot_test.go index 5b0e87b6ee..3425d26beb 100644 --- a/internal/services/instance/snapshot_test.go +++ b/internal/services/instance/snapshot_test.go @@ -18,6 +18,7 @@ import ( func TestAccSnapshot_Server(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/user_data_test.go b/internal/services/instance/user_data_test.go index 8448ffd438..ec1e9bcb32 100644 --- a/internal/services/instance/user_data_test.go +++ b/internal/services/instance/user_data_test.go @@ -11,6 +11,7 @@ import ( func TestAccServerUserData_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/instance/volume_test.go b/internal/services/instance/volume_test.go index fb195f0f7a..50295d28b2 100644 --- a/internal/services/instance/volume_test.go +++ b/internal/services/instance/volume_test.go @@ -12,6 +12,7 @@ import ( func TestAccVolume_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -53,6 +54,7 @@ func TestAccVolume_Basic(t *testing.T) { func TestAccVolume_DifferentNameGenerated(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -83,6 +85,7 @@ func TestAccVolume_ResizeBlock(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -117,6 +120,7 @@ func TestAccVolume_ResizeBlock(t *testing.T) { func TestAccVolume_ResizeNotBlock(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -150,6 +154,7 @@ func TestAccVolume_CannotResizeBlockDown(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -177,6 +182,7 @@ func TestAccVolume_CannotResizeBlockDown(t *testing.T) { func TestAccVolume_Scratch(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/data_source_iot_device_test.go b/internal/services/iot/data_source_iot_device_test.go index 662f8446fc..5e6fe91d27 100644 --- a/internal/services/iot/data_source_iot_device_test.go +++ b/internal/services/iot/data_source_iot_device_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceDevice_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/data_source_iot_hub_test.go b/internal/services/iot/data_source_iot_hub_test.go index 8349facc68..054bc758a0 100644 --- a/internal/services/iot/data_source_iot_hub_test.go +++ b/internal/services/iot/data_source_iot_hub_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceHub_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/device_test.go b/internal/services/iot/device_test.go index 3ec52edb25..2280f952e7 100644 --- a/internal/services/iot/device_test.go +++ b/internal/services/iot/device_test.go @@ -38,6 +38,7 @@ WuePu1khrEuTaXKyaiLD3pmxM86F/6Ho6V86mJpKXr/wmMU56TcKk9UURucVQZ1o func TestAccDevice_Minimal(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -73,6 +74,7 @@ func TestAccDevice_MessageFilters(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -129,6 +131,7 @@ func TestAccDevice_MessageFilters(t *testing.T) { func TestAccDevice_AllowInsecure(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -184,6 +187,7 @@ func TestAccDevice_AllowInsecure(t *testing.T) { func TestAccDevice_Certificate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/helpers_iot.go b/internal/services/iot/helpers_iot.go index ccc407c2e8..08f6c75c63 100644 --- a/internal/services/iot/helpers_iot.go +++ b/internal/services/iot/helpers_iot.go @@ -88,6 +88,7 @@ func computeIotHubMQTTCa(ctx context.Context, mqttCaURL string, m any) (string, } defer mqttCa.Body.Close() //nolint: errcheck + resp, _ := io.ReadAll(mqttCa.Body) return string(resp), nil diff --git a/internal/services/iot/hub_test.go b/internal/services/iot/hub_test.go index ddd4645289..3aa49e3ef7 100644 --- a/internal/services/iot/hub_test.go +++ b/internal/services/iot/hub_test.go @@ -15,6 +15,7 @@ import ( func TestAccHub_Minimal(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -64,6 +65,7 @@ func TestAccHub_Minimal(t *testing.T) { func TestAccHub_Dedicated(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/network_test.go b/internal/services/iot/network_test.go index 9533cdd152..e9d7690c6a 100644 --- a/internal/services/iot/network_test.go +++ b/internal/services/iot/network_test.go @@ -14,6 +14,7 @@ import ( func TestAccNetwork_Minimal(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -52,6 +53,7 @@ func TestAccNetwork_Minimal(t *testing.T) { func TestAccNetwork_RESTWithTopicPrefix(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -92,6 +94,7 @@ func TestAccNetwork_RESTWithTopicPrefix(t *testing.T) { func TestAccNetwork_Sigfox(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/iot/routes_test.go b/internal/services/iot/routes_test.go index c086219105..bff238ba80 100644 --- a/internal/services/iot/routes_test.go +++ b/internal/services/iot/routes_test.go @@ -145,6 +145,7 @@ func TestAccRoute_S3(t *testing.T) { func TestAccRoute_REST(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/ipam/ip_data_source_test.go b/internal/services/ipam/ip_data_source_test.go index 559cbdd20b..72a8ecb031 100644 --- a/internal/services/ipam/ip_data_source_test.go +++ b/internal/services/ipam/ip_data_source_test.go @@ -14,6 +14,7 @@ import ( func TestAccDataSourceIPAMIP_Instance(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -67,6 +68,7 @@ func TestAccDataSourceIPAMIP_Instance(t *testing.T) { func TestAccDataSourceIPAMIP_InstanceLB(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -182,6 +184,7 @@ func TestAccDataSourceIPAMIP_RDB(t *testing.T) { func TestAccDataSourceIPAMIP_ID(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/ipam/ip_test.go b/internal/services/ipam/ip_test.go index 1b18d9872a..629e4bf35b 100644 --- a/internal/services/ipam/ip_test.go +++ b/internal/services/ipam/ip_test.go @@ -15,6 +15,7 @@ import ( func TestAccIPAMIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -56,6 +57,7 @@ func TestAccIPAMIP_Basic(t *testing.T) { func TestAccIPAMIP_WithStandaloneAddress(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -93,6 +95,7 @@ func TestAccIPAMIP_WithStandaloneAddress(t *testing.T) { func TestAccIPAMIP_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -160,6 +163,7 @@ func TestAccIPAMIP_WithTags(t *testing.T) { func TestAccIPAMIP_WithCustomResource(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/ipam/ips_data_source_test.go b/internal/services/ipam/ips_data_source_test.go index c7aa049121..b61d64d57f 100644 --- a/internal/services/ipam/ips_data_source_test.go +++ b/internal/services/ipam/ips_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceIPAMIPs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -96,6 +97,7 @@ func TestAccDataSourceIPAMIPs_Basic(t *testing.T) { func TestAccDataSourceIPAMIPs_RedisCluster(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/ipam/testfuncs/checks.go b/internal/services/ipam/testfuncs/checks.go index 53cd7c95c5..7277da6d10 100644 --- a/internal/services/ipam/testfuncs/checks.go +++ b/internal/services/ipam/testfuncs/checks.go @@ -27,7 +27,6 @@ func CheckIPDestroy(tt *acctest.TestTools) resource.TestCheckFunc { IPID: ID, Region: region, }) - if err == nil { return fmt.Errorf("IP (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/jobs/jobs_test.go b/internal/services/jobs/jobs_test.go index 7200cfc24c..8aa7ca738a 100644 --- a/internal/services/jobs/jobs_test.go +++ b/internal/services/jobs/jobs_test.go @@ -168,6 +168,7 @@ func TestAccJobDefinition_Cron(t *testing.T) { func TestAccJobDefinition_SecretReference(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -382,7 +383,6 @@ func testAccCheckJobDefinitionDestroy(tt *acctest.TestTools) resource.TestCheckF JobDefinitionID: id, Region: region, }) - if err == nil { return fmt.Errorf("jobs jobdefinition (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/k8s/pool_test.go b/internal/services/k8s/pool_test.go index 638ed33f3a..051e6a560c 100644 --- a/internal/services/k8s/pool_test.go +++ b/internal/services/k8s/pool_test.go @@ -96,6 +96,7 @@ func TestAccPool_Basic(t *testing.T) { func TestAccPool_Wait(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestK8SVersion := testAccK8SClusterGetLatestK8SVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, diff --git a/internal/services/lb/acl_test.go b/internal/services/lb/acl_test.go index 656147373c..673eafb428 100644 --- a/internal/services/lb/acl_test.go +++ b/internal/services/lb/acl_test.go @@ -15,6 +15,7 @@ import ( func TestAccAcl_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/acls_data_source_test.go b/internal/services/lb/acls_data_source_test.go index 69d79d4364..613ee589f9 100644 --- a/internal/services/lb/acls_data_source_test.go +++ b/internal/services/lb/acls_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceACLs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/backend_data_source_test.go b/internal/services/lb/backend_data_source_test.go index 47000f0dbc..5c3495a456 100644 --- a/internal/services/lb/backend_data_source_test.go +++ b/internal/services/lb/backend_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceBackend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/backend_test.go b/internal/services/lb/backend_test.go index 8061adfc4b..bad2dacb37 100644 --- a/internal/services/lb/backend_test.go +++ b/internal/services/lb/backend_test.go @@ -17,6 +17,7 @@ import ( func TestAccBackend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -134,6 +135,7 @@ func TestAccBackend_Basic(t *testing.T) { func TestAccBackend_HealthCheck(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -239,6 +241,7 @@ func TestAccBackend_WithFailoverHost(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -385,6 +388,7 @@ func TestAccBackend_WithFailoverHost(t *testing.T) { func TestAccBackend_HealthCheck_Port(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/backends_data_source_test.go b/internal/services/lb/backends_data_source_test.go index 1128ed4193..5b3dc93741 100644 --- a/internal/services/lb/backends_data_source_test.go +++ b/internal/services/lb/backends_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceBackends_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/certificate_data_source_test.go b/internal/services/lb/certificate_data_source_test.go index 3633c929cb..b4884ac62f 100644 --- a/internal/services/lb/certificate_data_source_test.go +++ b/internal/services/lb/certificate_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceCertificate_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/certificate_test.go b/internal/services/lb/certificate_test.go index c77d6a6b23..1cd70cf12f 100644 --- a/internal/services/lb/certificate_test.go +++ b/internal/services/lb/certificate_test.go @@ -23,6 +23,7 @@ func TestAccCertificate_Basic(t *testing.T) { */ tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/data_source_lb_frontends_test.go b/internal/services/lb/data_source_lb_frontends_test.go index 785c45160a..e5e0c7edf9 100644 --- a/internal/services/lb/data_source_lb_frontends_test.go +++ b/internal/services/lb/data_source_lb_frontends_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceFrontends_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/data_source_lb_ip_test.go b/internal/services/lb/data_source_lb_ip_test.go index 330e63f805..225698fe82 100644 --- a/internal/services/lb/data_source_lb_ip_test.go +++ b/internal/services/lb/data_source_lb_ip_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/frontend_data_source_test.go b/internal/services/lb/frontend_data_source_test.go index 25df49a6f7..d7457547f3 100644 --- a/internal/services/lb/frontend_data_source_test.go +++ b/internal/services/lb/frontend_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceFrontend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/frontend_test.go b/internal/services/lb/frontend_test.go index d97534b5c2..e5259b82ed 100644 --- a/internal/services/lb/frontend_test.go +++ b/internal/services/lb/frontend_test.go @@ -20,6 +20,7 @@ import ( func TestAccFrontend_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -248,6 +249,7 @@ func isFrontendDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { func TestAccFrontend_ACLBasic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -460,6 +462,7 @@ func TestAccFrontend_ACLBasic(t *testing.T) { func TestAccFrontend_ACLRedirectAction(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/ip_test.go b/internal/services/lb/ip_test.go index 5faa5c7b84..76a6849e17 100644 --- a/internal/services/lb/ip_test.go +++ b/internal/services/lb/ip_test.go @@ -15,6 +15,7 @@ import ( func TestAccIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -82,6 +83,7 @@ func TestAccIP_Basic(t *testing.T) { func TestAccIP_IPv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -106,6 +108,7 @@ func TestAccIP_IPv6(t *testing.T) { func TestAccIP_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/ips_data_source_test.go b/internal/services/lb/ips_data_source_test.go index 7037a7b391..9012ed09f8 100644 --- a/internal/services/lb/ips_data_source_test.go +++ b/internal/services/lb/ips_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceIPs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -55,6 +56,7 @@ func TestAccDataSourceIPs_Basic(t *testing.T) { func TestAccDataSourceIPs_WithType(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -115,6 +117,7 @@ func TestAccDataSourceIPs_WithType(t *testing.T) { func TestAccDataSourceIPs_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/lb_data_source_test.go b/internal/services/lb/lb_data_source_test.go index 25333ac565..9ff2a30ed7 100644 --- a/internal/services/lb/lb_data_source_test.go +++ b/internal/services/lb/lb_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceLb_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/lb_test.go b/internal/services/lb/lb_test.go index e4195dd0b3..278c681d24 100644 --- a/internal/services/lb/lb_test.go +++ b/internal/services/lb/lb_test.go @@ -19,6 +19,7 @@ import ( func TestAccLB_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -77,6 +78,7 @@ func TestAccLB_Basic(t *testing.T) { func TestAccLB_Private(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -132,6 +134,7 @@ func TestAccLB_Private(t *testing.T) { func TestAccLB_AssignedIPs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -163,6 +166,7 @@ func TestAccLB_AssignedIPs(t *testing.T) { func TestAccLB_WithIPv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -202,6 +206,7 @@ func TestAccLB_WithIPv6(t *testing.T) { func TestAccLB_UpdateToIPv6(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -361,6 +366,7 @@ func TestAccLB_Migrate(t *testing.T) { func TestAccLB_WithPrivateNetworksIPAMIDs(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -429,6 +435,7 @@ func TestAccLB_WithPrivateNetworksIPAMIDs(t *testing.T) { func TestAccLB_WithoutPNConfig(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -470,6 +477,7 @@ func TestAccLB_WithoutPNConfig(t *testing.T) { func TestAccLB_DifferentLocalityIPID(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/lbs_data_source_test.go b/internal/services/lb/lbs_data_source_test.go index bcaa0a94b9..4584961f27 100644 --- a/internal/services/lb/lbs_data_source_test.go +++ b/internal/services/lb/lbs_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceLbs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/route_data_source_test.go b/internal/services/lb/route_data_source_test.go index 64e338e8b0..6bd3456585 100644 --- a/internal/services/lb/route_data_source_test.go +++ b/internal/services/lb/route_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceRoute_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/route_test.go b/internal/services/lb/route_test.go index c97939194b..a5a90c329e 100644 --- a/internal/services/lb/route_test.go +++ b/internal/services/lb/route_test.go @@ -15,6 +15,7 @@ import ( func TestAccRoute_WithSNI(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -94,6 +95,7 @@ func TestAccRoute_WithSNI(t *testing.T) { func TestAccRoute_WithHostHeader(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -138,6 +140,7 @@ func TestAccRoute_WithHostHeader(t *testing.T) { func TestAccRoute_WithPathBegin(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/lb/routes_data_source_test.go b/internal/services/lb/routes_data_source_test.go index 61edc5433c..4ede5949c7 100644 --- a/internal/services/lb/routes_data_source_test.go +++ b/internal/services/lb/routes_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceRoutes_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/marketplace/image_data_source_test.go b/internal/services/marketplace/image_data_source_test.go index 36ae355528..df42c0a17e 100644 --- a/internal/services/marketplace/image_data_source_test.go +++ b/internal/services/marketplace/image_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceMarketplaceImage_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -34,6 +35,7 @@ func TestAccDataSourceMarketplaceImage_Basic(t *testing.T) { func TestAccDataSourceMarketplaceImage_SBS(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/mnq/nats_account_test.go b/internal/services/mnq/nats_account_test.go index eaf4340274..ec2ba0f45a 100644 --- a/internal/services/mnq/nats_account_test.go +++ b/internal/services/mnq/nats_account_test.go @@ -82,7 +82,6 @@ func isNatsAccountDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NatsAccountID: id, Region: region, }) - if err == nil { return fmt.Errorf("mnq nats account (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/mnq/nats_credentials_test.go b/internal/services/mnq/nats_credentials_test.go index 2629c3f6fc..777b97d35a 100644 --- a/internal/services/mnq/nats_credentials_test.go +++ b/internal/services/mnq/nats_credentials_test.go @@ -139,7 +139,6 @@ func isNatsCredentialsDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NatsCredentialsID: id, Region: region, }) - if err == nil { return fmt.Errorf("mnq nats credentials (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/mnq/sns_credentials_test.go b/internal/services/mnq/sns_credentials_test.go index 26d0ed924f..a9aa4675ab 100644 --- a/internal/services/mnq/sns_credentials_test.go +++ b/internal/services/mnq/sns_credentials_test.go @@ -142,7 +142,6 @@ func isSNSCredentialsDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { SnsCredentialsID: id, Region: region, }) - if err == nil { return fmt.Errorf("mnq sns credentials (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/mnq/sns_data_source_test.go b/internal/services/mnq/sns_data_source_test.go index 2df7877d90..a09dfb110f 100644 --- a/internal/services/mnq/sns_data_source_test.go +++ b/internal/services/mnq/sns_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceSNS_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/mnq/sqs_credentials_test.go b/internal/services/mnq/sqs_credentials_test.go index 89ebc3db90..144404cc09 100644 --- a/internal/services/mnq/sqs_credentials_test.go +++ b/internal/services/mnq/sqs_credentials_test.go @@ -142,7 +142,6 @@ func isSQSCredentialsDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { SqsCredentialsID: id, Region: region, }) - if err == nil { return fmt.Errorf("mnq sqs credentials (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/mnq/sqs_data_source_test.go b/internal/services/mnq/sqs_data_source_test.go index 41a6d90f7a..7eadc3e8bf 100644 --- a/internal/services/mnq/sqs_data_source_test.go +++ b/internal/services/mnq/sqs_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceSQS_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/mongodb/instance_test.go b/internal/services/mongodb/instance_test.go index 46729bda4f..244ebbdf67 100644 --- a/internal/services/mongodb/instance_test.go +++ b/internal/services/mongodb/instance_test.go @@ -516,7 +516,6 @@ func IsInstanceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { InstanceID: ID, Region: extractRegion, }) - if err == nil { return fmt.Errorf("instance (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/rdb/snapshots_test.go b/internal/services/rdb/snapshots_test.go index d63832e519..7c3a4f01e7 100644 --- a/internal/services/rdb/snapshots_test.go +++ b/internal/services/rdb/snapshots_test.go @@ -136,7 +136,6 @@ func IsSnapshotDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { SnapshotID: ID, Region: region, }) - if err == nil { return fmt.Errorf("snapshot (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/redis/cluster_data_source_test.go b/internal/services/redis/cluster_data_source_test.go index 85e8a300c1..6c8c566ccb 100644 --- a/internal/services/redis/cluster_data_source_test.go +++ b/internal/services/redis/cluster_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceCluster_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, diff --git a/internal/services/redis/cluster_test.go b/internal/services/redis/cluster_test.go index 460f6cf532..775e3c3e87 100644 --- a/internal/services/redis/cluster_test.go +++ b/internal/services/redis/cluster_test.go @@ -88,6 +88,7 @@ func TestAccCluster_Basic(t *testing.T) { func TestAccCluster_Migrate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -151,6 +152,7 @@ func TestAccCluster_Migrate(t *testing.T) { func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) clusterID := "" resource.ParallelTest(t, resource.TestCase{ @@ -235,6 +237,7 @@ func TestAccCluster_MigrateClusterSizeWithIPAMEndpoint(t *testing.T) { func TestAccCluster_ACL(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -311,6 +314,7 @@ func TestAccCluster_ACL(t *testing.T) { func TestAccCluster_Settings(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -387,6 +391,7 @@ func TestAccCluster_Endpoints_Standalone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -579,6 +584,7 @@ func TestAccCluster_Endpoints_Standalone(t *testing.T) { func TestAccCluster_Endpoints_ClusterMode(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -645,6 +651,7 @@ func TestAccCluster_Endpoints_ClusterMode(t *testing.T) { func TestAccCluster_Certificate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -686,6 +693,7 @@ func TestAccCluster_Certificate(t *testing.T) { func TestAccCluster_NoCertificate(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, @@ -727,6 +735,7 @@ func TestAccCluster_NoCertificate(t *testing.T) { func TestAccCluster_MigrateToHAMode(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + latestRedisVersion := getLatestVersion(tt) resource.ParallelTest(t, resource.TestCase{ @@ -774,7 +783,6 @@ func isClusterDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { ClusterID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf("cluster (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/registry/namespace_test.go b/internal/services/registry/namespace_test.go index 655828f756..a7c7517e83 100644 --- a/internal/services/registry/namespace_test.go +++ b/internal/services/registry/namespace_test.go @@ -94,7 +94,6 @@ func isNamespaceDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { NamespaceID: id, Region: region, }) - if err == nil { return fmt.Errorf("namespace (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/sdb/database_test.go b/internal/services/sdb/database_test.go index 5ea2dc2b09..c2dc492c52 100644 --- a/internal/services/sdb/database_test.go +++ b/internal/services/sdb/database_test.go @@ -123,7 +123,6 @@ func testAccCheckServerlessSQLDBDatabaseDestroy(tt *acctest.TestTools) resource. DatabaseID: id, Region: region, }) - if err == nil { return fmt.Errorf("serverless_sql database (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/secret/secret_test.go b/internal/services/secret/secret_test.go index 417dc8f82b..842012419b 100644 --- a/internal/services/secret/secret_test.go +++ b/internal/services/secret/secret_test.go @@ -330,7 +330,6 @@ func testAccCheckSecretDestroy(tt *acctest.TestTools) resource.TestCheckFunc { SecretID: id, Region: region, }) - if err == nil { return fmt.Errorf("secret (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/secret/version_test.go b/internal/services/secret/version_test.go index 11187b1bd6..573423d62b 100644 --- a/internal/services/secret/version_test.go +++ b/internal/services/secret/version_test.go @@ -213,7 +213,6 @@ func testAccCheckSecretVersionDestroy(tt *acctest.TestTools) resource.TestCheckF Region: region, Revision: revision, }) - if err == nil { return fmt.Errorf("secret version (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/tem/offer_subscription_data_source_test.go b/internal/services/tem/offer_subscription_data_source_test.go index 0a917cbae3..9c086b2a02 100644 --- a/internal/services/tem/offer_subscription_data_source_test.go +++ b/internal/services/tem/offer_subscription_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceOfferSubscription_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + orgID, orgIDExists := tt.Meta.ScwClient().GetDefaultOrganizationID() if !orgIDExists { diff --git a/internal/services/vpc/acl_test.go b/internal/services/vpc/acl_test.go index 046afe8841..d8c30a6837 100644 --- a/internal/services/vpc/acl_test.go +++ b/internal/services/vpc/acl_test.go @@ -15,6 +15,7 @@ import ( func TestAccACL_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -64,6 +65,7 @@ func TestAccACL_Basic(t *testing.T) { func TestAccACL_WithRules(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -224,7 +226,6 @@ func isACLDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { VpcID: ID, Region: region, }) - if err == nil { return fmt.Errorf("acl (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/vpc/private_network_data_source_test.go b/internal/services/vpc/private_network_data_source_test.go index c9a2c8523c..45371c5390 100644 --- a/internal/services/vpc/private_network_data_source_test.go +++ b/internal/services/vpc/private_network_data_source_test.go @@ -80,6 +80,7 @@ func TestAccDataSourceVPCPrivateNetwork_Basic(t *testing.T) { func TestAccDataSourceVPCPrivateNetwork_VpcID(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpc/private_network_test.go b/internal/services/vpc/private_network_test.go index 82c809c2d1..10700bab68 100644 --- a/internal/services/vpc/private_network_test.go +++ b/internal/services/vpc/private_network_test.go @@ -87,6 +87,7 @@ func TestAccVPCPrivateNetwork_Basic(t *testing.T) { func TestAccVPCPrivateNetwork_DefaultName(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -109,6 +110,7 @@ func TestAccVPCPrivateNetwork_DefaultName(t *testing.T) { func TestAccVPCPrivateNetwork_Subnets(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -214,6 +216,7 @@ func TestAccVPCPrivateNetwork_Subnets(t *testing.T) { func TestAccVPCPrivateNetwork_OneSubnet(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpc/route_test.go b/internal/services/vpc/route_test.go index 77801c5759..23df4ac08f 100644 --- a/internal/services/vpc/route_test.go +++ b/internal/services/vpc/route_test.go @@ -15,6 +15,7 @@ import ( func TestAccVPCRoute_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -164,7 +165,6 @@ func isRouteDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { RouteID: ID, Region: region, }) - if err == nil { return fmt.Errorf("route (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/vpc/routes_data_source_test.go b/internal/services/vpc/routes_data_source_test.go index 0acaa6eeb5..cf86243de7 100644 --- a/internal/services/vpc/routes_data_source_test.go +++ b/internal/services/vpc/routes_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceRoutes_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpc/testfuncs/checks.go b/internal/services/vpc/testfuncs/checks.go index 652040dffa..45e00668e5 100644 --- a/internal/services/vpc/testfuncs/checks.go +++ b/internal/services/vpc/testfuncs/checks.go @@ -27,7 +27,6 @@ func CheckPrivateNetworkDestroy(tt *acctest.TestTools) resource.TestCheckFunc { PrivateNetworkID: ID, Region: region, }) - if err == nil { return fmt.Errorf( "VPC private network %s still exists", diff --git a/internal/services/vpc/vpc_data_source_test.go b/internal/services/vpc/vpc_data_source_test.go index fdb2b58fe9..9877039b60 100644 --- a/internal/services/vpc/vpc_data_source_test.go +++ b/internal/services/vpc/vpc_data_source_test.go @@ -51,6 +51,7 @@ func TestAccDataSourceVPC_Basic(t *testing.T) { func TestAccDataSourceVPC_Default(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpc/vpc_test.go b/internal/services/vpc/vpc_test.go index ce1aa90d19..9c6981231b 100644 --- a/internal/services/vpc/vpc_test.go +++ b/internal/services/vpc/vpc_test.go @@ -16,6 +16,7 @@ import ( func TestAccVPC_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -44,6 +45,7 @@ func TestAccVPC_Basic(t *testing.T) { func TestAccVPC_WithRegion(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -79,6 +81,7 @@ func TestAccVPC_WithRegion(t *testing.T) { func TestAccVPC_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -116,6 +119,7 @@ func TestAccVPC_WithTags(t *testing.T) { func TestAccVPC_DisableRouting(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, @@ -185,7 +189,6 @@ func testAccCheckVPCDestroy(tt *acctest.TestTools) resource.TestCheckFunc { VpcID: ID, Region: region, }) - if err == nil { return fmt.Errorf("VPC (%s) still exists", rs.Primary.ID) } diff --git a/internal/services/vpc/vpcs_data_source_test.go b/internal/services/vpc/vpcs_data_source_test.go index 054247719d..a2e0c8d8a6 100644 --- a/internal/services/vpc/vpcs_data_source_test.go +++ b/internal/services/vpc/vpcs_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceVPCs_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpcgw/ip_test.go b/internal/services/vpcgw/ip_test.go index 8afc5c4c53..3b214855dd 100644 --- a/internal/services/vpcgw/ip_test.go +++ b/internal/services/vpcgw/ip_test.go @@ -15,6 +15,7 @@ import ( func TestAccVPCPublicGatewayIP_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: vpcgwchecks.IsIPDestroyed(tt), @@ -37,6 +38,7 @@ func TestAccVPCPublicGatewayIP_Basic(t *testing.T) { func TestAccVPCPublicGatewayIP_WithZone(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: vpcgwchecks.IsIPDestroyed(tt), @@ -68,6 +70,7 @@ func TestAccVPCPublicGatewayIP_WithZone(t *testing.T) { func TestAccVPCPublicGatewayIP_WithTags(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ ProviderFactories: tt.ProviderFactories, CheckDestroy: vpcgwchecks.IsIPDestroyed(tt), diff --git a/internal/services/vpcgw/network_data_source_test.go b/internal/services/vpcgw/network_data_source_test.go index 3f8dcfc2cb..6c3672eb7b 100644 --- a/internal/services/vpcgw/network_data_source_test.go +++ b/internal/services/vpcgw/network_data_source_test.go @@ -11,6 +11,7 @@ import ( func TestAccDataSourceVPCGatewayNetwork_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpcgw/network_test.go b/internal/services/vpcgw/network_test.go index a9b8cef154..93a06259e5 100644 --- a/internal/services/vpcgw/network_test.go +++ b/internal/services/vpcgw/network_test.go @@ -16,6 +16,7 @@ import ( func TestAccVPCGatewayNetwork_WithIPAMConfig(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/vpcgw/pat_rule_test.go b/internal/services/vpcgw/pat_rule_test.go index 8df1ceddfd..471726a66c 100644 --- a/internal/services/vpcgw/pat_rule_test.go +++ b/internal/services/vpcgw/pat_rule_test.go @@ -131,7 +131,6 @@ func testAccCheckVPCPublicGatewayPATRuleDestroy(tt *acctest.TestTools) resource. PatRuleID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC public gateway pat rule %s still exists", diff --git a/internal/services/vpcgw/testfuncs/checks.go b/internal/services/vpcgw/testfuncs/checks.go index dfb8154b91..ed18eeb3d2 100644 --- a/internal/services/vpcgw/testfuncs/checks.go +++ b/internal/services/vpcgw/testfuncs/checks.go @@ -28,7 +28,6 @@ func IsGatewayNetworkDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { GatewayNetworkID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC gateway network %s still exists", @@ -62,7 +61,6 @@ func IsGatewayDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { GatewayID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC public gateway %s still exists", @@ -96,7 +94,6 @@ func IsDHCPDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { DHCPID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC public gateway DHCP config %s still exists", @@ -130,7 +127,6 @@ func IsIPDestroyed(tt *acctest.TestTools) resource.TestCheckFunc { IPID: ID, Zone: zone, }) - if err == nil { return fmt.Errorf( "VPC public gateway ip %s still exists", diff --git a/internal/services/webhosting/offer_data_source_test.go b/internal/services/webhosting/offer_data_source_test.go index 838a64234f..5e9d72a4db 100644 --- a/internal/services/webhosting/offer_data_source_test.go +++ b/internal/services/webhosting/offer_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceOffer_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/services/webhosting/webhosting_data_source_test.go b/internal/services/webhosting/webhosting_data_source_test.go index e009d1c0c0..4d311de482 100644 --- a/internal/services/webhosting/webhosting_data_source_test.go +++ b/internal/services/webhosting/webhosting_data_source_test.go @@ -10,6 +10,7 @@ import ( func TestAccDataSourceWebhosting_Basic(t *testing.T) { tt := acctest.NewTestTools(t) defer tt.Cleanup() + resource.ParallelTest(t, resource.TestCase{ PreCheck: func() { acctest.PreCheck(t) }, ProviderFactories: tt.ProviderFactories, diff --git a/internal/verify/enum.go b/internal/verify/enum.go index b8ab03b0dd..a1913405cc 100644 --- a/internal/verify/enum.go +++ b/internal/verify/enum.go @@ -28,6 +28,7 @@ func ValidateEnumIgnoreCase[T EnumValues[T]]() schema.SchemaValidateDiagFunc { func getValues[T EnumValues[T]]() []string { var t T + values := t.Values() result := make([]string, len(values)) diff --git a/internal/workerpool/workerpool.go b/internal/workerpool/workerpool.go index 936b532819..8c0fa4d2ca 100644 --- a/internal/workerpool/workerpool.go +++ b/internal/workerpool/workerpool.go @@ -29,6 +29,7 @@ func NewWorkerPool(size int) *WorkerPool { func (p *WorkerPool) AddTask(task Task) { p.tasksWaitingGroup.Add(1) + p.tasksToDispatch <- task } From 2c24049a7d94c776d5007c4fa0027e8e8abe818a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9my=20L=C3=A9one?= Date: Thu, 21 Aug 2025 12:17:17 +0200 Subject: [PATCH 3/3] add issues: write --- .github/workflows/labeler.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index 88ca10f07f..dd6f5401f0 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -7,6 +7,7 @@ jobs: permissions: contents: read pull-requests: write + issues: write runs-on: ubuntu-latest steps: - name: Checkout