-
Notifications
You must be signed in to change notification settings - Fork 133
feat(mnq/sqs): support for dead_letter_queue #3293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ee64d24 to
e1e2058
Compare
8e6788b to
f97b0a8
Compare
internal/services/mnq/helpers_mnq.go
Outdated
| s = resourceValue.(string) | ||
| case schema.TypeList: | ||
| // Handle dead-letter queue configuration | ||
| if resourcePath == "dead_letter_queue" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be a const?
internal/services/mnq/helpers_mnq.go
Outdated
| var scwARN string | ||
|
|
||
| switch { | ||
| case strings.HasPrefix(queueID, "arn:scw:sqs:"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could it be a const?
internal/services/mnq/helpers_mnq.go
Outdated
|
|
||
| var terraformID string | ||
|
|
||
| if strings.HasPrefix(deadLetterTargetArn, "arn:scw:sqs:") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be a const?
internal/services/mnq/helpers_mnq.go
Outdated
| case schema.TypeString: | ||
| setResourceValue(values, resourcePath, value, resourceSchemas) | ||
| case schema.TypeList: | ||
| if resourcePath == "dead_letter_queue" && value != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could it be a const?
45f4027 to
e2ee5e2
Compare
bd47561 to
a229a20
Compare
a229a20 to
d8fd87c
Compare
close 3261