Skip to content

Conversation

@jremy42
Copy link
Contributor

@jremy42 jremy42 commented Sep 2, 2025

close 3261

@github-actions github-actions bot added the mnq Messaging and queuing issues, bugs and feature requests label Sep 2, 2025
@jremy42 jremy42 force-pushed the feat/mnq-sqs-dlq-arn-id-normalization branch 5 times, most recently from ee64d24 to e1e2058 Compare September 2, 2025 09:35
@github-actions github-actions bot added container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests labels Sep 2, 2025
@jremy42 jremy42 marked this pull request as ready for review September 2, 2025 09:40
@jremy42 jremy42 requested review from a team as code owners September 2, 2025 09:40
@jremy42 jremy42 force-pushed the feat/mnq-sqs-dlq-arn-id-normalization branch from 8e6788b to f97b0a8 Compare September 2, 2025 13:27
s = resourceValue.(string)
case schema.TypeList:
// Handle dead-letter queue configuration
if resourcePath == "dead_letter_queue" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be a const?

var scwARN string

switch {
case strings.HasPrefix(queueID, "arn:scw:sqs:"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could it be a const?


var terraformID string

if strings.HasPrefix(deadLetterTargetArn, "arn:scw:sqs:") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be a const?

case schema.TypeString:
setResourceValue(values, resourcePath, value, resourceSchemas)
case schema.TypeList:
if resourcePath == "dead_letter_queue" && value != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be a const?

@jremy42 jremy42 force-pushed the feat/mnq-sqs-dlq-arn-id-normalization branch from 45f4027 to e2ee5e2 Compare September 3, 2025 15:15
@jremy42 jremy42 self-assigned this Sep 4, 2025
@jremy42 jremy42 force-pushed the feat/mnq-sqs-dlq-arn-id-normalization branch from bd47561 to a229a20 Compare September 4, 2025 04:12
@jremy42 jremy42 force-pushed the feat/mnq-sqs-dlq-arn-id-normalization branch from a229a20 to d8fd87c Compare September 4, 2025 07:41
@remyleone remyleone added this pull request to the merge queue Sep 4, 2025
Merged via the queue into master with commit 79725fd Sep 4, 2025
52 checks passed
@remyleone remyleone deleted the feat/mnq-sqs-dlq-arn-id-normalization branch September 4, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

container Container issues, bugs and feature requests function Serverless function issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Terraform support for Dead Letter Queue (DLQ) in scaleway_mnq_sqs_queue SQS: Add support for dead-letter queue configuration

3 participants