tests: handle v4 cassettes in vcr-compressor #3430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3430 +/- ##
=========================================
+ Coverage 1.66% 1.77% +0.11%
=========================================
Files 391 391
Lines 43262 43325 +63
=========================================
+ Hits 720 770 +50
- Misses 42459 42467 +8
- Partials 83 88 +5 ☔ View full report in Codecov by Sentry. |
remyleone
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR duplicates the
acctest.CompressCassettefunction intoacctest.CompressCassetteV3andacctest.CompressCassetteV4in order to be able to handle both v3 and v4 cassettes.It also re-records the cassettes from the instance package that were previously overwritten in v3 when they should have been using v4.