Skip to content

Commit 1e0eeaf

Browse files
authored
fix: add error message on code editor (#5479)
1 parent 1e2d2e6 commit 1e0eeaf

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

.changeset/pretty-webs-share.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@ultraviolet/plus": patch
3+
---
4+
5+
Add error message on Code editor

packages/plus/src/components/CodeEditor/CodeEditor.tsx

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ const EditorContainer = styled.div`
8080
8181
.cm-editor.cm-focused {
8282
box-shadow: none;
83-
border: 1px solid transparent;
83+
border: 1px solid transparent;
8484
}
8585
}
8686
`
@@ -125,6 +125,7 @@ type CodeEditorProps = {
125125
'aria-label'?: string
126126
'data-testid'?: string
127127
className?: string
128+
error?: string
128129
}
129130

130131
export const CodeEditor = ({
@@ -144,6 +145,7 @@ export const CodeEditor = ({
144145
'aria-label': ariaLabel,
145146
'data-testid': dataTestId,
146147
className,
148+
error,
147149
}: CodeEditorProps) => (
148150
<StyledStack data-disabled={disabled} gap={0.5}>
149151
{label ? <Label labelDescription={labelDescription}>{label}</Label> : null}
@@ -185,7 +187,12 @@ export const CodeEditor = ({
185187
</StyledCopyButton>
186188
) : null}
187189
</EditorContainer>
188-
{helper ? (
190+
{error && typeof error !== 'boolean' ? (
191+
<Text as="span" sentiment="danger" variant="caption">
192+
{error}
193+
</Text>
194+
) : null}
195+
{!error && helper ? (
189196
<Text as="span" prominence="weak" sentiment="neutral" variant="caption">
190197
{helper}
191198
</Text>

0 commit comments

Comments
 (0)