fix: useless spacing classname on banner and button (#5488)

Author: matthprost

.changeset/breezy-hounds-bake.md

@@ -0,0 +1,5 @@
+---
+"@ultraviolet/ui": patch
+---
+
+Fix className useless spacing on Banner and Button

packages/ui/src/components/Banner/index.tsx

@@ -75,7 +75,7 @@ export const Banner = ({
 
   return (
     <Stack
-      className={`${className ?? ''} ${banner({ size, variant })}`}
+      className={`${className ? `${className} ` : ''}${banner({ size, variant })}`}
       data-testid={dataTestId}
       direction="row"
       gap={2}

packages/ui/src/components/Button/__tests__/__snapshots__/index.test.tsx.snap

@@ -7,7 +7,7 @@ exports[`Button > render as an anchor with href prop 1`] = `
   >
     <a
       aria-disabled="false"
-      class=" styles__e1wcoe0 styles_size_large__e1wcoe1 styles_fullWidth_false__e1wcoe6 styles_disabled_false__e1wcoek styles_variant_filled__e1wcoeg styles_sentiment_primary__e1wcoe7 styles_undefined_compound_0__e1wcoel"
+      class="styles__e1wcoe0 styles_size_large__e1wcoe1 styles_fullWidth_false__e1wcoe6 styles_disabled_false__e1wcoek styles_variant_filled__e1wcoeg styles_sentiment_primary__e1wcoe7 styles_undefined_compound_0__e1wcoel"
       href="http://scaleway.com"
       type="button"
     >

packages/ui/src/components/Button/index.tsx

@@ -140,7 +140,7 @@ export const Button = forwardRef<Element, FinalProps>(
             aria-pressed={ariaPressed}
             aria-roledescription={ariaRoledescription}
             autoFocus={autoFocus}
-            className={`${className ?? ''} ${button({ disabled, fullWidth, sentiment, size, variant })}`}
+            className={`${className ? `${className} ` : ''}${button({ disabled, fullWidth, sentiment, size, variant })}`}
             data-testid={dataTestId}
             download={download}
             href={href}