fix: recompute popup position (#5789)

lisalupi · web-flow · commit 63a8f2a32a80 · 2025-11-19T16:52:30.000+01:00
diff --git a/.changeset/free-seals-pay.md b/.changeset/free-seals-pay.md
@@ -0,0 +1,5 @@
+---
+"@ultraviolet/ui": patch
+---
+
+`Popup`: position is recomputed when children changes
diff --git a/packages/ui/src/components/Popup/index.tsx b/packages/ui/src/components/Popup/index.tsx
@@ -239,7 +239,7 @@ export const Popup = forwardRef(
           }),
         )
       }
-    }, [hasArrow, placement, popupPortalTarget, align])
+    }, [hasArrow, placement, popupPortalTarget, align, children])
 
     /**
      * This function is called when we need to recompute positions of popup due to window scroll or resize.

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@ultraviolet/ui": patch
 +---
++
 +`Popup`: position is recomputed when children changes
Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ export const Popup = forwardRef(`
`239`	`239`	`}),`
`240`	`240`	`)`
`241`	`241`	`}`
`242`		`- }, [hasArrow, placement, popupPortalTarget, align])`
	`242`	`+ }, [hasArrow, placement, popupPortalTarget, align, children])`
`243`	`243`
`244`	`244`	`/**`
`245`	`245`	`* This function is called when we need to recompute positions of popup due to window scroll or resize.`