Skip to content

Commit 89ccfa0

Browse files
lisalupilisalupi
authored
refactor: reduce complexity (#6182)
* refactor: select input complexity * refactor: reduce more complexities * refactor: more refacto * fix: format * fix: more improvements
1 parent a219be7 commit 89ccfa0

File tree

195 files changed

+8667
-7834
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

195 files changed

+8667
-7834
lines changed

‎examples/next/src/pages/login/login.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ const LogIn = () => {
4040
)
4141
setTimeout(() => setLoginText(''), 3000)
4242

43-
// oxlint-disable-next-line eslint/no-console
4443
console.log('Values :', values)
4544
}
4645

‎examples/vite/src/main.tsx‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import { createRoot } from 'react-dom/client'
33

44
import { App } from './App.tsx'
55

6-
// oxlint-disable @typescript-eslint/no-non-null-assertion: not an error
76
const root = createRoot(document.getElementById('root')!)
87

98
root.render(

‎packages/form/src/components/CheckboxGroupField/__tests__/index.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ describe('checkboxField', () => {
6464
expect(input).toBeChecked()
6565

6666
await userEvent.click(input)
67-
expect(onChange).toBeCalledTimes(2)
67+
expect(onChange).toHaveBeenCalledTimes(2)
6868
expect(input).not.toBeChecked()
6969

7070
expect(asFragment()).toMatchSnapshot()

‎packages/form/src/components/DateInputField/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 182 additions & 187 deletions
Large diffs are not rendered by default.

‎packages/form/src/components/DateInputField/__tests__/index.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ describe('dateInputField', () => {
7373
await userEvent.click(screen.getByText('15'))
7474

7575
await waitFor(() => {
76-
expect(onChange).toBeCalledTimes(2)
76+
expect(onChange).toHaveBeenCalledTimes(2)
7777
})
7878

7979
expect(resultForm.current.getValues('test')).toEqual([

‎packages/form/src/components/SelectInputField/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 52 additions & 52 deletions
Large diffs are not rendered by default.

‎packages/form/src/components/SelectableCardGroupField/__tests__/index.test.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ describe('selectableCardField', () => {
8383
await userEvent.click(input)
8484
expect(onChange).toHaveBeenCalledOnce()
8585
await userEvent.click(input)
86-
expect(onChange).toBeCalledTimes(2)
86+
expect(onChange).toHaveBeenCalledTimes(2)
8787
expect(asFragment()).toMatchSnapshot()
8888
})
8989
})

‎packages/form/src/components/SelectableCardOptionGroupField/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
136136
<div
137137
aria-controls="_r_7_"
138138
aria-expanded="false"
139-
class="uv_1ba7knd6 uv_1ba7knd5 uv_1ba7kndb uv_1ba7knde"
139+
class="uv_r8qe46 uv_r8qe45 uv_r8qe4b uv_r8qe4e"
140140
data-disabled="false"
141141
data-readonly="false"
142142
data-testid="select-input-selectable-card-option"
@@ -145,12 +145,12 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
145145
tabindex="0"
146146
>
147147
<span
148-
class="uv_1ba7kndm uv_m4c9ow0 uv_m4c9ow4 uv_m4c9owb uv_m4c9owk uv_m4c9ow1a uv_m4c9ow32"
148+
class="uv_r8qe4m uv_m4c9ow0 uv_m4c9ow4 uv_m4c9owb uv_m4c9owk uv_m4c9ow1a uv_m4c9ow32"
149149
>
150150
Ubuntu 20.04 Focal Fossa
151151
</span>
152152
<div
153-
class="uv_1ba7knd3 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u3p"
153+
class="uv_r8qe43 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u3p"
154154
>
155155
<svg
156156
aria-label="show dropdown"
@@ -284,7 +284,7 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
284284
<div
285285
aria-controls="_r_h_"
286286
aria-expanded="false"
287-
class="uv_1ba7knd6 uv_1ba7knd5 uv_1ba7kndb uv_1ba7knde"
287+
class="uv_r8qe46 uv_r8qe45 uv_r8qe4b uv_r8qe4e"
288288
data-disabled="false"
289289
data-readonly="false"
290290
data-testid="select-input-selectable-card-option"
@@ -293,12 +293,12 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
293293
tabindex="0"
294294
>
295295
<span
296-
class="uv_1ba7knd4 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owk uv_m4c9ow1d uv_m4c9ow35"
296+
class="uv_r8qe44 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owk uv_m4c9ow1d uv_m4c9ow35"
297297
>
298298
Select item
299299
</span>
300300
<div
301-
class="uv_1ba7knd3 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u3p"
301+
class="uv_r8qe43 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u3p"
302302
>
303303
<svg
304304
aria-label="show dropdown"
@@ -432,7 +432,7 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
432432
<div
433433
aria-controls="_r_r_"
434434
aria-expanded="false"
435-
class="uv_1ba7knd6 uv_1ba7knd5 uv_1ba7kndb uv_1ba7knde"
435+
class="uv_r8qe46 uv_r8qe45 uv_r8qe4b uv_r8qe4e"
436436
data-disabled="false"
437437
data-readonly="false"
438438
data-testid="select-input-selectable-card-option"
@@ -441,12 +441,12 @@ exports[`selectableCardOptionGroupField > should render correctly 1`] = `
441441
tabindex="0"
442442
>
443443
<span
444-
class="uv_1ba7knd4 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owk uv_m4c9ow1d uv_m4c9ow35"
444+
class="uv_r8qe44 uv_m4c9ow0 uv_m4c9ow7 uv_m4c9owb uv_m4c9owk uv_m4c9ow1d uv_m4c9ow35"
445445
>
446446
Select item
447447
</span>
448448
<div
449-
class="uv_1ba7knd3 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u3p"
449+
class="uv_r8qe43 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u3p"
450450
>
451451
<svg
452452
aria-label="show dropdown"

‎packages/form/src/components/Submit/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,23 @@ exports[`submit > form is invalid 1`] = `
1818
>
1919
test
2020
</label>
21-
<div>
22-
<div
23-
class="uv_q3q8048 uv_q3q8045"
24-
data-disabled="false"
25-
data-error="false"
26-
data-has-focus="false"
27-
data-readonly="false"
28-
data-success="false"
29-
>
30-
<input
31-
aria-invalid="false"
32-
class="uv_q3q8049"
33-
data-size="large"
34-
id="_r_1_"
35-
name="toto"
36-
type="text"
37-
value="4"
38-
/>
39-
</div>
21+
<div
22+
class="uv_q3q8048 uv_q3q8045"
23+
data-disabled="false"
24+
data-error="false"
25+
data-has-focus="false"
26+
data-readonly="false"
27+
data-success="false"
28+
>
29+
<input
30+
aria-invalid="false"
31+
class="uv_q3q8049"
32+
data-size="large"
33+
id="_r_1_"
34+
name="toto"
35+
type="text"
36+
value="4"
37+
/>
4038
</div>
4139
</div>
4240
<button

‎packages/form/src/components/TextInputField/__tests__/__snapshots__/index.test.tsx.snap‎

Lines changed: 53 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -18,25 +18,23 @@ exports[`textInputField > should render correctly 1`] = `
1818
>
1919
Test
2020
</label>
21-
<div>
22-
<div
23-
class="uv_q3q8048 uv_q3q8045"
24-
data-disabled="false"
25-
data-error="false"
26-
data-has-focus="false"
27-
data-readonly="false"
28-
data-success="false"
29-
>
30-
<input
31-
aria-invalid="false"
32-
class="uv_q3q8049"
33-
data-size="large"
34-
id="_r_0_"
35-
name="test"
36-
type="text"
37-
value=""
38-
/>
39-
</div>
21+
<div
22+
class="uv_q3q8048 uv_q3q8045"
23+
data-disabled="false"
24+
data-error="false"
25+
data-has-focus="false"
26+
data-readonly="false"
27+
data-success="false"
28+
>
29+
<input
30+
aria-invalid="false"
31+
class="uv_q3q8049"
32+
data-size="large"
33+
id="_r_0_"
34+
name="test"
35+
type="text"
36+
value=""
37+
/>
4038
</div>
4139
</div>
4240
</form>
@@ -71,48 +69,46 @@ exports[`textInputField > should render correctly generated 1`] = `
7169
*
7270
</span>
7371
</div>
74-
<div>
72+
<div
73+
class="uv_q3q8048 uv_q3q8045"
74+
data-disabled="false"
75+
data-error="false"
76+
data-has-focus="false"
77+
data-readonly="false"
78+
data-success="false"
79+
>
80+
<input
81+
aria-invalid="false"
82+
class="uv_q3q8049"
83+
data-size="large"
84+
id="_r_3_"
85+
name="test"
86+
required=""
87+
type="text"
88+
value="This is an example"
89+
/>
7590
<div
76-
class="uv_q3q8048 uv_q3q8045"
77-
data-disabled="false"
78-
data-error="false"
79-
data-has-focus="false"
80-
data-readonly="false"
81-
data-success="false"
91+
class="uv_q3q8042 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u3p"
8292
>
83-
<input
84-
aria-invalid="false"
85-
class="uv_q3q8049"
86-
data-size="large"
87-
id="_r_3_"
88-
name="test"
89-
required=""
90-
type="text"
91-
value="This is an example"
92-
/>
93-
<div
94-
class="uv_q3q8042 uv_toi52u0 uv_toi52ud uv_toi52u2j uv_toi52u3p"
93+
<button
94+
aria-label="clear value"
95+
class="uv_e1wcoe0 uv_e1wcoe1 uv_e1wcoe3 uv_e1wcoe8 uv_e1wcoeg uv_e1wcoej uv_e1wcoe19"
96+
type="button"
9597
>
96-
<button
97-
aria-label="clear value"
98-
class="uv_e1wcoe0 uv_e1wcoe1 uv_e1wcoe3 uv_e1wcoe8 uv_e1wcoeg uv_e1wcoej uv_e1wcoe19"
99-
type="button"
98+
<svg
99+
class="uv_icons_1sbwqkz0 uv_icons_1sbwqkz1 uv_icons_1sbwqkz3 uv_icons_1sbwqkzg uv_icons_1sbwqkz1n"
100+
height="16"
101+
viewBox="0 0 16 16"
102+
width="16"
100103
>
101-
<svg
102-
class="uv_icons_1sbwqkz0 uv_icons_1sbwqkz1 uv_icons_1sbwqkz3 uv_icons_1sbwqkzg uv_icons_1sbwqkz1n"
103-
height="16"
104-
viewBox="0 0 16 16"
105-
width="16"
106-
>
107-
<title>
108-
CloseIcon
109-
</title>
110-
<path
111-
d="M5.28 4.22a.75.75 0 0 0-1.06 1.06L6.94 8l-2.72 2.72a.75.75 0 1 0 1.06 1.06L8 9.06l2.72 2.72a.75.75 0 1 0 1.06-1.06L9.06 8l2.72-2.72a.75.75 0 0 0-1.06-1.06L8 6.94z"
112-
/>
113-
</svg>
114-
</button>
115-
</div>
104+
<title>
105+
CloseIcon
106+
</title>
107+
<path
108+
d="M5.28 4.22a.75.75 0 0 0-1.06 1.06L6.94 8l-2.72 2.72a.75.75 0 1 0 1.06 1.06L8 9.06l2.72 2.72a.75.75 0 1 0 1.06-1.06L9.06 8l2.72-2.72a.75.75 0 0 0-1.06-1.06L8 6.94z"
109+
/>
110+
</svg>
111+
</button>
116112
</div>
117113
</div>
118114
</div>

0 commit comments

Comments
 (0)