Skip to content

Commit 91f8187

Browse files
chore(devdeps): update dependency eslint-plugin-oxlint to v0.18.1 (#5252)
* chore(devdeps): update dependency eslint-plugin-oxlint to v0.18.1 * fix: lint --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Matthias <[email protected]>
1 parent 40d4066 commit 91f8187

File tree

12 files changed

+34
-56
lines changed

12 files changed

+34
-56
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157
"emoji-toolkit": "9.0.1",
158158
"esbuild-plugin-browserslist": "1.0.1",
159159
"eslint": "9.29.0",
160-
"eslint-plugin-oxlint": "0.16.12",
160+
"eslint-plugin-oxlint": "0.18.1",
161161
"eslint-plugin-testing-library": "7.4.0",
162162
"expect": "29.7.0",
163163
"file-loader": "6.2.0",

packages/plus/src/components/Navigation/NavigationContent.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@ export const NavigationContent = ({
189189
sliderRef.current?.addEventListener('mousedown', mousedown)
190190

191191
return () => {
192-
// eslint-disable-next-line react-hooks/exhaustive-deps
193192
sliderRef.current?.removeEventListener('mousedown', mousedown)
194193
}
195194
}, [

packages/plus/src/components/Navigation/components/Item.tsx

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -392,15 +392,11 @@ export const Item = memo(
392392
animationType,
393393
} = context
394394

395-
useEffect(
396-
() => {
397-
if (type !== 'pinnedGroup' && pinnedFeature) {
398-
registerItem({ [id]: { label, active, onToggle, onClickPinUnpin } })
399-
}
400-
},
401-
// eslint-disable-next-line react-hooks/exhaustive-deps
402-
[active, id, label, registerItem],
403-
)
395+
useEffect(() => {
396+
if (type !== 'pinnedGroup' && pinnedFeature) {
397+
registerItem({ [id]: { label, active, onToggle, onClickPinUnpin } })
398+
}
399+
}, [active, id, label, registerItem])
404400

405401
const [internalExpanded, onToggleExpand] = useReducer(
406402
prevState => !prevState,

packages/ui/src/components/DateInput/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,6 @@ export const DateInput = <IsRange extends undefined | boolean>({
220220
end: endDate ?? computedRange.end,
221221
})
222222
}
223-
// eslint-disable-next-line react-hooks/exhaustive-deps
224223
}, [endDate, startDate, value])
225224

226225
const manageOnChange = (event: ChangeEvent<HTMLInputElement>) => {

packages/ui/src/components/List/ListContext.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -314,7 +314,6 @@ export const ListProvider = ({
314314
return () => {
315315
handlers.forEach(cleanup => cleanup())
316316
}
317-
// eslint-disable-next-line react-hooks/exhaustive-deps
318317
}, [lastCheckedCheckbox, selectRows])
319318

320319
useEffect(() => {

packages/ui/src/components/List/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@ const TableContainer = ({ children }: { children: ReactNode }) => {
6060
setRefList([])
6161
setChildrenMemory(Children.toArray(children))
6262
}
63-
// eslint-disable-next-line react-hooks/exhaustive-deps
6463
}, [children, setRefList])
6564

6665
return <TableContainerStyle>{children}</TableContainerStyle>

packages/ui/src/components/NumberInputV2/index.tsx

Lines changed: 18 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -297,37 +297,31 @@ export const NumberInputV2 = forwardRef(
297297
[localRef, min, onChange],
298298
)
299299

300-
const isMinusDisabled = useMemo(
301-
() => {
302-
if (!localRef?.current?.value || localRef?.current?.value === '') {
303-
return false
304-
}
300+
const isMinusDisabled = useMemo(() => {
301+
if (!localRef?.current?.value || localRef?.current?.value === '') {
302+
return false
303+
}
305304

306-
const numericValue = Number(localRef?.current?.value)
307-
if (Number.isNaN(numericValue)) return false
305+
const numericValue = Number(localRef?.current?.value)
306+
if (Number.isNaN(numericValue)) return false
308307

309-
const minValue = typeof min === 'number' ? min : Number(min)
308+
const minValue = typeof min === 'number' ? min : Number(min)
310309

311-
return Number.isNaN(numericValue) || numericValue <= minValue
312-
}, // eslint-disable-next-line react-hooks/exhaustive-deps
313-
[localRef?.current?.value, min],
314-
)
310+
return Number.isNaN(numericValue) || numericValue <= minValue
311+
}, [localRef?.current?.value, min])
315312

316-
const isPlusDisabled = useMemo(
317-
() => {
318-
if (!localRef?.current?.value || localRef?.current?.value === '') {
319-
return false
320-
}
313+
const isPlusDisabled = useMemo(() => {
314+
if (!localRef?.current?.value || localRef?.current?.value === '') {
315+
return false
316+
}
321317

322-
const numericValue = Number(localRef?.current?.value)
323-
if (Number.isNaN(numericValue)) return false
318+
const numericValue = Number(localRef?.current?.value)
319+
if (Number.isNaN(numericValue)) return false
324320

325-
const maxValue = typeof max === 'number' ? max : Number(max)
321+
const maxValue = typeof max === 'number' ? max : Number(max)
326322

327-
return numericValue >= maxValue
328-
}, // eslint-disable-next-line react-hooks/exhaustive-deps
329-
[localRef?.current?.value, max],
330-
)
323+
return numericValue >= maxValue
324+
}, [localRef?.current?.value, max])
331325

332326
const helperSentiment = useMemo(() => {
333327
if (error) {

packages/ui/src/components/Popup/index.tsx

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,6 @@ export const Popup = forwardRef(
259259
}
260260

261261
return null
262-
// eslint-disable-next-line react-hooks/exhaustive-deps
263262
}, [portalTarget, role, childrenRef.current])
264263

265264
// There are some issue when mixing animation and maxHeight on some browsers, so we disable animation if maxHeight is set.
@@ -430,15 +429,11 @@ export const Popup = forwardRef(
430429
])
431430

432431
// This will be triggered when positions are computed and popup is visible in the dom.
433-
useEffect(
434-
() => {
435-
if (visibleInDom && innerPopupRef.current) {
436-
innerPopupRef.current.style.opacity = '1'
437-
}
438-
},
439-
// eslint-disable-next-line react-hooks/exhaustive-deps
440-
[positions],
441-
)
432+
useEffect(() => {
433+
if (visibleInDom && innerPopupRef.current) {
434+
innerPopupRef.current.style.opacity = '1'
435+
}
436+
}, [positions])
442437

443438
/**
444439
* If popup has `visible` prop it means the popup is manually controlled through this prop.

packages/ui/src/components/SelectInputV2/Dropdown.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -721,7 +721,6 @@ export const Dropdown = ({
721721
} else window.scrollBy({ top: overflow, behavior: 'smooth' })
722722
}
723723
}
724-
// eslint-disable-next-line react-hooks/exhaustive-deps
725724
}, [isDropdownVisible, refSelect, size, ref.current])
726725

727726
const resizeDropdown = useCallback(() => {

packages/ui/src/components/Table/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ const TableContainer = ({ children }: { children: ReactNode }) => {
109109
setRefList([])
110110
setChildrenMemory(Children.toArray(children))
111111
}
112-
// eslint-disable-next-line react-hooks/exhaustive-deps
113112
}, [children, setRefList])
114113

115114
return <TableContainerStyle>{children}</TableContainerStyle>

0 commit comments

Comments
 (0)