fix(Banner): wrong style on link (#5384)

matthprost · web-flow · commit cd3ba5b70ac1 · 2025-07-30T11:35:10.000+02:00
diff --git a/.changeset/petite-jeans-dig.md b/.changeset/petite-jeans-dig.md
@@ -0,0 +1,5 @@
+---
+"@ultraviolet/ui": patch
+---
+
+Fix `<Banner />` wrong sentiment on dark color
diff --git a/packages/ui/src/components/Banner/__tests__/__snapshots__/index.test.tsx.snap b/packages/ui/src/components/Banner/__tests__/__snapshots__/index.test.tsx.snap
@@ -1737,7 +1737,7 @@ exports[`Banner > should render correctly with dark theme 1`] = `
 
 .emotion-14:hover::after,
 .emotion-14:focus::after {
-  background-color: #34a8ff;
+  background-color: #bf96f8;
 }
 
 .emotion-14:active {
diff --git a/packages/ui/src/components/Banner/index.tsx b/packages/ui/src/components/Banner/index.tsx
@@ -220,11 +220,7 @@ export const Banner = ({
               <Link
                 href={linkHref ?? ''}
                 prominence={prominence}
-                sentiment={
-                  theme === 'light' && variant !== 'promotional'
-                    ? 'primary'
-                    : undefined
-                }
+                sentiment="primary"
                 size="small"
                 target="_blank"
               >

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@ultraviolet/ui": patch
 +---
++
 +Fix `<Banner />` wrong sentiment on dark color
Original file line number	Diff line number	Diff line change
@@ -1737,7 +1737,7 @@ exports[`Banner > should render correctly with dark theme 1`] = `
`1737`	`1737`
`1738`	`1738`	`.emotion-14:hover::after,`
`1739`	`1739`	`.emotion-14:focus::after {`
`1740`		`- background-color: #34a8ff;`
	`1740`	`+ background-color: #bf96f8;`
`1741`	`1741`	`}`
`1742`	`1742`
`1743`	`1743`	`.emotion-14:active {`