post reviews fixups

Author: benzekrimaha

lib/auth/v2/getCanonicalizedAmzHeaders.ts

@@ -1,4 +1,5 @@
 import type { ArsenalRequestHeaders } from '../../types/ArsenalRequest';
+import { normalizeHeaderValue } from '../../utils/normalizeHeaders';
 
 export default function getCanonicalizedAmzHeaders(headers: ArsenalRequestHeaders, clientType: string) {
     /*
@@ -16,9 +17,7 @@ export default function getCanonicalizedAmzHeaders(headers: ArsenalRequestHeader
             // AWS SDK v3 can pass header values as arrays (for multiple values),
             // strings, or other types. We need to normalize them before calling .trim()
             // Per HTTP spec and AWS Signature v2, multiple values are joined with commas
-            const stringValue = Array.isArray(headerValue)
-                ? headerValue.join(',')
-                : String(headerValue);
+            const stringValue = normalizeHeaderValue(headerValue);
             return [val.trim(), stringValue.trim()];
         });
     /*

lib/auth/v4/createCanonicalRequest.ts

@@ -1,6 +1,7 @@
 import * as crypto from 'crypto';
 import * as queryString from 'querystring';
 import awsURIencode from './awsURIencode';
+import { normalizeHeaderValue } from '../../utils/normalizeHeaders';
 
 /**
  * createCanonicalRequest - creates V4 canonical request
@@ -77,9 +78,7 @@ export default function createCanonicalRequest(
             // AWS SDK v3 can pass header values as arrays (for multiple values),
             // strings, or other types. We need to normalize them before calling .trim()
             // Per HTTP spec and AWS Signature v4, multiple values are joined with commas
-            const stringValue = Array.isArray(headerValue) 
-                ? headerValue.join(',') 
-                : String(headerValue);
+            const stringValue = normalizeHeaderValue(headerValue);
             const trimmedHeader = stringValue
                 .trim().replace(/\s+/g, ' ');
             return `${signedHeader}:${trimmedHeader}\n`;

lib/network/kmsAWS/Client.ts

@@ -294,8 +294,22 @@ export default class Client implements KMSInterface {
      * additional permissions). Callers should rely on higher-level health
      * checks provided by their services instead of this method.
      */
+    /*
     healthcheck(logger: werelogs.Logger, cb: (err: Error | null) => void): void {
-        logger.debug("AWS KMS: healthcheck is a no-op (disabled)");
-        cb(null);
+        logger.debug("AWS KMS: performing healthcheck");
+
+        const command = new ListKeysCommand({
+            Limit: 1,
+        });
+
+        this.client.send(command).then(() => {
+            logger.debug("AWS KMS healthcheck: list keys succeeded");
+            cb(null);
+        }).catch(err => {
+            const error = arsenalErrorAWSKMS(err);
+            logger.error("AWS KMS healthcheck: failed to list keys", { err });
+            cb(error);
+        });
     }
+    */
 }

lib/storage/data/external/AwsClient.js

@@ -16,7 +16,6 @@ const { S3Client,
     GetBucketVersioningCommand,
     NoSuchKey,
     NotFound } = require('@aws-sdk/client-s3');
-const { HttpRequest } = require('@smithy/protocol-http');
 const { Upload } = require('@aws-sdk/lib-storage');
 const werelogs = require('werelogs');
 const { Readable } = require('stream');
@@ -52,14 +51,7 @@ class AwsClient {
 
     setup(cb) {
         const callback = typeof cb === 'function' ? cb : () => {};
-        let settled = false;
-        const done = err => {
-            if (settled) {
-                return;
-            }
-            settled = true;
-            callback(err);
-        };
+        const done = jsutil.once(callback);
         let usEast1Client;
         try {
             usEast1Client = new S3Client({

lib/storage/data/external/GCP/GcpApis/mpuHelper.js

@@ -198,8 +198,7 @@ class MpuHelper {
                     return next();
                 });
             }, err => callback(err));
-        };
-        
+        };   
         return async.waterfall([
             _getObjectVersions,
             _deleteObjects,