mpu helper coverage amelioration

Author: benzekrimaha

tests/unit/storage/data/external/GcpService.spec.js

@@ -2,6 +2,7 @@ const assert = require('assert');
 const http = require('http');
 const { GCP } = require('../../../../../lib/storage/data/external/GCP');
 const { ListObjectsCommand, ListObjectVersionsCommand } = require('@aws-sdk/client-s3');
+const MpuHelper = require('../../../../../lib/storage/data/external/GCP/GcpApis/mpuHelper');
 
 const httpPort = 8888;
 
@@ -492,3 +493,113 @@ describe('GcpService helper behavior', () => {
         });
     });
 });
+
+describe('GcpService mpu helper behavior', () => {
+    describe('removeParts', () => {
+        it('should list versions via send(ListObjectVersionsCommand) and delete each version', done => {
+            const service = {
+                _maxConcurrent: 10,
+                send: jest.fn()
+                    .mockImplementationOnce(command => {
+                        // page 1 (truncated)
+                        assert(command instanceof ListObjectVersionsCommand);
+                        assert.deepStrictEqual(command.input, {
+                            Bucket: 'mpu-bucket',
+                            Prefix: 'pfx/',
+                            KeyMarker: undefined,
+                            VersionIdMarker: undefined,
+                        });
+                        return Promise.resolve({
+                            IsTruncated: true,
+                            NextKeyMarker: 'k2',
+                            NextVersionIdMarker: 'v2',
+                            Versions: [
+                                { Key: 'a', VersionId: '1' },
+                            ],
+                        });
+                    })
+                    .mockImplementationOnce(command => {
+                        // page 2 (final)
+                        assert(command instanceof ListObjectVersionsCommand);
+                        assert.deepStrictEqual(command.input, {
+                            Bucket: 'mpu-bucket',
+                            Prefix: 'pfx/',
+                            KeyMarker: 'k2',
+                            VersionIdMarker: 'v2',
+                        });
+                        return Promise.resolve({
+                            IsTruncated: false,
+                            NextKeyMarker: undefined,
+                            NextVersionIdMarker: undefined,
+                            Versions: [
+                                { Key: 'b', VersionId: '2' },
+                                { Key: 'c', VersionId: '3' },
+                            ],
+                        });
+                    }),
+                deleteObject: jest.fn((params, cb) => cb(null)),
+            };
+
+            const helper = new MpuHelper(service);
+            helper.removeParts({ MPU: 'mpu-bucket', Prefix: 'pfx/' }, err => {
+                assert.ifError(err);
+                expect(service.send).toHaveBeenCalledTimes(2);
+                expect(service.deleteObject).toHaveBeenCalledTimes(3);
+                expect(service.deleteObject).toHaveBeenNthCalledWith(1, {
+                    Bucket: 'mpu-bucket',
+                    Key: 'a',
+                    VersionId: '1',
+                }, expect.any(Function));
+                done();
+            });
+        });
+
+        it('should ignore NoSuchKey errors during delete', done => {
+            const service = {
+                _maxConcurrent: 10,
+                send: jest.fn().mockResolvedValue({
+                    IsTruncated: false,
+                    Versions: [
+                        { Key: 'a', VersionId: '1' },
+                        { Key: 'b', VersionId: '2' },
+                    ],
+                }),
+                deleteObject: jest.fn((params, cb) => {
+                    if (params.Key === 'a') {
+                        const err = new Error('gone');
+                        err.name = 'NoSuchKey';
+                        return cb(err);
+                    }
+                    return cb(null);
+                }),
+            };
+
+            const helper = new MpuHelper(service);
+            helper.removeParts({ MPU: 'mpu-bucket', Prefix: 'pfx/' }, err => {
+                assert.ifError(err);
+                expect(service.send).toHaveBeenCalledTimes(1);
+                expect(service.deleteObject).toHaveBeenCalledTimes(2);
+                done();
+            });
+        });
+
+        it('should return error when send(ListObjectVersionsCommand) rejects', done => {
+            const listObjectVersionsError = new Error('send(ListObjectVersionsCommand) failed');
+            const service = {
+                _maxConcurrent: 10,
+                send: jest.fn(command => {
+                    assert(command instanceof ListObjectVersionsCommand);
+                    return Promise.reject(listObjectVersionsError);
+                }),
+                deleteObject: jest.fn(),
+            };
+
+            const helper = new MpuHelper(service);
+            helper.removeParts({ MPU: 'mpu-bucket', Prefix: 'pfx/' }, err => {
+                assert.strictEqual(err, listObjectVersionsError);
+                expect(service.deleteObject).not.toHaveBeenCalled();
+                done();
+            });
+        });
+    });
+});