step1: removing unused and updating tests to use send command

Author: benzekrimaha

lib/storage/data/external/GCP/GcpService.js

@@ -9,8 +9,6 @@ const { S3Client,
     CopyObjectCommand,
     HeadObjectCommand,
     HeadBucketCommand,
-    PutBucketVersioningCommand,
-    GetBucketVersioningCommand,
 } = require('@aws-sdk/client-s3');
 const { createNormalizeHeadersMiddleware } = require('../../../../utils/normalizeHeaders');
 const { attachHeaderCaptureMiddleware } = require('./GcpUtils');
@@ -75,16 +73,6 @@ class GcpService extends S3Client {
         );
     }
 
-    listBuckets(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: listBuckets not implemented'));
-    }
-
-    getBucketLocation(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: getBucketLocation not implemented'));
-    }
-
     headBucket(params, callback) {
         const command = new HeadBucketCommand(params);
         let metaVersionId;
@@ -110,112 +98,6 @@ class GcpService extends S3Client {
             .catch(err => callback(err));
     }
 
-    deleteBucket(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: deleteBucket not implemented'));
-    }
-
-    createBucket(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: createBucket not implemented'));
-    }
-
-    putBucket(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: putBucket not implemented'));
-    }
-
-    putBucketVersioning(params, callback) {
-        if (!params || !params.Bucket || !params.VersioningConfiguration) {
-            const error = errorInstances.InvalidRequest
-                .customizeDescription('Missing required parameter');
-            return callback(error);
-        }
-        return this.send(new PutBucketVersioningCommand(params))
-            .then(data => {
-                if (callback) {
-                    return callback(null, data);
-                }
-                return data;
-            })
-            .catch(err => {
-                if (callback) {
-                    return callback(err);
-                }
-                throw err;
-            });
-    }
-
-    getBucketVersioning(params, callback) {
-        if (!params || !params.Bucket) {
-            const error = errorInstances.InvalidRequest
-                .customizeDescription('Missing required parameter');
-            return callback(error);
-        }
-        return this.send(new GetBucketVersioningCommand(params))
-            .then(data => {
-                if (callback) {
-                    return callback(null, data);
-                }
-                return data;
-            })
-            .catch(err => {
-                if (callback) {
-                    return callback(err);
-                }
-                throw err;
-            });
-    }
-
-    getBucketAcl(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: getBucketAcl not implemented'));
-    }
-
-    putBucketAcl(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: putBucketAcl not implemented'));
-    }
-
-    putBucketWebsite(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: putBucketWebsite not implemented'));
-    }
-
-    getBucketWebsite(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: getBucketWebsite not implemented'));
-    }
-
-    deleteBucketWebsite(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: deleteBucketWebsite not implemented'));
-    }
-
-    putBucketCors(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: putBucketCors not implemented'));
-    }
-
-    getBucketCors(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: getBucketCors not implemented'));
-    }
-
-    deleteBucketCors(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: deleteBucketCors not implemented'));
-    }
-
-    putObjectAcl(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: putObjectAcl not implemented'));
-    }
-
-    getObjectAcl(params, callback) {
-        return callback(errorInstances.NotImplemented
-            .customizeDescription('GCP: getObjectAcl not implemented'));
-    }
 
     /**
      * Multipart upload (managed upload, single or multi-part).
@@ -232,10 +114,6 @@ class GcpService extends S3Client {
         }
     }
 
-    putObjectCopy(params, callback) {
-        return this.copyObject(params, callback);
-    }
-
     /**
      * Copy an object (mock for test compatibility).
      * @param {object} params - S3 copyObject params

tests/unit/storage/data/external/GcpService.spec.js

@@ -1,7 +1,7 @@
 const assert = require('assert');
 const http = require('http');
 const { GCP } = require('../../../../../lib/storage/data/external/GCP');
-const { ListObjectsCommand, ListObjectVersionsCommand } = require('@aws-sdk/client-s3');
+const { ListObjectsCommand, ListObjectVersionsCommand, GetBucketVersioningCommand } = require('@aws-sdk/client-s3');
 const MpuHelper = require('../../../../../lib/storage/data/external/GCP/GcpApis/mpuHelper');
 const { createMpuKey } = require('../../../../../lib/storage/data/external/GCP/GcpUtils');
 
@@ -195,6 +195,11 @@ function callOperation(client, op, params, cb) {
             .then(() => cb(null))
             .catch(err => cb(err));
     }
+    if (op === 'getBucketVersioning') {
+        return client.send(new GetBucketVersioningCommand(params))
+            .then(() => cb(null))
+            .catch(err => cb(err));
+    }
     return client[op](params, cb);
 }