Merge branch 'bugfix/ARSN-554/fix_empty_tag_value_crash' into q/8.2

Author: bert-e

lib/s3middleware/tagging.ts

@@ -45,7 +45,7 @@ export const _validator = {
     validateTagObjectStructure: (tag: BucketTag) => tag
         && Object.keys(tag).length === 2
         && typeof tag.Key === 'string' && typeof tag.Value === 'string'
-        && tag.Key.length >= 1 && tag.Value.length >= 1,
+        && tag.Key.length >= 1,
 
     validateXMLStructure: (result: any) =>
         result && Object.keys(result).length === 1 &&

tests/unit/s3middleware/tagging.spec.js

@@ -1,5 +1,6 @@
 const assert = require('assert');
-const { areTagsValid, _validator } = require('../../../lib/s3middleware/tagging');
+const werelogs = require('werelogs');
+const { areTagsValid, _validator, parseTagXml } = require('../../../lib/s3middleware/tagging');
 
 describe('tagging validator', () => {
     it('validates keys and values are less than 128 and 256', () => {
@@ -68,6 +69,14 @@ describe('areTagsValid', () => {
         assert.strictEqual(result, false);
     });
 
+    it('should return true for tags with empty Value', () => {
+        const validTags = [
+            { Key: 'key1', Value: '' }
+        ];
+        const result = areTagsValid(validTags);
+        assert.strictEqual(result, true);
+    });
+
     it('should return false for tags with duplicate keys', () => {
         const invalidTags = [
             { Key: 'key1', Value: 'value1' },
@@ -93,3 +102,16 @@ describe('areTagsValid', () => {
         assert.strictEqual(result, false);
     });
 });
+
+describe('parseTagXml', () => {
+    const log = new werelogs.Logger('test');
+
+    it('should parse tags with empty values from XML', (done) => {
+        const xml = '<Tagging><TagSet><Tag><Key>key1</Key><Value></Value></Tag></TagSet></Tagging>';
+        parseTagXml(xml, log, (err, result) => {
+            assert.ifError(err);
+            assert.deepStrictEqual(result, { key1: '' });
+            done();
+        });
+    });
+});