impr(BB-694): Add schemas for kerberos and basic auth configs

Author: tmacro

extensions/notification/NotificationConfigValidator.js

@@ -1,27 +1,45 @@
 const joi = require('joi');
 const { probeServerJoi } = require('../../lib/config/configItems.joi');
 
-const authSchema = joi.object({
-    type: joi.string(),
-    ssl: joi.boolean(),
-    protocol: joi.string(),
+const sslSchema = joi.object({
+    ssl: joi.boolean().default(false),
     ca: joi.string(),
     client: joi.string(),
     key: joi.string(),
     keyPassword: joi.string(),
-    keytab: joi.string(),
-    principal: joi.string(),
-    serviceName: joi.string(),
 });
 
+const saslAuthSchema = ssl.append({
+    protocol: joi.string().valid('SASL_PLAINTEXT', 'SASL_SSL').required(),
+});
+
+const kerberosAuthSchema = sasl.append({
+    type: joi.string().valid('kerberos').required(),
+    keytab: joi.string().required(),
+    principal: joi.string().required(),
+    serviceName: joi.string().required(),
+});
+
+const basicAuthSchema = sasl.append({
+    type: joi.string().valid('basic').required(),
+    credentialsFile: joi.string().required(),
+});
+
+const credentialsFileSchema = joi.object({
+    username: joi.string().required(),
+    password: joi.string().required(),
+});
+
+const authSchema = joi.alternatives().try(ssl, kerberos, basic).default({});
+
 const destinationSchema = joi.object({
     resource: joi.string().required(),
     type: joi.string().required(),
     host: joi.string().required(),
     port: joi.number().optional(),
     internalTopic: joi.string(),
     topic: joi.string().required(),
-    auth: authSchema.default({}),
+    auth: authSchema,
     requiredAcks: joi.number().when('type', {
         is: joi.string().not('kafka'),
         then: joi.forbidden(),
@@ -39,10 +57,10 @@ const joiSchema = joi.object({
     monitorNotificationFailures: joi.boolean().default(true),
     notificationFailedTopic: joi.string().optional(),
     zookeeperPath: joi.string().optional(),
-    queueProcessor: {
+    queueProcessor: joi.object({
         groupId: joi.string().required(),
         concurrency: joi.number().greater(0).default(1000),
-    },
+    }),
     destinations: joi.array().items(destinationSchema).default([]),
     // TODO: BB-625 reset to being required after supporting probeserver in S3C
     // for bucket notification proceses
@@ -59,4 +77,7 @@ function configValidator(backbeatConfig, extConfig) {
     return validatedConfig;
 }
 
-module.exports = configValidator;
+module.exports = {
+    NotificationConfigValidator: configValidator,
+    authSchema,
+};

extensions/notification/destination/KafkaProducer.js

@@ -1,16 +1,15 @@
 const joi = require('joi');
+const { authSchema } = require('../NotificationConfigValidator');
 
 const BackbeatProducer = require('../../../lib/BackbeatProducer');
 const authUtil = require('../utils/auth');
 
 class KafkaProducer extends BackbeatProducer {
 
     getConfigJoi() {
-        return super.getConfigJoi().append(
-            { auth: joi.object().optional() }
-        ).keys(
-            { topic: joi.string() }
-        );
+        return super.getConfigJoi()
+            .append({ auth: authSchema })
+            .keys({ topic: joi.string() });
     }
 
     getClientId() {

extensions/notification/index.js

@@ -1,4 +1,4 @@
-const NotificationConfigValidator = require('./NotificationConfigValidator');
+const { NotificationConfigValidator } = require('./NotificationConfigValidator');
 const NotificationOplogPopulatorUtils = require('./NotificationOplogPopulatorUtils');
 
 module.exports = {

tests/unit/notification/KafkaNotificationDestination.js

@@ -12,6 +12,7 @@ describe('KafkaNotificationDestination ::', () => {
     afterEach(() => {
         sinon.restore();
     });
+
     it('should properly configure producer', done => {
         const destConfig = {
             host: 'localhost',