CLDSRV-224: switch back to callback mode

Author: Seragonia

lib/api/bucketGetTagging.js

@@ -1,10 +1,10 @@
 const { metadataValidateBucket } = require('../metadata/metadataUtils');
-const util = require('node:util');
 const collectCorsHeaders = require('../utilities/collectCorsHeaders');
 const { checkExpectedBucketOwner } = require('./apiUtils/authorization/bucketOwner');
 const { pushMetric } = require('../utapi/utilities');
 const monitoring = require('../utilities/monitoringHandler');
 const { errors, s3middleware } = require('arsenal');
+const { waterfall } = require('async');
 const escapeForXml = s3middleware.escapeForXml;
 
 //  Sample XML response:
@@ -60,43 +60,39 @@ function tagsToXml(tags) {
  *  with either error code or xml response body
  * @return {undefined}
  */
-async function bucketGetTagging(authInfo, request, log, callback) {
+function bucketGetTagging(authInfo, request, log, callback) {
     log.debug('processing request', { method: 'bucketGetTagging' });
 
     const { bucketName, headers } = request;
-    const metadataValidateBucketPromise = util.promisify(metadataValidateBucket);
-    const checkExpectedBucketOwnerPromise = util.promisify(checkExpectedBucketOwner);
-
     const metadataValParams = {
         authInfo,
         bucketName,
         requestType: 'bucketGetTagging',
         request,
     };
-
-    let bucket;
+    let bucket = null;
     let xml = null;
+    let tags = null;
 
-    try {
-        bucket = await metadataValidateBucketPromise(metadataValParams, log);
-        // eslint-disable-next-line no-unused-expressions
-        await checkExpectedBucketOwnerPromise(headers, bucket, log);
-        const tags = bucket.getTags();
-        if (!tags || !tags.length) {
-            log.debug('bucket TagSet does not exist', {
-                method: 'bucketGetTagging',
-            });
-            throw errors.NoSuchTagSet;
+    return waterfall([
+        next => metadataValidateBucket(metadataValParams, log,
+            (err, b) => {
+                bucket = b;
+                return next(err);
+            }),
+        next => checkExpectedBucketOwner(headers, bucket, log, next),
+        next => {
+            tags = bucket.getTags();
+            if (!tags || !tags.length) {
+                log.debug('bucket TagSet does not exist', {
+                    method: 'bucketGetTagging',
+                });
+                return next(errors.NoSuchTagSet);
+            }
+            xml = tagsToXml(tags);
+            return next();
         }
-        xml = tagsToXml(tags);
-        pushMetric('getBucketTagging', log, {
-            authInfo,
-            bucket: bucketName,
-        });
-        const corsHeaders = collectCorsHeaders(request.headers.origin,
-            request.method, bucket);
-        return callback(null, xml, corsHeaders);
-    } catch (err) {
+    ], err => {
         const corsHeaders = collectCorsHeaders(request.headers.origin,
             request.method, bucket);
         if (err) {
@@ -106,17 +102,16 @@ async function bucketGetTagging(authInfo, request, log, callback) {
             });
             monitoring.promMetrics('GET', bucketName, err.code,
                 'getBucketTagging');
-        } else {
-            monitoring.promMetrics(
-                'GET', bucketName, '200', 'getBucketTagging');
-            pushMetric('getBucketTagging', log, {
-                authInfo,
-                bucket: bucketName,
-            });
+            return callback(err, corsHeaders);
         }
-
-        return callback(err, corsHeaders);
-    }
+        monitoring.promMetrics(
+            'GET', bucketName, '200', 'getBucketTagging');
+        pushMetric('getBucketTagging', log, {
+            authInfo,
+            bucket: bucketName,
+        });
+        return callback(null, xml, corsHeaders);
+    });
 }
 
 module.exports = bucketGetTagging;