🥅(CLDSRV-779) manage error on putBucketReplication properly

Author: DarkIsDude

.editorconfig

@@ -0,0 +1,6 @@
+root = true
+
+[*]
+charset = utf-8
+indent_style = space
+indent_size = 4

lib/api/apiUtils/bucket/getReplicationConfiguration.js

@@ -9,9 +9,15 @@ function getReplicationConfiguration(xml, log, cb) {
         if (err) {
             return cb(err);
         }
+
         const validator = new ReplicationConfiguration(result, log, config);
         const configErr = validator.parseConfiguration();
-        return cb(configErr || null, validator.getReplicationConfiguration());
+
+        if (configErr) {
+            return cb(configErr);
+        }
+
+        return cb(null, validator.getReplicationConfiguration());
     });
 }
 

tests/functional/aws-node-sdk/test/bucket/putBucketReplication.js

@@ -377,3 +377,66 @@ describe('aws-node-sdk test putBucketReplication configuration rules', () => {
             return checkError(config, 'MalformedXML', done);
         });
 });
+
+describe('aws-node-sdk test putBucketReplication CORS', () => {
+    let s3;
+    const bucket = 'source-bucket-cors';
+
+    beforeEach(done => {
+        const config = getConfig('default', { signatureVersion: 'v4' });
+        s3 = new S3(config);
+        series([
+            next => s3.createBucket({ Bucket: bucket }, next),
+            next => s3.putBucketVersioning({
+                Bucket: bucket,
+                VersioningConfiguration: { Status: 'Enabled' },
+            }, next),
+            next => s3.putBucketCors({
+                Bucket: bucket,
+                CORSConfiguration: {
+                    CORSRules: [{
+                        AllowedOrigins: ['*'],
+                        AllowedMethods: ['PUT'],
+                        AllowedHeaders: ['*'],
+                    }],
+                },
+            }, next),
+        ], done);
+    });
+
+    afterEach(done => {
+        series([
+            next => s3.deleteBucketCors({ Bucket: bucket }, err => {
+                if (err && err.code !== 'NoSuchCORSConfiguration') {
+                    return next(err);
+                }
+                return next();
+            }),
+            next => s3.deleteBucket({ Bucket: bucket }, next),
+        ], done);
+    });
+
+    it('should return CORS headers on malformed XML error', done => {
+        const replicationParams = {
+            Bucket: bucket,
+            ReplicationConfiguration: {
+                Role: 'arn:aws:iam::account-id:role/src-resource,' +
+                    'arn:aws:iam::account-id:role/dest-resource',
+                Rules: [],
+            },
+        };
+        const request = s3.putBucketReplication(replicationParams);
+        request.on('build', () => {
+            request.httpRequest.headers.Origin = 'http://example.com';
+        });
+        request.send(err => {
+            console.log({ err });
+            assertError(err, 'MalformedXML');
+            assert.strictEqual(
+                err.httpResponse.headers['access-control-allow-origin'],
+                '*'
+            );
+            done();
+        });
+    });
+});