🔇 remove logs used to debug

Issue: CLDSRV-765

Author: DarkIsDude

lib/api/completeMultipartUpload.js

@@ -535,21 +535,10 @@ function completeMultipartUpload(authInfo, request, log, callback) {
         },
         function deletePartsMetadata(mpuBucket, keysToDelete, aggregateETag,
             extraPartLocations, destinationBucket, generatedVersionId, droppedMPUSize, next) {
-            log.warn('Deleting MPU parts metadata', { method: 'completeMultipartUpload' });
             services.batchDeleteObjectMetadata(mpuBucket.getName(),
                 keysToDelete, log, err => {
                     if (err) {
-                        log.warn(
-                            'error deleting MPU parts metadata',
-                            { error: err, method: 'deletePartsMetadata' },
-                        );
-                        console.info({ errorCustom: JSON.stringify(err) });
-                        // Handle specific error cases according to retry strategy
                         if (err.is?.DeleteConflict) {
-                            log.warn(
-                                'conflict deleting MPU parts metadata, will retry',
-                                { method: 'deletePartsMetadata' },
-                            );
                             // DeleteConflict should trigger automatic retry
                             // Convert to InternalError to make it retryable
                             const customErr = errorInstances.InternalError.customizeDescription(
@@ -562,22 +551,16 @@ function completeMultipartUpload(authInfo, request, log, callback) {
 
                         // For NoSuchKey and other errors, return them as-is
                         // NoSuchKey is non-retryable, InternalError and others are retryable
-                        log.warn(
-                            'error deleting MPU parts metadata, returning error',
-                            { method: 'deletePartsMetadata' },
-                        );
                         return next(err, extraPartLocations,
                             destinationBucket, aggregateETag, generatedVersionId, droppedMPUSize);
                     }
 
-                    log.warn('Successfully deleted MPU parts metadata', { method: 'deletePartsMetadta' });
                     return next(null, extraPartLocations,
                         destinationBucket, aggregateETag, generatedVersionId, droppedMPUSize);
                 });
         },
         function batchDeleteExtraParts(extraPartLocations, destinationBucket,
             aggregateETag, generatedVersionId, droppedMPUSize, next) {
-            log.warn('deleting extra parts if any', { method: 'batchDeleteExtraParts' });
             if (extraPartLocations && extraPartLocations.length > 0) {
                 return data.batchDelete(extraPartLocations, request.method, null, log, err => {
                     if (err) {

lib/services.js

@@ -984,28 +984,8 @@ const services = {
         // all at once in production implementation
         assert.strictEqual(typeof mpuBucketName, 'string');
         async.eachLimit(keysToDelete, 5, (key, callback) => {
-            metadata.deleteObjectMD(mpuBucketName, key, { overheadField: constants.overheadField }, log, err => {
-                if (err) {
-                    console.info({ errorInBatch: err });
-                    log.error('error deleting part metadata in batch', {
-                        error: err,
-                        method: 'services.batchDeleteObjectMetadata',
-                        key,
-                    });
-                }
-                return callback(err);
-            });
-        }, err => {
-            if (err) {
-                console.info({ finalErrorInBatch: err });
-                log.error('error in batch (final) deleting part metadata', {
-                    error: err,
-                    method: 'services.batchDeleteObjectMetadata',
-                });
-            }
-
-            return cb(err);
-        });
+            metadata.deleteObjectMD(mpuBucketName, key, { overheadField: constants.overheadField }, log, callback);
+        }, cb);
     },
 };
 

tests/functional/aws-node-sdk/test/object/copyPart.js

@@ -580,7 +580,7 @@ describe('Object Part Copy', () => {
                 });
             });
 
-            it.only('should not corrupt object if overwriting an existing part by copying a part ' +
+            it('should not corrupt object if overwriting an existing part by copying a part ' +
             'while the MPU is being completed', async () => {
                 const finalObjETag = '"db77ebbae9e9f5a244a26b86193ad818-1"';
                 process.stdout.write('Putting first part in MPU test"');
@@ -621,21 +621,9 @@ describe('Object Part Copy', () => {
                             },
                         }).promise()
                         .catch(async err => {
-                            // The completeMPU delete part in a 2 steps
-                            // (first mark it as deletion with `delete: true` in Mongo, then delete it).
-                            // At the same time, the uploadPartCopy update the same data in Mongo.
-                            // In that case, the completeMPU fail with an InternalError (DeleteConflict in the logs)
                             const raceConditionOccurred = err?.code === 'InternalError'
                                 && err?.message === 'conflict deleting MPU parts metadata';
 
-                            console.info({
-                                raceConditionOccurred,
-                                err,
-                                message: err?.message,
-                                description: err.description,
-                                code: err?.code,
-                            });
-
                             if (raceConditionOccurred) {
                                 return Promise.resolve(null);
                             }