CLDSRV-750: disable Put/GetBucketLogging if it is disabled in the config

Author: leif-scality

.github/docker/config.s3c.json

@@ -61,5 +61,9 @@
             "host": "localhost:6000"
         }
     ],
-    "enableVeeamRoute": false
+    "enableVeeamRoute": false,
+    "serverAccessLogs": {
+        "enabled": true,
+        "outputFile": "/logs/server-access.log"
+    }
 }

.github/docker/docker-compose.yaml

@@ -46,6 +46,7 @@ services:
       - S3QUOTA
       - QUOTA_ENABLE_INFLIGHTS
       - S3_VERSION_ID_ENCODING_TYPE
+      - S3_ENABLE_SERVER_ACCESS_LOGS=true
     env_file:
       - creds.env
     depends_on:

lib/Config.js

@@ -592,6 +592,10 @@ function parseServerAccessLogs(config) {
         }
     }
 
+    if (process.env.S3_ENABLE_SERVER_ACCESS_LOGS === 'true') {
+        res.enabled = true;
+    }
+
     return res;
 }
 

lib/api/bucketGetLogging.js

@@ -2,13 +2,19 @@ const { standardMetadataValidateBucket } = require('../metadata/metadataUtils');
 const { checkExpectedBucketOwner } = require('./apiUtils/authorization/bucketOwner');
 const monitoring = require('../utilities/monitoringHandler');
 const { waterfall } = require('async');
+const { config } = require('../Config');
+const { errorInstances } = require('arsenal');
 
 const BucketLoggingStatusNotFoundBody = '<?xml version="1.0" encoding="UTF-8"?>\n' +
     '<BucketLoggingStatus xmlns="http://doc.s3.amazonaws.com/2006-03-01" />';
 
 function bucketGetLogging(authInfo, request, log, callback) {
     log.debug('processing request', { method: 'bucketGetLogging' });
 
+    if (!config.serverAccessLogs || !config.serverAccessLogs.enabled) {
+        return callback(errorInstances.NotImplemented);
+    }
+
     const bucketName = request.bucketName;
     const metadataValParams = {
         authInfo,

lib/api/bucketPutLogging.js

@@ -5,10 +5,15 @@ const BucketLoggingStatus = require('arsenal').models.BucketLoggingStatus;
 const metadata = require('../metadata/wrapper');
 const monitoring = require('../utilities/monitoringHandler');
 const { errorInstances } = require('arsenal');
+const { config } = require('../Config');
 
 function bucketPutLogging(authInfo, request, log, callback) {
     log.debug('processing request', { method: 'bucketPutLogging' });
 
+    if (!config.serverAccessLogs || !config.serverAccessLogs.enabled) {
+        return callback(errorInstances.NotImplemented);
+    }
+
     const bucketName = request.bucketName;
     const parsed = BucketLoggingStatus.fromXML(request.post);
     if (parsed.error) {

tests/functional/config.json

@@ -6,5 +6,9 @@
     "localCache": {
         "host": "127.0.0.1",
         "port": 6379
+    },
+    "serverAccessLogs": {
+        "enabled": true,
+        "outputFile": "/logs/server-access.log"
     }
 }

tests/unit/api/bucketGetLogging.js

@@ -11,6 +11,9 @@ const otherAuthInfo = makeAuthInfo('accessKey2');
 const bucketName = 'bucketgetloggingtest';
 const targetBucket = 'loggingbucket';
 const namespace = 'default';
+const { config } = require('../../../lib/Config');
+
+config.serverAccessLogs.enabled = true;
 
 const testBucketPutRequest = {
     bucketName,

tests/unit/api/bucketPutLogging.js

@@ -10,6 +10,9 @@ const otherAuthInfo = makeAuthInfo('accessKey2');
 const bucketName = 'bucketputloggingtest';
 const targetBucket = 'loggingbucket';
 const namespace = 'default';
+const { config } = require('../../../lib/Config');
+
+config.serverAccessLogs.enabled = true;
 
 const testBucketPutRequest = {
     bucketName,