Skip to content

Commit bc63e7a

Browse files
benzekrimahabenzekrimaha
committed
lint fixup
1 parent 702ff12 commit bc63e7a

File tree

9 files changed

+3
-49
lines changed

9 files changed

+3
-49
lines changed

‎tests/functional/raw-node/test/GCP/bucket/get.js‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,17 @@ const bigSize = listingHardLimit + 1;
1616
const config = getRealAwsConfig(credentialOne);
1717
const gcpClient = new GCP(config);
1818

19-
console.log('Middleware stack:', gcpClient.middlewareStack.identify());
20-
console.log('config.s3Params.credentials:', config.s3Params.credentials);
21-
console.log('gcpClient._config:', gcpClient._config);
22-
console.log('gcpClient._config.s3Params.credentials:', gcpClient._config.s3Params.credentials);
23-
2419
function populateBucket(createdObjects, callback) {
2520
process.stdout.write(
2621
`Putting ${createdObjects.length} objects into bucket\n`);
2722
async.mapLimit(createdObjects, 10,
2823
(object, moveOn) => {
29-
console.log('Putting object:', object);
3024
makeGcpRequest({
3125
method: 'PUT',
3226
bucket: bucketName,
3327
objectKey: object,
3428
authCredentials: config.credentials,
3529
}, err => {
36-
console.log('Put object callback err:', err);
3730
moveOn(err);
3831
});
3932
}, err => {
@@ -74,7 +67,6 @@ describe('GCP: GET Bucket', function testSuite() {
7467
bucket: bucketName,
7568
authCredentials: config.credentials,
7669
}, 0, err => {
77-
console.log('Create bucket callback err:', err);
7870
if (err) {
7971
process.stdout.write(`err in creating bucket ${err}\n`);
8072
}
@@ -112,7 +104,6 @@ describe('GCP: GET Bucket', function testSuite() {
112104
gcpClient.listObjects({
113105
Bucket: bucketName,
114106
}, (err, res) => {
115-
console.log('listObjects callback err:', err, 'res:', res);
116107
assert.equal(err, null, `Expected success, but got ${err}`);
117108
assert.strictEqual(res.$metadata?.httpStatusCode, 200);
118109
return done();
@@ -130,11 +121,9 @@ describe('GCP: GET Bucket', function testSuite() {
130121
after(done => removeObjects(createdObjects, done));
131122

132123
it(`should list all ${smallSize} created objects`, done => {
133-
console.log('About to call listObjects...');
134124
gcpClient.listObjects({
135125
Bucket: bucketName,
136126
}, (err, res) => {
137-
console.log('Callback called! err:', err, 'res keys:', res ? Object.keys(res) : null);
138127
assert.equal(err, null, `Expected success, but got ${err}`);
139128
assert.strictEqual(res.Contents.length, smallSize);
140129
return done();

‎tests/functional/raw-node/test/GCP/bucket/getVersioning.js‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,18 +61,15 @@ describe('GCP: GET Bucket Versioning', () => {
6161
queryObj: { versioning: '' },
6262
requestBody: xmlEnable,
6363
}, err => {
64-
console.log('[Versioning Test] Step 1 callback - err:', err ? err.code : 'success');
6564
if (err) {
6665
process.stdout.write(`err in setting versioning ${err.code}`);
6766
}
6867
return next(err);
6968
}),
7069
next => {
71-
console.log('[Versioning Test] Step 2: Getting versioning...');
7270
gcpClient.getBucketVersioning({
7371
Bucket: this.test.bucketName,
7472
}, (err, res) => {
75-
console.log('[Versioning Test] Step 2 callback - err:', err, 'res:', res);
7673
assert.equal(err, null,
7774
`Expected success, but got err ${err}`);
7875
assert.deepStrictEqual(res.Status, verEnabledObj);

‎tests/functional/raw-node/test/GCP/bucket/head.js‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ describe('GCP: HEAD Bucket', () => {
2121
gcpClient.headBucket({
2222
Bucket: this.test.bucketName,
2323
}, err => {
24-
console.log('[HEAD Bucket Test] Callback - err:', err ? err.code : 'success');
2524
assert(err);
2625
assert.strictEqual(err.$metadata?.httpStatusCode, 404);
2726
return done();
@@ -42,7 +41,6 @@ describe('GCP: HEAD Bucket', () => {
4241
if (err) {
4342
return done(err);
4443
}
45-
console.log('[HEAD Bucket Test] Bucket created - res:', res);
4644
this.currentTest.bucketObj = {
4745
MetaVersionId: res.headers['x-goog-metageneration'],
4846
};
@@ -65,18 +63,11 @@ describe('GCP: HEAD Bucket', () => {
6563
});
6664

6765
it('should get bucket information', function testFn(done) {
68-
console.log('[HEAD Bucket Test] Getting info for bucket:', this.test.bucketName);
6966
gcpClient.headBucket({
7067
Bucket: this.test.bucketName,
7168
}, (err, res) => {
72-
console.log('[HEAD Bucket Test] Callback - err:', err);
73-
console.log('[HEAD Bucket Test] Callback - res:', res);
74-
console.log('[HEAD Bucket Test] Callback - data:', this.test.bucketObj);
7569
assert.equal(err, null, `Expected success, but got ${err}`);
7670
const { $metadata, ...data } = res;
77-
console.log('[HEAD Bucket Test] Callback - res:', res);
78-
console.log('[HEAD Bucket Test] Callback - $metadata:', $metadata);
79-
console.log('[HEAD Bucket Test] Callback - data:', this.test.bucketObj);
8071
assert.strictEqual($metadata.httpStatusCode, 200);
8172
assert.deepStrictEqual(this.test.bucketObj, data);
8273
return done();

‎tests/functional/raw-node/test/GCP/object/completeMpu.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ describe('GCP: Complete MPU', function testSuite() {
156156
});
157157
});
158158

159-
describe('when MPU has 1024 uploaded parts', function() {
159+
describe('when MPU has 1024 uploaded parts', () => {
160160
beforeEach(function beforeFn(done) {
161161
this.currentTest.key = `somekey-${genUniqID()}`;
162162
gcpMpuSetupWrapper.call(this, {

‎tests/functional/raw-node/test/GCP/object/delete.js‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ describe('GCP: DELETE Object', function testSuite() {
7474
objectKey,
7575
authCredentials: config.credentials,
7676
}, err => {
77-
console.log('Get after delete err:', err);
7877
assert(err);
7978
assert.strictEqual(err.statusCode, 404);
8079
assert.strictEqual(err.code, 'NoSuchKey');

‎tests/functional/raw-node/test/GCP/object/getTagging.js‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ describe('GCP: GET Object Tagging', () => {
8787
Key: this.test.key,
8888
VersionId: this.test.versionId,
8989
}, (err, res) => {
90-
console.log('GetTagging err:', err);
91-
console.log('GetTagging res:', res);
9290
assert.equal(err, null,
9391
`Expected success, got error ${err}`);
9492
assert.deepStrictEqual(res.TagSet, this.test.tagObj);

‎tests/functional/raw-node/test/GCP/object/head.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ describe('GCP: HEAD Object', function testSuite() {
4949
objectKey: this.currentTest.key,
5050
authCredentials: config.credentials,
5151
}, (err, res) => {
52-
console.log('Put object err:', err);
53-
console.log('Put object res:', res);
5452
if (err) {
5553
process.stdout.write(`err in creating object ${err}\n`);
5654
return done(err);
@@ -81,8 +79,6 @@ describe('GCP: HEAD Object', function testSuite() {
8179
Bucket: bucketName,
8280
Key: this.test.key,
8381
}, (err, res) => {
84-
console.log('Head object err:', err);
85-
console.log('Head object res:', res);
8682
assert.equal(err, null,
8783
`Expected success, got error ${err}`);
8884
assert.strictEqual(res.ETag, this.test.ETag);

‎tests/functional/raw-node/utils/gcpUtils.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ function gcpMpuSetup(params, callback) {
4242
Bucket: bucketNames.mpu.Name,
4343
Key: key,
4444
}, (err, res) => {
45-
console.log('[MPU Setup] Create MPU callback - err:', err , 'res:', res);
4645
assert.equal(err, null,
4746
`Expected success, but got error ${err}`);
4847
return next(null, res.UploadId);
@@ -70,17 +69,14 @@ function gcpMpuSetup(params, callback) {
7069
if (!(++count % 100)) {
7170
process.stdout.write(`Uploaded Parts: ${count}\n`);
7271
}
73-
console.log('[MPU Setup] Upload Part callback - err:', err , 'res:', res);
7472
etagList[info] = res.ETag;
7573
return moveOn(null);
7674
});
7775
}, err => {
78-
console.log('[MPU Setup] All parts uploaded callback - err:', err);
7976
next(err, { uploadId, etagList });
8077
});
8178
},
8279
], (err, result) => {
83-
console.log('[MPU Setup] Final callback - err:', err, 'result:', result);
8480
if (err) {
8581
if (err === 'SkipPutPart') {
8682
return callback(null, result);

‎tests/functional/raw-node/utils/makeRequest.js‎

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,27 +18,15 @@ function signGcpRequest(request, credentials, date) {
1818
// Set x-goog-date header
1919
// eslint-disable-next-line no-param-reassign
2020
request.headers['x-goog-date'] = date.toUTCString();
21-
22-
console.log('[signGcpRequest] Signing request:', {
23-
method: request.method,
24-
path: request.path,
25-
bucketName: request.bucketName,
26-
query: request.query,
27-
});
28-
2921
const data = Object.assign({}, request.headers);
3022
const logger = { trace: () => {} };
3123
const stringToSign = constructStringToSignV2(request, data, logger, 'GCP');
32-
33-
console.log('[signGcpRequest] String to sign:', stringToSign);
34-
24+
3525
// Sign with HMAC-SHA1
3626
const signature = crypto.createHmac('sha1', credentials.secretKey)
3727
.update(stringToSign)
3828
.digest('base64');
39-
40-
console.log('[signGcpRequest] Generated signature:', signature);
41-
29+
4230
// Set Authorization header
4331
// eslint-disable-next-line no-param-reassign
4432
request.headers['Authorization'] = `GOOG1 ${credentials.accessKey}:${signature}`;

0 commit comments

Comments
 (0)