♻️ parse optional attributes instead of all key to improve performance and switch to a subobject usermetadata

Issue: CLDSRV-813

Author: DarkIsDude

lib/api/bucketGet.js

@@ -264,26 +264,37 @@ function processMasterVersions(bucketName, listParams, list) {
 
 function processOptionalAttributes(item, optionalAttributes) {
     const xml = [];
-
-    for (const key of Object.keys(item)) {
-        if (key.startsWith('x-amz-meta-')) {
-            if (optionalAttributes.includes('x-amz-meta-*') || optionalAttributes.includes(key)) {
-                xml.push(`<${key}>${item[key]}</${key}>`);
-            }
+    const userMetadata = new Set();
+
+    for (const attribute of optionalAttributes) {
+        switch (attribute) {
+            case 'RestoreStatus':
+                xml.push('<RestoreStatus>');
+                xml.push(`<IsRestoreInProgress>${!!item.restoreStatus?.inProgress}</IsRestoreInProgress>`);
+
+                if (item.restoreStatus?.expiryDate) {
+                    xml.push(`<RestoreExpiryDate>${item.restoreStatus?.expiryDate}</RestoreExpiryDate>`);
+                }
+
+                xml.push('</RestoreStatus>');
+                break;
+            case 'x-amz-meta-*':
+                for (const key of Object.keys(item.userMetadata)) {
+                    userMetadata.add(key);
+                }
+                break;
+            default:
+                if (item.userMetadata?.[attribute]) {
+                    userMetadata.add(attribute);
+                }
         }
     }
 
-    if (optionalAttributes.includes('RestoreStatus')) {
-        xml.push('<RestoreStatus>');
-        xml.push(`<IsRestoreInProgress>${!!item.restoreStatus?.inProgress}</IsRestoreInProgress>`);
-
-        if (item.restoreStatus?.expiryDate) {
-            xml.push(`<RestoreExpiryDate>${item.restoreStatus?.expiryDate}</RestoreExpiryDate>`);
-        }
-
-        xml.push('</RestoreStatus>');
+    for (const key of userMetadata) {
+        xml.push(`<${key}>${item.userMetadata[key]}</${key}>`);
     }
 
+
     return xml;
 }